This is a list of all comments for UI-DEN-14517-1.

Review Summary: No summary


----------------------------------------
File: sources/cloudsync/CloudSyncController.cpp
Revision Comment by vduong on 10 February 2023, 07:03 
https://devapps.diality.us/cru/UI-DEN-14517-1#c16470

  The variable, destination, itself is a QString, you don't need
  to do QString("%1").arg(destination), you can pass destination
  in directly.

  Reply by Behrouz NematiPour on 10 February 2023, 07:12
  > Thanks for the feedback.
  > Fixed.

    Reply by vduong on 10 February 2023, 07:16
    > RESOLVED

----------------------------------------
File: sources/storage/TreatmentLog.h
Revision Comment by vduong on 10 February 2023, 07:37 
https://devapps.diality.us/cru/UI-DEN-14517-1#c16473

  Only a suggestion:
  It is a good idea to append the unit to the end of the variable
  name especially for time. It helps improve readability and
  clarity. 
  
  For instance, here, we have ms and the next one,
  _pendingInterval is in seconds. and I believe _pendingCounter
  is in minutes based on the .cpp file's comment.
  
  _interval_ms
  _pendingInterval_sec
  _pendingCounter_min

  Reply by Behrouz NematiPour on 10 February 2023, 08:03
  > Good point,
  > I agree with the two intervals, it would be clarifying.
  > For the counter, though, it might not be always the case.
  > I will start doing it in my next task, since I would like to
  > change all, to be consistent across the entire code base.

    Reply by vduong on 10 February 2023, 09:17
    > Ok, sounds good. 
    > 
    > RESOLVED


---

ID: UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1

Title: UI-DEN-14517_UI BN S88
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     vduong   (*)
     Michael Garthwaite   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     Dara Navaei
     jishii