This is a list of all comments for UI-DEN-14609-1.

Review Summary: No summary


----------------------------------------
File: scripts/wifi_start_wpa_supplicant.sh
Revision Comment by Behrouz NematiPour on 01 February 2023, 00:17 
https://devapps.diality.us/cru/UI-DEN-14609-1#c16278

  Please remove this.
  We are not required to set up ethernet.
  It is only used in the run.sh for development and service.and
  we may remove it

  Reply by vduong on 06 February 2023, 12:36
  > Ok, will remove.

    Reply by vduong on 07 February 2023, 12:49
    > Removed ethernet setup line.

      Reply by Behrouz NematiPour on 07 February 2023, 22:17
      > RESOLVED

----------------------------------------
File: scripts/run.sh
Revision Comment by Behrouz NematiPour on 01 February 2023, 00:13 
https://devapps.diality.us/cru/UI-DEN-14609-1#c16276

  As a general comment, you don't need to worry about the
  copyrights, and it will be updated/overwritten by our Bamboo
  server scripts with the last user and date and time.

  Reply by vduong on 06 February 2023, 12:33
  > Noted.

    Reply by Behrouz NematiPour on 06 February 2023, 14:56
    > RESOLVED

Revision Comment by Behrouz NematiPour on 01 February 2023, 00:14 
https://devapps.diality.us/cru/UI-DEN-14609-1#c16277

  please log your steps results in POSTOUT and POSTERR like what
  is done (deleted line) on line 124.

  Reply by vduong on 06 February 2023, 12:34
  > Will change to :
  > systemctl start wpa_supplicant@wlan0.service 1>> $POSTOUT 2>>
  > $POSTERR

    Reply by vduong on 07 February 2023, 12:48
    > Fixed, please see changes  for logging of steps.

      Reply by Behrouz NematiPour on 07 February 2023, 22:16
      > RESOLVED

Revision Comment by Behrouz NematiPour on 07 February 2023, 22:15 
https://devapps.diality.us/cru/UI-DEN-14609-1#c16416

  This line should be in the else block.

  Reply by vduong on 08 February 2023, 08:17
  > Updated

    Reply by Behrouz NematiPour on 08 February 2023, 08:19
    > RESOLVED


---

ID: UI-DEN-14609-1 https://devapps.diality.us/cru/UI-DEN-14609-1

Title: UI-DEN-14609_UI VD S89
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: vduong
Reviewers: (3 active, 4 completed*)
     Tiffany Mejia   (*)
     Michael Garthwaite   (*)
     Behrouz NematiPour   (*)
     jishii   (*)
     Sean Nash
     jreaume
     Dara Navaei