This is a list of all comments for UI-DEN-14838-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/components/RangeRect.qml
Revision Comment by Behrouz NematiPour on 07 March 2023, 18:26 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16622

  typo: ajust => adjust

  Reply by vduong on 09 March 2023, 09:34
  > Updated, thank you

    Reply by Behrouz NematiPour on 14 March 2023, 10:58
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:24 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16620

  Please let the following calculation of the overlap do the
  separation.
  Otherwise will completely overlap and eventually displays one
  value which would be confusing.
  And also creates a position jump.

  Reply by vduong on 09 March 2023, 09:34
  > It will display two same values with one tick. 
  > 
  > I have removed the check.

    Reply by Behrouz NematiPour on 14 March 2023, 10:58
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:25 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16621

  Please change the minimum gap to 4.
  I think when tested, 4 was sufficient.

  Reply by vduong on 09 March 2023, 09:35
  > Updated.

    Reply by Behrouz NematiPour on 14 March 2023, 10:58
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:32 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16625

  in general, if the comment is for the entire if block put it in
  front of the if block.
  also for the else at line 66.

  Reply by vduong on 09 March 2023, 09:37
  > Will make note. Changed comment to reflect.

    Reply by Behrouz NematiPour on 14 March 2023, 10:59
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:30 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16623

  please move after the text property and remove the extra empty
  line.

  Reply by vduong on 09 March 2023, 09:39
  > Moved onTextChanged line and removed extra newline

    Reply by Behrouz NematiPour on 14 March 2023, 10:59
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:30 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16624

  please move after the text property.

  Reply by vduong on 09 March 2023, 09:39
  > This is after the text property.  I removed the newline
  > between them as a change

    Reply by Behrouz NematiPour on 14 March 2023, 10:59
    > RESOLVED

----------------------------------------
File: sources/gui/qml/components/Slider.qml
Revision Comment by Behrouz NematiPour on 07 March 2023, 18:45 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16626

  Didn't we find an issue with changing this to bool instead of
  alias while were testing?

  Reply by vduong on 09 March 2023, 09:40
  > I think we wanted the alias and not the bool. I vaguely
  > remember suggesting the change to alias. This could've been a
  > revert change. I am not sure. I will change it back to alias

    Reply by Behrouz NematiPour on 14 March 2023, 11:00
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2023, 18:47 
https://devapps.diality.us/cru/UI-DEN-14838-1#c16628

  please remove an extra empty line which is not necessary.

  Reply by vduong on 09 March 2023, 11:33
  > Can you check on the latest commit if this space was already
  > removed? I can't tell which line this comment is in regards
  > to. Thanks!

    Reply by Behrouz NematiPour on 14 March 2023, 10:59
    > RESOLVED


---

ID: UI-DEN-14838-1 https://devapps.diality.us/cru/UI-DEN-14838-1

Title: UI-DEN-14838_UI VD S91 [ Sliders ]
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: vduong
Reviewers: (5 active, 2 completed*)
     Behrouz NematiPour   (*)
     jishii   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei