This is a list of all comments for UI-DEN-14866-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
Revision Comment by vduong on 03 March 2023, 15:53 
https://devapps.diality.us/cru/UI-DEN-14866-1#c16568

  Is there a specific reason to why we are opting to use a
  connection here instead of handling the signal in the component
  body? (ie: line 181 further down?)

  Reply by Behrouz NematiPour on 03 March 2023, 16:27
  > The reason is separation and keeping the logic of the Slider
  > and its ON/OFF switch clear and non-confusing, and
  > independent.
  > Like right now that I had a wrong fix and I easily just
  > changed the connection related to the fix I had not changed
  > the Slider implementation itself.

    Reply by vduong on 03 March 2023, 17:41
    > RESOLVED

Revision Comment by vduong on 03 March 2023, 15:58 
https://devapps.diality.us/cru/UI-DEN-14866-1#c16569

  I believe we can bind the active state of
  _heparinDispensingRateSwitch and _heparinStopTime together.

  Reply by Behrouz NematiPour on 03 March 2023, 16:29
  > Unfortunately, we can't and it created a binding loop.
  > I tried it.

    Reply by vduong on 05 March 2023, 19:45
    > RESOLVED

Revision Comment by vduong on 03 March 2023, 15:59 
https://devapps.diality.us/cru/UI-DEN-14866-1#c16570

  Binding here for instance, enabled:
  _heparinDispensingRateSwitch.active

  Reply by Behrouz NematiPour on 03 March 2023, 16:29
  > This is the default value of the heparinStopTime.
  > If you bind to the active of the dispensing switch nothing
  > will happen, since the switch by default is active=false and
  > if active is not changed, no signal, therefore no property
  > change will happen, and the enable remains unchanged, as
  > true.

    Reply by vduong on 03 March 2023, 17:52
    > I disagree. If we bind the value here to the "active"
    > property, the value it takes is whatever "active" has when
    > the component gets created.

      Reply by vduong on 05 March 2023, 19:39
      > RESOLVED


---

ID: UI-DEN-14866-1 https://devapps.diality.us/cru/UI-DEN-14866-1

Title: UI-DEN-14866_UI BN S92
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (3 active, 4 completed*)
     Sean Nash   (*)
     vduong   (*)
     Michael Garthwaite   (*)
     jishii   (*)
     jreaume
     Tiffany Mejia
     Dara Navaei