This is a list of all comments for UI-DEN-14909-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/components/Slider.qml Revision Comment by Behrouz NematiPour on 13 March 2023, 05:16 https://devapps.diality.us/cru/UI-DEN-14909-1#c16688 Why was this Rectangle added? the ProgressRect is a Rectangle and can be used for the active color, and the _progressRectBackground seems redundant. Reply by vduong on 13 March 2023, 12:54 > We had a discussion about what needed to be done and you had > mentioned that the progressRect would be transparent. In > order for that to be transparent, we needed a background > rectangle color. BUT we had talked this morning and I will > remove this rectangle and just set the progress rect's color > as w/e the active color is. Reply by Behrouz NematiPour on 13 March 2023, 13:42 > Thanks, > Sorry for the confusion. > Yes, please, as we talked, the active progress should be > orange, and the background I think can stay as it was. > Then you can remove that extra Rectangle. Reply by vduong on 14 March 2023, 11:08 > Yes, i will remove the Retangle and set the color as we > did before, with the change that the Slider's color for > active will be a SliderHighlightColor / Orange instead of > the light blue Reply by Behrouz NematiPour on 14 March 2023, 11:40 > RESOLVED Revision Comment by Behrouz NematiPour on 13 March 2023, 05:18 https://devapps.diality.us/cru/UI-DEN-14909-1#c16689 Why was this property added? Reply by vduong on 13 March 2023, 12:48 > I believe this is leftover code that I missed from the slider > bug fixes. I'll remove it for this branch. Reply by Behrouz NematiPour on 14 March 2023, 11:40 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/TickMarks.qml Revision Comment by Behrouz NematiPour on 13 March 2023, 04:20 https://devapps.diality.us/cru/UI-DEN-14909-1#c16685 In C++ the trinary "?" operator will call both true and false sections and then will decide which to return. If that is the case for the QML/JS I suggest using a function with an if block to return the decided object. to ensure the trinary "?" operator behavior, you can use the "Component.onCompleted: {", if the new Qt 5.15 in-line Component declaration supports it. Reply by vduong on 13 March 2023, 12:56 > We had this discussion this morning, I have already tested it > also. It is working as we expected. It only prints out the > round tick's Component.onCompleted log messages of the round > tick marks and not both the round and lined tick marks. This > is operating as we expected. Reply by Behrouz NematiPour on 13 March 2023, 14:08 > RESOLVED. > > Thanks for the test, that is what I remembered. > Fine then Revision Comment by Behrouz NematiPour on 13 March 2023, 04:27 https://devapps.diality.us/cru/UI-DEN-14909-1#c16686 Why In-Line Component is used. The idea behind the loader is to set them active if only it is set active. Does the in-line component have the same efficiency? Please test and provide proof of concept, since this feature is very new and I haven't tested it. If can't be proven, use the loader only, please. Reply by vduong on 13 March 2023, 12:57 > This may be a new concept for the project, but it's something > that I've used and have seen used before in other QML > projects. > > This also guarantees that you are only loading the object > when you need it when you use it with the Loader. > > The Component itself, if you look at the Qt documentation, > you will find "The component encapsulates the QML types > within, as if they were defined in a separate QML file, and > is not loaded until requested (in this case, by the two > Loader objects)." > > So, I am sure this is efficient. Reply by Behrouz NematiPour on 13 March 2023, 13:54 > 1 - The component instance has been used in the same file, > and that is the new feature, and previously we have to > create a file to use the component instance, or directly > return the created component for one instance use. > 2 - The Loader is used inside of the component, which > doesn't seem right, the idea is to use inline components > so, if possible, avoid loaders. > 3 - Multiple components for the line tickmarks and round > ones are created since it seems only a property change to > make it rounded, since QML doesn't have a line or circle > and all are Rectangle, it makes sense to update the > underlying rectangle properties to get the desired shape. Reply by vduong on 14 March 2023, 10:31 > I have a possible better solution that will avoid both. I > will implement and push the code. Reply by Behrouz NematiPour on 14 March 2023, 11:49 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/RangeSlider.qml Revision Comment by Behrouz NematiPour on 13 March 2023, 04:45 https://devapps.diality.us/cru/UI-DEN-14909-1#c16687 Regarding our new design change requests all tick marks shall be round by default. Reply by vduong on 13 March 2023, 12:55 > Ok, easy change over. Reply by Behrouz NematiPour on 14 March 2023, 11:39 > RESOLVED --- ID: UI-DEN-14909-1 https://devapps.diality.us/cru/UI-DEN-14909-1 Title: UI-DEN-14909_UI VD S92 QS Sliders Statement of Objectives: State: Closed Summary: Author: vduong Moderator: vduong Reviewers: (5 active, 2 completed*) Behrouz NematiPour (*) jishii (*) Sean Nash jreaume Tiffany Mejia Michael Garthwaite Dara Navaei