This is a list of all comments for UI-DEN-15037-3.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/dialogs/DiagnosticsDialog.qml
Revision Comment by Michael Garthwaite on 04 April 2023, 10:41 
https://devapps.diality.us/cru/UI-DEN-15037-3#c17043

  These values are U32 from FW, do we need to add the toFixed(2)?

  Reply by Behrouz NematiPour on 04 April 2023, 16:09
  > Thank you for pointing that out.
  > The message view was our of sync as well which has been
  > fixed.

    Reply by Michael Garthwaite on 04 April 2023, 16:12
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: sources/gui/qml/components/Slider.qml
Revision Comment by vduong on 04 April 2023, 10:42 
https://devapps.diality.us/cru/UI-DEN-15037-3#c17044

  This will give you undesired results. I have done this before
  and it will end up showing us the intermediate values.

  Reply by Behrouz NematiPour on 04 April 2023, 11:04
  > Thanks for the comment,
  > Looks tricky to me too.
  > But worked fine for me now.
  > Will keep track of its behavior.

    Reply by vduong on 04 April 2023, 22:30
    > RESOLVED


---

ID: UI-DEN-15037-3 https://devapps.diality.us/cru/UI-DEN-15037-3

Title: UI-DEN-15037-UI-BN-S94 [ReleaseMisc]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     jishii   (*)
     jreaume
     vduong
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei