This is a list of all comments for UI-DEN-15279-1. Review Summary: No summary ---------------------------------------- File: scripts/start.sh Revision Comment by vduong on 20 June 2023, 04:58 https://devapps.diality.us/cru/UI-DEN-15279-1#c17932 typo, "Continueing" -> "Continuing" Reply by Behrouz NematiPour on 17 July 2023, 13:35 > It has been fixed in the new ui.scripts repository. Reply by vduong on 17 July 2023, 14:33 > RESOLVED ---------------------------------------- File: sources/canbus/MessageInterpreter.cpp Revision Comment by msuleiman on 17 July 2023, 09:56 https://devapps.diality.us/cru/UI-DEN-15279-1#c18131 if statement needs condition results needs to be surrounded by braces {} even for single line code Reply by Behrouz NematiPour on 17 July 2023, 13:36 > It has been added. Reply by Dara Navaei on 19 October 2023, 10:32 > RESOLVED ---------------------------------------- File: sources/gui/qml/main.qml Revision Comment by vduong on 05 June 2023, 10:02 https://devapps.diality.us/cru/UI-DEN-15279-1#c17759 untill -> until Reply by Behrouz NematiPour on 12 June 2023, 01:52 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:34 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/settings/SettingsServicePassword.qml Revision Comment by vduong on 05 June 2023, 09:58 https://devapps.diality.us/cru/UI-DEN-15279-1#c17756 "accpeted" -> "accepted" Reply by Behrouz NematiPour on 12 June 2023, 01:53 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:34 > RESOLVED Revision Comment by vduong on 05 June 2023, 09:58 https://devapps.diality.us/cru/UI-DEN-15279-1#c17757 of -> if Reply by Behrouz NematiPour on 12 June 2023, 01:53 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:34 > RESOLVED Revision Comment by vduong on 05 June 2023, 10:00 https://devapps.diality.us/cru/UI-DEN-15279-1#c17758 Should this check be done before we ask HD to go to service mode? ie: go to service mode as the else condtion of this noCANBus check Reply by Behrouz NematiPour on 14 June 2023, 20:00 > I created a case for this, > please resolve and we will follow up under the case is being > displayed above ( DEN-15646 ). Reply by vduong on 17 July 2023, 13:25 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/TextEntry.qml Revision Comment by vduong on 05 June 2023, 09:55 https://devapps.diality.us/cru/UI-DEN-15279-1#c17754 "enditable" < Not sure if you meant "editable" here. Reply by Behrouz NematiPour on 12 June 2023, 01:54 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:35 > RESOLVED Revision Comment by vduong on 05 June 2023, 09:56 https://devapps.diality.us/cru/UI-DEN-15279-1#c17755 "nned" -> "need" This comment should be revised to be clearer. It's not entirely clear what we mean here. Reply by Behrouz NematiPour on 12 June 2023, 01:54 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:35 > RESOLVED ---------------------------------------- File: sources/device/DeviceController.cpp Revision Comment by pvedantam on 20 June 2023, 15:59 https://devapps.diality.us/cru/UI-DEN-15279-1#c17944 It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No" Reply by Behrouz NematiPour on 17 July 2023, 12:54 > In the scripts "Yes/YES" means the default value, or the > suggested value and "no", is the opposite. Reply by Dara Navaei on 19 October 2023, 10:33 > RESOLVED Revision Comment by vduong on 20 June 2023, 05:01 https://devapps.diality.us/cru/UI-DEN-15279-1#c17933 Function name here does not match the actual function Reply by vduong on 17 July 2023, 14:32 > RESOLVED Revision Comment by pvedantam on 20 June 2023, 16:06 https://devapps.diality.us/cru/UI-DEN-15279-1#c17945 Please add function headers as needed Reply by Behrouz NematiPour on 17 July 2023, 15:00 > added Reply by Dara Navaei on 19 October 2023, 10:33 > RESOLVED Revision Comment by pvedantam on 22 June 2023, 10:40 https://devapps.diality.us/cru/UI-DEN-15279-1#c17979 The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ? Reply by Behrouz NematiPour on 17 July 2023, 13:47 > the error will be visible to user and needs to be addressed > if can not be resolved. > In normal operation it is not expected to happen, and if > happens, it is a FS issue. Reply by Dara Navaei on 19 October 2023, 10:33 > RESOLVED Revision Comment by vduong on 17 July 2023, 07:25 https://devapps.diality.us/cru/UI-DEN-15279-1#c18112 Need to change to match the function name Reply by vduong on 17 July 2023, 14:20 > RESOLVED ---------------------------------------- File: sources/device/DeviceView.h Revision Comment by vduong on 17 July 2023, 07:45 https://devapps.diality.us/cru/UI-DEN-15279-1#c18113 "situaltoins" -> "situations" Reply by Behrouz NematiPour on 17 July 2023, 13:48 > Fixed. Reply by vduong on 17 July 2023, 13:57 > RESOLVED ---------------------------------------- File: sources/storage/StorageGlobals.cpp Revision Comment by vduong on 20 June 2023, 05:29 https://devapps.diality.us/cru/UI-DEN-15279-1#c17938 "reenalbe" -> "reenable" Reply by vduong on 17 July 2023, 14:20 > RESOLVED Revision Comment by vduong on 20 June 2023, 05:30 https://devapps.diality.us/cru/UI-DEN-15279-1#c17939 This comment is incorrect Reply by Behrouz NematiPour on 17 July 2023, 13:53 > updated. Reply by vduong on 17 July 2023, 14:20 > RESOLVED ---------------------------------------- File: sources/ApplicationController.cpp Revision Comment by vduong on 20 June 2023, 05:33 https://devapps.diality.us/cru/UI-DEN-15279-1#c17941 missing doxygen comment Reply by Behrouz NematiPour on 17 July 2023, 13:54 > added Reply by vduong on 17 July 2023, 14:19 > RESOLVED ---------------------------------------- File: sources/ApplicationController.h Revision Comment by vduong on 05 June 2023, 10:04 https://devapps.diality.us/cru/UI-DEN-15279-1#c17760 filed -> "failed" ? hte -> the Reply by Behrouz NematiPour on 12 June 2023, 01:51 > Thanks, > Fixed. Reply by vduong on 13 June 2023, 13:01 > RESOLVED Revision Comment by vduong on 05 June 2023, 10:05 https://devapps.diality.us/cru/UI-DEN-15279-1#c17761 signall -> signal successfull -> successful Reply by Behrouz NematiPour on 12 June 2023, 01:51 > Thanks, > Fixed. Reply by vduong on 14 June 2023, 06:34 > RESOLVED ---------------------------------------- File: sources/ApplicationPost.cpp Revision Comment by pvedantam on 22 June 2023, 11:19 https://devapps.diality.us/cru/UI-DEN-15279-1#c17982 It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar Reply by Behrouz NematiPour on 22 June 2023, 14:46 > [~pvedantam] > The Ethernet POST is not a requirement, and if it fails UI > will not fail the POST. Reply by Dara Navaei on 19 October 2023, 10:33 > RESOLVED ---------------------------------------- File: sources/storage/Settings.cpp Revision Comment by vduong on 20 June 2023, 05:20 https://devapps.diality.us/cru/UI-DEN-15279-1#c17934 I am just checking whether "NotExits" is what you intend or "NotExists" based on the removed log message. Reply by Behrouz NematiPour on 17 July 2023, 13:51 > Not clear what needs be addressed here? Reply by vduong on 17 July 2023, 13:59 > I believe you have a spelling typo here. > > eError_SettingNotExits or eError_SettingNotExists ? Reply by vduong on 17 July 2023, 15:05 > RESOLVED Reply by Behrouz NematiPour on 17 July 2023, 15:08 > Correct, it was a typo and fixed. Revision Comment by vduong on 20 June 2023, 05:23 https://devapps.diality.us/cru/UI-DEN-15279-1#c17936 Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural? Reply by vduong on 17 July 2023, 14:43 > RESOLVED Revision Comment by vduong on 20 June 2023, 05:21 https://devapps.diality.us/cru/UI-DEN-15279-1#c17935 Missing doxygen comment Reply by vduong on 17 July 2023, 07:54 > RESOLVED Revision Comment by msuleiman on 17 July 2023, 10:34 https://devapps.diality.us/cru/UI-DEN-15279-1#c18134 Should use {} for if statement Reply by Behrouz NematiPour on 17 July 2023, 13:51 > added Reply by Dara Navaei on 19 October 2023, 10:35 > RESOLVED ---------------------------------------- File: sources/storage/Settings.h Revision Comment by vduong on 20 June 2023, 05:23 https://devapps.diality.us/cru/UI-DEN-15279-1#c17937 "trasnlated" - > "translated" Reply by Behrouz NematiPour on 17 July 2023, 13:51 > fixed Reply by vduong on 17 July 2023, 14:01 > RESOLVED ---------------------------------------- File: sources/view/settings/VAdjustmentAlarmVolume.cpp Revision Comment by vduong on 20 June 2023, 05:31 https://devapps.diality.us/cru/UI-DEN-15279-1#c17940 Doxygen comment incorrect for below function Reply by Behrouz NematiPour on 17 July 2023, 13:53 > updated Reply by vduong on 17 July 2023, 14:19 > RESOLVED ---------------------------------------- File: scripts/globals.sh Revision Comment by pvedantam on 20 June 2023, 17:13 https://devapps.diality.us/cru/UI-DEN-15279-1#c17946 Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you could reorder the startup sequence. Reply by Behrouz NematiPour on 17 July 2023, 13:33 > [~pvedantam], > Will work on this on the tickets we have for the boot up > performance improvement. Reply by Dara Navaei on 19 October 2023, 10:36 > RESOLVED ---------------------------------------- File: sources/storage/Logger.cpp Revision Comment by vduong on 17 July 2023, 07:51 https://devapps.diality.us/cru/UI-DEN-15279-1#c18115 How does this affect the "clean up" code for when the disk space reaches a certain percentage? Reply by Behrouz NematiPour on 17 July 2023, 11:55 > Thanks [~vduong], > That is a very important point. > I have never thought about it. > Probably does the same for the new place but the usage > percentage needs to be adjusted/reviewed. > I will create a ticket for this. Reply by vduong on 17 July 2023, 13:58 > RESOLVED Revision Comment by vduong on 17 July 2023, 07:51 https://devapps.diality.us/cru/UI-DEN-15279-1#c18116 // DEBUG: needed Reply by Behrouz NematiPour on 17 July 2023, 13:49 > Added Reply by vduong on 17 July 2023, 13:58 > RESOLVED Revision Comment by vduong on 17 July 2023, 07:52 https://devapps.diality.us/cru/UI-DEN-15279-1#c18117 Need doxygen comment Reply by Behrouz NematiPour on 17 July 2023, 13:49 > Added Reply by vduong on 17 July 2023, 13:58 > RESOLVED ---------------------------------------- File: sources/storage/FileHandler.cpp Revision Comment by vduong on 17 July 2023, 07:49 https://devapps.diality.us/cru/UI-DEN-15279-1#c18114 "availabel" => "available" Reply by vduong on 17 July 2023, 13:58 > RESOLVED --- ID: UI-DEN-15279-1 https://devapps.diality.us/cru/UI-DEN-15279-1 Title: DEN-15279-UI-BN-S97-Cybersecurity-Application [ Ready ] Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (6 active, 2 completed*) vduong (*) msuleiman (*) Sean Nash jreaume pvedantam Tiffany Mejia Michael Garthwaite Dara Navaei