This is a list of all comments for UI-DEN-15905-2.

Review Summary: No summary


----------------------------------------
File: denali.qrc
Revision Comment by vduong on 21 July 2023, 05:21 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18227

  If the file is indeed incorrectly named, please also correct
  here

  Reply by Behrouz NematiPour on 24 July 2023, 10:23
  > this will automatically get corrected when the file name is
  > changed in the file explorer of the QtCreator.

    Reply by vduong on 24 July 2023, 10:57
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/endtreatment/EndTreatmentRecirculateStack.qml
Revision Comment by vduong on 21 July 2023, 05:19 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18225

  Please remove empty space.

  Reply by Behrouz NematiPour on 24 July 2023, 10:54
  > removed

    Reply by vduong on 24 July 2023, 10:56
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/endtreatment/EndTreatmentRinsebackStack.qml
Revision Comment by vduong on 21 July 2023, 05:19 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18226

  This should not have worked considering the QML file is
  misnamed. Please re-check

  Reply by Behrouz NematiPour on 24 July 2023, 10:22
  > the file and the actual Class name does not necessary should
  > be the same.
  > to make sure these are not dependent, I use alias in the qrc.
  > so although the name was not correct this still works.

    Reply by vduong on 24 July 2023, 10:57
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/endtreatment/rinseback/EndTreatmentRinsebaReconnect.qml
Revision Comment by vduong on 21 July 2023, 05:16 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18222

  The file name is missing "ck" for the back. I don't believe you
  did that on purpose ?

  Reply by Behrouz NematiPour on 24 July 2023, 10:53
  > thank for catching that,
  > it has been fixed.

    Reply by vduong on 24 July 2023, 10:56
    > RESOLVED

Revision Comment by vduong on 21 July 2023, 05:17 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18223

  I am assuming you are purposely adding "treatmentBackClicked"
  signal for clarity here? The back signal from the base
  (EndTreatmentBase) can be detected as part of the
  EndTreatmentRinseBackConnect Item.

  Reply by Behrouz NematiPour on 24 July 2023, 10:19
  > Correct, that is for clarification since in each of the
  > child(ish) classes in stack back and confirm have different
  > meaning.

    Reply by vduong on 24 July 2023, 10:56
    > RESOLVED

Revision Comment by vduong on 21 July 2023, 05:18 
https://devapps.diality.us/cru/UI-DEN-15905-2#c18224

  "compeleted" => "completed"

  Reply by vduong on 24 July 2023, 10:56
  > RESOLVED


---

ID: UI-DEN-15905-2 https://devapps.diality.us/cru/UI-DEN-15905-2

Title: UI-DEN-15905-UI-BN-S102 [ Ready ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (4 active, 2 completed*)
     vduong   (*)
     Tiffany Mejia   (*)
     Sean Nash
     jreaume
     Michael Garthwaite
     Dara Navaei