This is a list of all comments for UI-DEN-15918-3.

Review Summary: No summary


----------------------------------------
File: sources/device/DeviceController.cpp
Revision Comment by Behrouz NematiPour on 08 August 2023, 16:28 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18503

  Why it is different than the same function for the SD-card?
  It is a mounted drive.

  Reply by vduong on 09 August 2023, 07:24
  > For SD card case, when the SD card is not ready, we update
  > the visuals to set the 
  > "available" and "used" to 0 and emit the update. For this
  > case, we are not updating 
  > any visuals. The need we have for this function is to
  > determine whether we are 
  > low on available partition space and if we are, emit the
  > "low" signal to handle

  Reply by vduong on 10 August 2023, 07:35
  > After our conversation, I have changed as requested.

    Reply by Behrouz NematiPour on 13 August 2023, 19:33
    > RESOLVED

Revision Comment by Behrouz NematiPour on 08 August 2023, 16:27 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18502

  please add //DEBUG

  Reply by vduong on 10 August 2023, 07:35
  > Done

    Reply by Behrouz NematiPour on 13 August 2023, 19:33
    > RESOLVED

----------------------------------------
File: sources/storage/Logger.cpp
Revision Comment by Behrouz NematiPour on 08 August 2023, 16:41 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18506

  as has been mentioned follow the other two (USB, Sd-Card)
  methods naming and signature.

  Reply by vduong on 10 August 2023, 07:35
  > Changed as requested

    Reply by Behrouz NematiPour on 13 August 2023, 19:32
    > RESOLVED

----------------------------------------
File: sources/device/DeviceController.h
Revision Comment by Behrouz NematiPour on 08 August 2023, 16:36 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18505

  please follow the same naming and arguments for the 
  did<device>SpaceChange(bool vReady, ....)
  did<device>StateChange( ... )
  
  don't think we need toolow fir this one.

  Reply by vduong on 09 August 2023, 07:43
  > I don't believe we need did * spaceChange. I am not
  > interested in when the space changes. 
  > I am only interested when that partition gets too low on
  > available space. Unless there is a 
  > case that you have which indicates otherwise. 
  > This signal is similar to didSDCardSpaceTooLow, line 231

    Reply by vduong on 10 August 2023, 05:11
    > I resolved my own message because of the conversation we
    > had in terms of why I am making the change suggested.

      Reply by Behrouz NematiPour on 13 August 2023, 19:33
      > RESOLVED

  Reply by vduong on 10 August 2023, 07:35
  > Changed as requested

    Reply by Behrouz NematiPour on 13 August 2023, 19:33
    > RESOLVED

----------------------------------------
File: sources/storage/StorageGlobals.cpp
Revision Comment by Behrouz NematiPour on 08 August 2023, 16:31 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18504

  we already have the same variable define as Settings_Path_Name.
  Please use that

  Reply by vduong on 10 August 2023, 07:34
  > I have removed the added and using the Settings_Path()

    Reply by Behrouz NematiPour on 13 August 2023, 19:33
    > RESOLVED

----------------------------------------
File: sources/storage/StorageGlobals.h
Revision Comment by Behrouz NematiPour on 11 August 2023, 12:52 
https://devapps.diality.us/cru/UI-DEN-15918-3#c18541

  Please remove this as well, regarding the changes made in CPP

  Reply by vduong on 11 August 2023, 18:58
  > Removed.

    Reply by Behrouz NematiPour on 13 August 2023, 19:31
    > RESOLVED


---

ID: UI-DEN-15918-3 https://devapps.diality.us/cru/UI-DEN-15918-3

Title: UI-DEN-15918 - DEN-15918-UI-VD-S102-Sd-Card-TmpFolder - [Ready] 
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: vduong
Reviewers: (5 active, 2 completed*)
     msuleiman   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei