This is a list of all comments for UI-DEN-16123-6.

Review Summary: No summary


----------------------------------------
File: sources/storage/TreatmentLog.cpp
Revision Comment by vduong on 14 August 2023, 08:37 
https://devapps.diality.us/cru/UI-DEN-16123-6#c18566

  Per the recent I/O failed ticket, we need to also do handle the
  write fail here similar to how we did there. Should we add it
  here now or open a ticket for later ?

  Reply by Behrouz NematiPour on 14 August 2023, 11:32
  > isn't it in another branch fixed by you.
  > if that is the case it will get merged later on staging.

    Reply by vduong on 14 August 2023, 11:42
    > No, that branch change had gone in already. The check was
    > added in the log() and not here.

      Reply by vduong on 14 August 2023, 13:01
      > RESOLVED per convo.

      Reply by Behrouz NematiPour on 14 August 2023, 13:02
      > this is the TxLog going on the encrypted partition not
      > the sd-card

        Reply by vduong on 14 August 2023, 13:04
        > RESOLVED


---

ID: UI-DEN-16123-6 https://devapps.diality.us/cru/UI-DEN-16123-6

Title: DEN-16123-UI-BN-S103-TxLog-Pending
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (6 active, 2 completed*)
     vduong   (*)
     Michael Garthwaite   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     jpaguio
     Dara Navaei
     msuleiman