This is a list of all comments for UI-DEN-16335-1.

Review Summary: No summary

General Comment by Behrouz NematiPour on 11 September 2023, 16:08 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18889

  I made myself the moderator to close the review after I was
  done with my 100% no comment left completed review.

  Reply by Behrouz NematiPour on 11 September 2023, 16:10
  > RESOLVED


----------------------------------------
File: sources/bluetooth/BluetoothInterface.cpp
Revision Comment by Behrouz NematiPour on 05 September 2023, 14:02 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18823

  when do we know if that is paired, I think the ticket wants
  that one, right?

  Reply by vduong on 05 September 2023, 14:03
  > Yes, ticket wants pairing, but you had stated in a call that
  > we need to go by the SRS or the requirement and the
  > requirement attached to the ticket said
  > disconnection/connection of accessories

    Reply by Behrouz NematiPour on 05 September 2023, 14:07
    > I remember and and can we use reconnect as a Paired State.

      Reply by vduong on 05 September 2023, 14:08
      > I think actually, we should connected as paired state. As
      > the re-connection is truly a re-connection after a
      > connection/pairing has been established

        Reply by Behrouz NematiPour on 05 September 2023, 14:09
        > not clear what it means.

          Reply by vduong on 05 September 2023, 15:55
          > I made the changes based on the call we had.

          Reply by Behrouz NematiPour on 05 September 2023, 16:43
          > RESOLVED

----------------------------------------
File: sources/bluetooth/BluetoothInterface.h
Revision Comment by Behrouz NematiPour on 05 September 2023, 13:41 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18819

  make it 
  bool isPaired();

  Reply by vduong on 05 September 2023, 15:55
  > This is no longer applicable due to the changes from our
  > conversation.

    Reply by Behrouz NematiPour on 05 September 2023, 16:41
    > RESOLVED

----------------------------------------
File: sources/model/settings/MBluetooth.cpp
Revision Comment by Behrouz NematiPour on 05 September 2023, 13:34 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18818

  please use the shorter constructor provided.
  the error needs to be initialized as well, then it becomes the
  simple one.

  Reply by vduong on 05 September 2023, 14:02
  > The shorter constructor is setting the local* values, I am
  > saving the device name and address. Also, the error member
  > variable is defaulted to 0 in the .h file.

    Reply by Behrouz NematiPour on 05 September 2023, 14:08
    > where do you use this ctor?

      Reply by vduong on 05 September 2023, 14:09
      > In bluetoothInterface.cpp, there's a set of macros
      > towards the top. NOTIFY_DEVICE_CONNECT and
      > NOTIFY_DEVICE_DISCONNECT

        Reply by vduong on 05 September 2023, 15:55
        > We clarify this thread with a call.

          Reply by Behrouz NematiPour on 05 September 2023, 16:45
          > RESOLVED

----------------------------------------
File: sources/view/settings/VBluetooth.cpp
Revision Comment by Behrouz NematiPour on 05 September 2023, 13:43 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18820

  make them one-liner in front of the if/else and align.

  Reply by vduong on 05 September 2023, 15:56
  > Done.

    Reply by Behrouz NematiPour on 05 September 2023, 16:44
    > RESOLVED

Revision Comment by Behrouz NematiPour on 05 September 2023, 13:52 
https://devapps.diality.us/cru/UI-DEN-16335-1#c18821

  move these two in the same location it was, to keep the order.

  Reply by vduong on 05 September 2023, 15:56
  > Per our call, you have agreed to leave it above in this
  > location. No change in location

    Reply by Behrouz NematiPour on 05 September 2023, 16:46
    > RESOLVED


---

ID: UI-DEN-16335-1 https://devapps.diality.us/cru/UI-DEN-16335-1

Title: UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
Statement of Objectives:
DEN-16319 UI log does not record blood pressure cuff bluetooth pairing

State: Closed

Summary: 

Author: vduong
Moderator: Behrouz NematiPour
Reviewers: (6 active, 1 completed*)
     msuleiman   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     jpaguio
     Michael Garthwaite
     Dara Navaei