This is a list of all comments for UI-DEN-16335-5.

Review Summary: No summary

General Comment by Behrouz NematiPour on 11 September 2023, 16:12 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18896

  I made myself the moderator to close the review after I was
  done with my 100% no comment left completed review.

  Reply by Behrouz NematiPour on 11 September 2023, 16:12
  > RESOLVED


----------------------------------------
File: sources/model/hd/data/treatment/MTreatmentOutletFlowData.h
Revision Comment by Behrouz NematiPour on 06 September 2023, 19:31 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18847

  Update the cpp as well

  Reply by vduong on 07 September 2023, 06:19
  > There is no CPP for this file. Unless you meant a different
  > location

    Reply by Behrouz NematiPour on 11 September 2023, 03:22
    > As far as I see there is MTreatmentOutletFlowData.cpp
    > do ctrl+k,p MTreatmentOutletFlowData
    > or ctrl+shift, MTreatmentOutletFlowData
    > or F4 in your MTreatmentOutletFlowData.h to get in the cpp
    > file
    > to find it.

      Reply by vduong on 11 September 2023, 06:18
      > Resolved and tested.

        Reply by Behrouz NematiPour on 11 September 2023, 11:43
        > RESOLVED

Revision Comment by Behrouz NematiPour on 06 September 2023, 20:11 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18851

  update the length check of the message in MessageGlobals.h
  {code}
  const QHash<Gui::GuiActionType ,quint8> payloadLen {
  .
  .
  {Gui::GuiActionType::ID_DialysateOutletFlow
  ,  10 * 4       }, //10 parameters each 4bytes
  .
  .
  }
  {code}

  Reply by vduong on 07 September 2023, 06:19
  > Done.

    Reply by Behrouz NematiPour on 11 September 2023, 03:20
    > RESOLVED

----------------------------------------
File: sources/view/hd/data/treatment/VTreatmentUltrafiltration.cpp
Revision Comment by Behrouz NematiPour on 06 September 2023, 19:49 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18849

  param 11 is missing
  {code}
  01    F32-refUFVolMl	              
  02    F32-measUFVolMl	              
  03    F32-measRotSpdRPM	            
  04    F32-measSpdRPM	              
  05    F32-measMCSpdRPM	            
  06    F32-measMCCurrmA	            
  07    F32-setPWMpct	                
  08    F32-dopCorrOffset	            
  09    F32-dopCalcRate	              
  10    F32-ufCalcRate	              
  11    U32-rotorHall	                
  12    F32-currentSetUFRate          
  
  {code}

  Reply by vduong on 07 September 2023, 06:19
  > Added.

    Reply by Behrouz NematiPour on 11 September 2023, 03:23
    > RESOLVED

Revision Comment by Behrouz NematiPour on 06 September 2023, 19:31 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18848

  I think we should use mL/min as is. and do not convert to
  Liter.

  Reply by vduong on 07 September 2023, 06:19
  > Removed conversion

    Reply by Behrouz NematiPour on 11 September 2023, 03:24
    > RESOLVED

----------------------------------------
File: sources/view/hd/data/treatment/VTreatmentUltrafiltration.h
Revision Comment by Behrouz NematiPour on 06 September 2023, 19:50 
https://devapps.diality.us/cru/UI-DEN-16335-5#c18850

  param 11 is missing
  {code}
  01    F32-refUFVolMl	              
  02    F32-measUFVolMl	              
  03    F32-measRotSpdRPM	            
  04    F32-measSpdRPM	              
  05    F32-measMCSpdRPM	            
  06    F32-measMCCurrmA	            
  07    F32-setPWMpct	                
  08    F32-dopCorrOffset	            
  09    F32-dopCalcRate	              
  10    F32-ufCalcRate	              
  11    U32-rotorHall	                
  12    F32-currentSetUFRate          
  {code}

  Reply by vduong on 07 September 2023, 06:20
  > Added

    Reply by Behrouz NematiPour on 11 September 2023, 03:24
    > RESOLVED


---

ID: UI-DEN-16335-5 https://devapps.diality.us/cru/UI-DEN-16335-5

Title: UI-DEN-16335_UI VD S105 - P1B - Display UF Rate - [READY]
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: Behrouz NematiPour
Reviewers: (6 active, 1 completed*)
     msuleiman   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     jpaguio
     Michael Garthwaite
     Dara Navaei