This is a list of all comments for UI-DEN-16526-3.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/AlarmItem.qml
Revision Comment by jtaylor on 03 November 2023, 11:32 
https://devapps.diality.us/cru/UI-DEN-16526-3#c19233

  Suggestion (spell check):
  
  // When alarm status 0 is sent from HD to clear/hide the
  AlarmDialog, it comes with priority 0
  // priority 0 has no clear definition; therefore, UI will set
  the coloring to the default system theme: blue.
  // The blue color is confusing users, so we skip this coloring.

  Reply by Behrouz NematiPour on 03 November 2023, 11:50
  > Used your exact suggestion.
  > thanks,

    Reply by jtaylor on 03 November 2023, 12:27
    > RESOLVED in CODE WALKTHROUGH
    > you're welcome.

----------------------------------------
File: sources/gui/qml/components/TouchRect.qml
Revision Comment by vduong on 03 November 2023, 11:34 
https://devapps.diality.us/cru/UI-DEN-16526-3#c19234

  typo for debounce  in the property name and also the timer's
  ID.

  Reply by Behrouz NematiPour on 03 November 2023, 11:50
  > fixed,
  > thanks for pointing that out.

    Reply by vduong on 03 November 2023, 11:57
    > RESOLVE

      Reply by Dara Navaei on 06 February 2024, 16:32
      > RESOLVED

Revision Comment by vduong on 03 November 2023, 11:50 
https://devapps.diality.us/cru/UI-DEN-16526-3#c19237

  You're missing an n in the "clickDeboucing" same issue with the
  others

  Reply by Behrouz NematiPour on 03 November 2023, 11:51
  > I fixed both,
  > isn't it?
  > that is what I see.

    Reply by Behrouz NematiPour on 03 November 2023, 11:52
    > Oh, I see, I am missing an "n".
    > Fixed

      Reply by vduong on 03 November 2023, 11:57
      > Yes, that's the other typo.

        Reply by vduong on 03 November 2023, 12:01
        > RESOLVED


---

ID: UI-DEN-16526-3 https://devapps.diality.us/cru/UI-DEN-16526-3

Title: UI-DEN-16526-UI-BN-S109-3 [ application ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (7 active, 2 completed*)
     vduong   (*)
     jtaylor   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     jpaguio
     Michael Garthwaite
     Dara Navaei
     msuleiman