This is a list of all comments for UI-DEN-16687-1.

Review Summary: No summary


----------------------------------------
File: sources/model/hd/data/MHDAirTrapData.h
Revision Comment by Behrouz NematiPour on 07 March 2024, 10:20 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19568

  please correct the numbering.

  Reply by Dara Navaei on 07 March 2024, 10:30
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 08:29
    > RESOLVED

----------------------------------------
File: denali.pro
Revision Comment by Behrouz NematiPour on 07 March 2024, 10:32 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19573

  move this to the Views - Settings for headers.

  Reply by Dara Navaei on 07 March 2024, 10:47
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 08:30
    > commented on the new location.
    > RESOLVED

Revision Comment by Behrouz NematiPour on 11 March 2024, 08:30 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19607

  This is the model section.
  please move to the view section.

  Reply by Dara Navaei on 11 March 2024, 08:48
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 09:03
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 March 2024, 10:32 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19574

  move this to the Views - Settings , cpp

  Reply by Dara Navaei on 07 March 2024, 10:46
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 08:31
    > commented on the new location.
    > RESOLVED

Revision Comment by Behrouz NematiPour on 11 March 2024, 08:33 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19610

  this is the model section.
  Please move to view section.

  Reply by Dara Navaei on 11 March 2024, 08:38
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 09:02
    > RESOLVED

----------------------------------------
File: sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
Revision Comment by Behrouz NematiPour on 07 March 2024, 10:18 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19567

  I assume this will automatically get updated on Bamboo, for
  both cpp and h right?
  If not update it.

  Reply by Dara Navaei on 07 March 2024, 10:28
  > Correct.

    Reply by Behrouz NematiPour on 11 March 2024, 08:33
    > RESOLVED

----------------------------------------
File: sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
Revision Comment by Behrouz NematiPour on 07 March 2024, 10:16 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19566

  please update the document for the payload.

  Reply by Dara Navaei on 07 March 2024, 10:44
  > Done

    Reply by Behrouz NematiPour on 11 March 2024, 08:28
    > RESOLVED

----------------------------------------
File: sources/view/settings/VAdjustmentInstitutionalRecord.cpp
Revision Comment by Behrouz NematiPour on 07 March 2024, 10:28 
https://devapps.diality.us/cru/UI-DEN-16687-1#c19569

  why did you call the parametersText every time?
  you only need to call it when the values are updated fully?

  Reply by Dara Navaei on 07 March 2024, 10:31
  > I thought it is needed. Removed them.

    Reply by Behrouz NematiPour on 11 March 2024, 08:29
    > RESOLVED


---

ID: UI-DEN-16687-1 https://devapps.diality.us/cru/UI-DEN-16687-1

Title: UI-DEN-16687_UI DN S117 Msg Update Log Files
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 3 completed*)
     Sean Nash   (*)
     msuleiman   (*)
     Behrouz NematiPour   (*)
     pvedantam
     Tiffany Mejia
     jpaguio
     Michael Garthwaite