This is a list of all comments for UI-DEN-17157-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/components/SliderCreateTreatment.qml
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:29 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21565

  Make it like GridSelection.qml @ L54.

  Reply by Dara Navaei on 25 February 2025, 15:29
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:43
    > RESOLVED

Revision Comment by Behrouz NematiPour on 25 February 2025, 14:30 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21566

  same here

  Reply by Dara Navaei on 25 February 2025, 15:29
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:43
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/pretreatment/connection/PreTreatmentUltrafiltration.qml
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:32 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21567

  Please put a comment here for next developer to avoid
  confusion:
  /*
    It is only for the dry-demo due to its independent flow.
    Otherwise, won't needed in the normal designed user-flow.
  */

  Reply by Dara Navaei on 25 February 2025, 15:28
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:43
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:36 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21568

  please define these numbers (on other lines as well) as a:
  readonly property <type of the value> <name of the propery>
  example:
  on top:
  {code}readonly property int bloodFlowRateDef : 400{code}
  replace with:
  {code}defaultValue: _GuiView.dryDemoMode ?
  _root.bloodFlowRateDef :
  vTreatmentRanges.bloodFlowRateDef{code}

  Reply by Dara Navaei on 25 February 2025, 15:21
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 16:23
    > RESOLVED

----------------------------------------
File: sources/gui/qml/main.qml
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:46 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21573

  I believe you should correct the other z-orders.

  Reply by Dara Navaei on 25 February 2025, 15:01
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:42
    > RESOLVED

----------------------------------------
File: sources/view/confirm/VConfirm.cpp
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:47 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21574

  please remove extra space before DRY_...

  Reply by Dara Navaei on 25 February 2025, 14:58
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:41
    > RESOLVED

----------------------------------------
File: sources/view/confirm/VConfirm.h
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:48 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21575

  please align arguments.

  Reply by Dara Navaei on 25 February 2025, 14:57
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:40
    > RESOLVED

----------------------------------------
File: main.cpp
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:49 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21576

  please add //DEBUG: to comment this out.

  Reply by Dara Navaei on 25 February 2025, 14:54
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 15:40
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/treatment/sections/TreatmentVitals.qml
Revision Comment by Behrouz NematiPour on 25 February 2025, 14:40 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21569

  please align the " ,2"

  Reply by Dara Navaei on 25 February 2025, 15:27
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 16:16
    > RESOLVED

Revision Comment by Behrouz NematiPour on 25 February 2025, 14:42 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21570

  please do the same as the comment in the following link:
  http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

  Reply by Dara Navaei on 25 February 2025, 15:26
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 16:17
    > RESOLVED

Revision Comment by Behrouz NematiPour on 25 February 2025, 14:44 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21571

  is there a specific reason the notSetVariable function is not
  used and replaced with "__"?

  Reply by Dara Navaei on 25 February 2025, 15:27
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 16:17
    > RESOLVED
    > 
    > It is fine for now that the following not fixed:
    > 1 - the properties still have dryDemo as prefix.

Revision Comment by Behrouz NematiPour on 25 February 2025, 14:44 
https://devapps.diality.us/cru/UI-DEN-17157-1#c21572

  - same here as above.
   - same here as above.

  Reply by Dara Navaei on 25 February 2025, 15:27
  > Done

    Reply by Behrouz NematiPour on 25 February 2025, 16:18
    > RESOLVED
    > 
    > It is fine for now that the following not fixed:
    > 1 - the
    > {code}Variables.notSetVariable(vTreatmentVitals.systolic,
    > 2){code} is not used here.
    > 2 - the properties still have dryDemo as prefix.


---

ID: UI-DEN-17157-1 https://devapps.diality.us/cru/UI-DEN-17157-1

Title: UI-DEN-17157_Update Denali Application For Dry Demo
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Tiffany Mejia   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     jpaguio
     Michael Garthwaite
     amanesh