This is a list of all comments for UI-DEN-2086-1.

Review Summary: No summary


----------------------------------------
File: sources/applicationcontroller.cpp
Revision Comment by plucia on 02 March 2020, 15:27 
https://devapps.diality.us/cru/UI-DEN-2086-1#c1352

  Just as a suggestion, for future it would be helpful to replace
  the magic numbers with descriptive variables to improve
  readability here. Will it need to change to support both
  Standard and Extended CAN?

  Reply by Behrouz NematiPour on 02 March 2020, 15:36
  > For the first one, sure
  > For the second, We are not going to support extended CAN. At
  > least we don't have any plan and if we want to do it, it
  > needs the architecture (SWA,SDD,...) to be modified.

    Reply by plucia on 02 March 2020, 15:54
    > RESOLVED

----------------------------------------
File: sources/canbus/caninterface.cpp
Revision Comment by pmontazemi on 06 March 2020, 09:58 
https://devapps.diality.us/cru/UI-DEN-2086-1#c1359

  Remove extra line.

  Reply by Behrouz NematiPour on 10 March 2020, 01:12
  > Has been removed in the current working branch fro the
  > Treatment last implementation.

    Reply by pmontazemi on 10 March 2020, 17:03
    > RESOLVED.

Revision Comment by pmontazemi on 06 March 2020, 09:59 
https://devapps.diality.us/cru/UI-DEN-2086-1#c1360

  Remove extra line.

  Reply by Behrouz NematiPour on 10 March 2020, 01:11
  > Has been removed in the current working branch fro the
  > Treatment last implementation.

    Reply by pmontazemi on 10 March 2020, 17:03
    > RESOLVED.

----------------------------------------
File: sources/canbus/messageglobals.h
Revision Comment by plucia on 02 March 2020, 15:15 
https://devapps.diality.us/cru/UI-DEN-2086-1#c1349

  Should these be equal?

  Reply by Behrouz NematiPour on 02 March 2020, 15:21
  > Yes,
  > I used channel Id 0 as none, but since it has a highest
  > priority it's not good to have the highest priority channel
  > id for something kind of unknown, so I changed it to the
  > lowest.
  > Also the Lowest is used for keepAwake message.
  > And both have the same value.

    Reply by plucia on 02 March 2020, 15:30
    > Okay, makes sense, RESOLVED

----------------------------------------
File: sources/utility/format.cpp
Revision Comment by plucia on 02 March 2020, 15:20 
https://devapps.diality.us/cru/UI-DEN-2086-1#c1350

  Maybe need a check if (vData.type() == QVariant::Int) here
  before incrementing mData?

  Reply by Behrouz NematiPour on 02 March 2020, 15:44
  > uint QVariant::toUInt(bool *ok = nullptr) const
  > Returns the variant as an unsigned int if the variant has
  > userType() QMetaType::UInt, QMetaType::Bool,
  > QMetaType::QByteArray, QMetaType::QChar, QMetaType::Double,
  > QMetaType::Int, QMetaType::LongLong, QMetaType::QString, or
  > QMetaType::ULongLong; otherwise returns 0.
  > 
  > 0 is fine with me.

    Reply by plucia on 02 March 2020, 15:54
    > RESOLVED


---

ID: UI-DEN-2086-1 https://devapps.diality.us/cru/UI-DEN-2086-1

Title: DEN-UI-2086_Denali Communications
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)