This is a list of all comments for UI-DEN-3024-1. Review Summary: No summary ---------------------------------------- File: sources/gui/guiglobals.h Revision Comment by pmontazemi on 06 May 2020, 09:12 https://devapps.diality.us/cru/UI-DEN-3024-1#c1795 referenced Reply by Behrouz NematiPour on 07 May 2020, 03:57 > done Reply by pmontazemi on 07 May 2020, 09:41 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:12 https://devapps.diality.us/cru/UI-DEN-3024-1#c1796 Remove personal opinion (entire line) Reply by Behrouz NematiPour on 07 May 2020, 03:59 > done Reply by pmontazemi on 07 May 2020, 09:41 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:13 https://devapps.diality.us/cru/UI-DEN-3024-1#c1797 It is preferred to keep them as constant values Reply by Behrouz NematiPour on 07 May 2020, 03:57 > done Reply by pmontazemi on 07 May 2020, 09:40 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:13 https://devapps.diality.us/cru/UI-DEN-3024-1#c1798 going Reply by Behrouz NematiPour on 07 May 2020, 03:57 > done Reply by pmontazemi on 07 May 2020, 09:40 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:13 https://devapps.diality.us/cru/UI-DEN-3024-1#c1799 Remove last sentence entirely, that is a given. Reply by Behrouz NematiPour on 07 May 2020, 03:57 > done Reply by pmontazemi on 07 May 2020, 09:26 > RESOLVED. ---------------------------------------- File: sources/gui/guiview.cpp Revision Comment by pmontazemi on 06 May 2020, 09:14 https://devapps.diality.us/cru/UI-DEN-3024-1#c1800 remove // process ... Reply by Behrouz NematiPour on 07 May 2020, 04:00 > done Reply by pmontazemi on 07 May 2020, 09:42 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:15 https://devapps.diality.us/cru/UI-DEN-3024-1#c1801 thoroughly also, how many of these do we have? and, what later investigation is needed? Reply by Behrouz NematiPour on 07 May 2020, 02:51 > These are the codes before MVC implementation and Application > was using QVariantList. > Some of these needs to be removed but needs to be carefully > tested(investigated) and removed. Reply by pmontazemi on 07 May 2020, 09:27 > Dara will instrument the Bamboo build across all software > code bases to check for all manual code coverage comments > and create a summary of it. Then, to be able to pass > through the Phase II gate of our R&D development process, > we will all review one by one each of these exceptions in a > phase gate review meeting and make sure they don't need > further testing before doing the official release > candidate. Reply by pmontazemi on 07 May 2020, 09:28 > RESOLVED. ---------------------------------------- File: sources/gui/qml/main.qml Revision Comment by pmontazemi on 06 May 2020, 09:10 https://devapps.diality.us/cru/UI-DEN-3024-1#c1794 Remove extra line. Reply by Behrouz NematiPour on 07 May 2020, 02:46 > This is the extra line after each break. Reply by pmontazemi on 07 May 2020, 09:39 > RESOLVED. ---------------------------------------- File: sources/model/mmodel.h Revision Comment by plucia on 06 May 2020, 11:20 https://devapps.diality.us/cru/UI-DEN-3024-1#c1816 What is the advantage of using macros to define the signals and slots? Reply by Behrouz NematiPour on 06 May 2020, 11:25 > 1 - It makes the usage of the code, standard like Q_OBJECT > and no other way of definition should be used. > 2 - It makes the code consistent. > 3 - Automatically handles the part of the code which is a > copy/paste for just connecting signal/slots. > Ans soon ... Reply by plucia on 06 May 2020, 13:19 > RESOLVED ---------------------------------------- File: sources/model/mtreatmentadjustblooddialysateresponse.cpp Revision Comment by pmontazemi on 06 May 2020, 09:17 https://devapps.diality.us/cru/UI-DEN-3024-1#c1802 So hard to read, camel? Reply by Behrouz NematiPour on 06 May 2020, 11:29 > That's the exact file name which has been copied here as we > are using lowercase file names. Reply by pmontazemi on 07 May 2020, 09:29 > It is too late to change this. Please make sure this naming > convention is consistent with our C++ Coding Standard. Reply by pmontazemi on 07 May 2020, 09:30 > RESOLVED. ---------------------------------------- File: sources/utility/format.cpp Revision Comment by pmontazemi on 06 May 2020, 09:17 https://devapps.diality.us/cru/UI-DEN-3024-1#c1803 returns Reply by Behrouz NematiPour on 07 May 2020, 03:57 > done Reply by pmontazemi on 07 May 2020, 09:31 > RESOLVED. ---------------------------------------- File: sources/main.h Revision Comment by pmontazemi on 06 May 2020, 09:19 https://devapps.diality.us/cru/UI-DEN-3024-1#c1804 What are the ## signs for? Reply by Behrouz NematiPour on 07 May 2020, 02:58 > Two pound signs ## are for concatenation in #define. Reply by pmontazemi on 07 May 2020, 09:33 > RESOLVED. ---------------------------------------- File: sources/view/valarmstatus.h Revision Comment by pmontazemi on 06 May 2020, 09:28 https://devapps.diality.us/cru/UI-DEN-3024-1#c1811 insert line Reply by Behrouz NematiPour on 07 May 2020, 02:55 > Sorry don't understand. > If it means extra empty line, all the copyright sections in > the files are just before #pragma once with no extra empty > line since the first comment block will be folded in one line > by QtCreator and it's nice to have #pragma once as much as > possible at the top of the file. Reply by pmontazemi on 07 May 2020, 09:31 > Never mind then. Reply by pmontazemi on 07 May 2020, 09:32 > RESOLVED. ---------------------------------------- File: unittests/tst_acknow.cpp Revision Comment by pmontazemi on 06 May 2020, 09:20 https://devapps.diality.us/cru/UI-DEN-3024-1#c1805 Why is the copyright format different than the standard format? Why hasn't the Bamboo server picked that up and corrected it? Reply by Behrouz NematiPour on 07 May 2020, 02:59 > I don't know what is the standard format. > The wording should be exactly the same it's just spacing in > the code. Reply by pmontazemi on 07 May 2020, 09:33 > OK, we covered this with Dara. Reply by pmontazemi on 07 May 2020, 09:33 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:23 https://devapps.diality.us/cru/UI-DEN-3024-1#c1806 which is not expected (remove all me you us them from all headers and comments) Reply by Behrouz NematiPour on 07 May 2020, 03:56 > done. Reply by pmontazemi on 07 May 2020, 09:42 > RESOLVED. Revision Comment by pmontazemi on 06 May 2020, 09:23 https://devapps.diality.us/cru/UI-DEN-3024-1#c1807 exist Reply by Behrouz NematiPour on 07 May 2020, 03:56 > done Reply by pmontazemi on 07 May 2020, 09:42 > RESOLVED. ---------------------------------------- File: unittests/tst_acknow.h Revision Comment by pmontazemi on 06 May 2020, 09:24 https://devapps.diality.us/cru/UI-DEN-3024-1#c1808 Remove extra line Reply by Behrouz NematiPour on 07 May 2020, 03:55 > done Reply by pmontazemi on 07 May 2020, 09:33 > RESOLVED. ---------------------------------------- File: unittests/tst_messaging.cpp Revision Comment by pmontazemi on 06 May 2020, 09:25 https://devapps.diality.us/cru/UI-DEN-3024-1#c1809 Where are the descriptive headers for all these functions in this file? Reply by Behrouz NematiPour on 07 May 2020, 03:54 > All methods comments added. Reply by pmontazemi on 07 May 2020, 09:37 > RESOLVED. ---------------------------------------- File: unittests/tst_messaging.h Revision Comment by pmontazemi on 06 May 2020, 09:26 https://devapps.diality.us/cru/UI-DEN-3024-1#c1810 remove extra line Reply by Behrouz NematiPour on 07 May 2020, 03:55 > Done Reply by pmontazemi on 07 May 2020, 09:38 > RESOLVED. --- ID: UI-DEN-3024-1 https://devapps.diality.us/cru/UI-DEN-3024-1 Title: UI-DEN-3024_TreatmentDurationAdjustment Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)