This is a list of all comments for UI-DEN-4598-1. Review Summary: No summary General Comment by Behrouz NematiPour on 29 October 2020, 13:27 https://devapps.diality.us/cru/UI-DEN-4598-1#c5760 After the Doxygeization effort, all the classes shall have the documentation with messaging information. Please add to all your classes. For example on how to do please refer to the Model/View classes. And when doc generated it will also be used for SDD. it should contain: - \brief - \details - Message information - Message Payload information as each field in a line (see example below) - \sa(see also) which has related classes to this class - Logging info which at least has 3 lines (see example below and follow the HTML syntax for formating in doxygen please.) An example provided. please look at more examples for your specific case in the code on the master branch. {code} /*! * \brief The MAdjustSalineResponse class * \details The Saline Bolus adjustment response model * * | MSG | CAN ID | M.Box | Type | Ack | Src | Dest | Description | * |:----:|:------:|:-----:|:----:|:---:|:---:|:----:|:---------------------:| * |0x1400| 0x020 | 6 | Rsp | Y | HD | UI | Saline Bolus Response | * * | Payload || * | || * | #1:(U32) | \ref Data::mAccepted | * | #2:(U32) | \ref Data::mReason | * | #3:(U32) | \ref Data::mTarget | * * \sa Data * \sa MAdjustSalineReq : Saline Bolus Request * \sa MTreatmentSaline : Saline Bolus Data * *

Logging info

* | || * | || * | typeText | Event | * | unitText | HD | * | infoText | AdjustSaline | * */ {code} Reply by plucia on 03 November 2020, 18:10 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:56 > RESOLVED General Comment by Behrouz NematiPour on 29 October 2020, 23:59 https://devapps.diality.us/cru/UI-DEN-4598-1#c5776 After I checked out into your feature branch I found out the filesaver(.h,.cpp) name is not PascalCase. Please change the filesaver to FileSaver. Reply by plucia on 30 October 2020, 13:46 > Done Reply by Behrouz NematiPour on 03 November 2020, 19:13 > RESOLVED General Comment by Behrouz NematiPour on 01 November 2020, 17:08 https://devapps.diality.us/cru/UI-DEN-4598-1#c5826 As a general note Please try not to create a component for every single use case. I'm also started to remove some of the currently defined unnecessary components to keep them more organized. Reply by plucia on 03 November 2020, 11:26 > Sure, makes sense. I removed the ProgressLine component and > will keep that in mind going forward before adding any new > components Reply by Behrouz NematiPour on 03 November 2020, 19:14 > RESOLVED General Comment by Behrouz NematiPour on 09 November 2020, 11:57 https://devapps.diality.us/cru/UI-DEN-4598-1#c5960 In general please try to use less components. Components should be more general and not specific to a screen. If that is the case think of it as a big(which I call it compound) component and put it in the compounds folder(which I recently created). Please note that either way we still should create less components/compounds. Reply by plucia on 10 November 2020, 09:44 > I've noted this and will make sure to resolve it later > > http://dvm-linux02:8080/browse/DEN-5642 Reply by Behrouz NematiPour on 10 November 2020, 16:42 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 General Comment by Behrouz NematiPour on 09 November 2020, 12:49 https://devapps.diality.us/cru/UI-DEN-4598-1#c5967 I put some comments as notes which don't require to be fixed in this code review but it is expected to be noted and resolved in later on going stories. So please take notes and consider applying them to any recent story/task. Reply by plucia on 10 November 2020, 09:47 > Okay thank you. I've made a list and will make sure they are > resolved later Reply by Behrouz NematiPour on 10 November 2020, 16:36 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentStack.qml Revision Comment by Behrouz NematiPour on 09 November 2020, 12:23 https://devapps.diality.us/cru/UI-DEN-4598-1#c5964 Be careful of using this. When you push and pop in order it's fine but when pop to an item randomly it's not safe. If the object is not currently in the stack you may get an error and I don't know what is going to happen to the Application !!! preferably don't use this, it's a stack and has to be pushed and popped in order. Reply by plucia on 10 November 2020, 09:52 > The reason this has been added is somewhat complicated to > explain. But one of the reasons is so the next time we enter > pre-treatment the top page is the create treatment page and > not the treatment begin page. I've made a note to follow up > on this Reply by Behrouz NematiPour on 10 November 2020, 16:39 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 ---------------------------------------- File: sources/view/VTreatmentCreate.h Revision Comment by Behrouz NematiPour on 01 November 2020, 16:39 https://devapps.diality.us/cru/UI-DEN-4598-1#c5818 Please define these magic numbers somewhere and use them here then. As example : {code} //// PRS/SRS defined values const quint32 bloodFlowRate_def = 100; // SRS nnnn : manufacturing default const quint32 bloodFlowRate_min = 100; // SRS nnnn const quint32 bloodFlowRate_max = 100; // SRS nnnn const quint32 bloodFlowRate_res = 100; // SRS nnnn : resolution .... {code} Reply by plucia on 03 November 2020, 14:40 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:28 > RESOLVED Revision Comment by Behrouz NematiPour on 01 November 2020, 16:34 https://devapps.diality.us/cru/UI-DEN-4598-1#c5816 Please use the enums for these values. If has not been defined, please define a max or count enum item and then use it here. As an example : {code} enum ACID_ENUM { eAcid01 = 0, eAcid02 , eAcid03 , eAcid04 , eAcid_count }; {code} then use eAcid_count in this case. Reply by plucia on 03 November 2020, 14:40 > Done. I don't think there is a use for a count right now? Let > me know if you still want a count Reply by Behrouz NematiPour on 09 November 2020, 10:28 > RESOLVED Revision Comment by Behrouz NematiPour on 01 November 2020, 16:38 https://devapps.diality.us/cru/UI-DEN-4598-1#c5817 Please define these magic numbers somewhere and use them here then. Reply by plucia on 03 November 2020, 14:45 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:28 > RESOLVED ---------------------------------------- File: sources/gui/GuiGlobals.h Revision Comment by Behrouz NematiPour on 09 November 2020, 12:28 https://devapps.diality.us/cru/UI-DEN-4598-1#c5966 Later please use Treatment first and then the command. Like ID_TreatmentEnd, ID_TreatmentStart, ... Reply by plucia on 10 November 2020, 09:45 > I've noted this and will make sure to resolve it later Reply by Behrouz NematiPour on 10 November 2020, 16:40 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 ---------------------------------------- File: sources/model/hd/adjustment/MTreatmentAdjustRequests.h Revision Comment by Behrouz NematiPour on 30 October 2020, 00:08 https://devapps.diality.us/cru/UI-DEN-4598-1#c5777 Please correct the order of the fields regarding the message like what is done for the response message. There are three different types and it's hard to follow. Reply by plucia on 03 November 2020, 17:56 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:42 > RESOLVED ---------------------------------------- File: ConfirmTreatmentTableEntry.qml Revision Comment by Behrouz NematiPour on 01 November 2020, 17:06 https://devapps.diality.us/cru/UI-DEN-4598-1#c5825 Please document why this file is created. And Please move it to its appropriate folder "./sources/gui/qml/components". Reply by plucia on 02 November 2020, 16:02 > Done, it is now in the correct folder and the description > with its purpose has been added. Reply by Behrouz NematiPour on 09 November 2020, 10:22 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentBegin.qml Revision Comment by Behrouz NematiPour on 09 November 2020, 12:18 https://devapps.diality.us/cru/UI-DEN-4598-1#c5962 shouldn't be _treatmentBegin(Button/StartButton/TouchRect/Rect). Reply by plucia on 10 November 2020, 09:44 > I've noted this and will make sure to resolve it later Reply by Behrouz NematiPour on 10 November 2020, 16:40 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentCreate.qml Revision Comment by Behrouz NematiPour on 09 November 2020, 12:21 https://devapps.diality.us/cru/UI-DEN-4598-1#c5963 http://dvm-linux02:8060/cru/UI-DEN-4598-1#c5961 Reply by plucia on 10 November 2020, 09:44 > I've noted this and will make sure to resolve it later Reply by Behrouz NematiPour on 10 November 2020, 16:38 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/Slider.qml Revision Comment by Behrouz NematiPour on 01 November 2020, 14:07 https://devapps.diality.us/cru/UI-DEN-4598-1#c5812 Please use "handler" instead of "knob" to be consistent with the rest of the code. And also please move it next to "handler" on line 38. Reply by plucia on 04 November 2020, 10:27 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:39 > RESOLVED ---------------------------------------- File: sources/gui/GuiController.cpp Revision Comment by Behrouz NematiPour on 09 November 2020, 12:27 https://devapps.diality.us/cru/UI-DEN-4598-1#c5965 This is part of a merge conflict resolution. Please correct it. Reply by plucia on 10 November 2020, 09:24 > Done Reply by Behrouz NematiPour on 10 November 2020, 16:36 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentConfirm.qml Revision Comment by Behrouz NematiPour on 09 November 2020, 12:15 https://devapps.diality.us/cru/UI-DEN-4598-1#c5961 Please be consistent with the other screens objectName. In terms of using '_' underscore an also camelCase and using "Treatment" word location in the name. This should be _treatmentCreateFlickable regarding your previous usage in TreatmentBegin.qml. Reply by plucia on 10 November 2020, 09:25 > Done Reply by Behrouz NematiPour on 10 November 2020, 16:46 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 ---------------------------------------- File: sources/model/MTreatmentParametersResp.h Revision Comment by Behrouz NematiPour on 03 November 2020, 18:43 https://devapps.diality.us/cru/UI-DEN-4598-1#c5894 Please use the value 0x3500 instead of 53 decimal. I'm also updating all to be the hex values. Although the "message list" has decimal values this is the exact value we can trace in the "candump" output and helps a lot while debugging. Reply by plucia on 04 November 2020, 10:12 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:13 > RESOLVED Revision Comment by Behrouz NematiPour on 03 November 2020, 18:42 https://devapps.diality.us/cru/UI-DEN-4598-1#c5893 Please put Data:: scope resolution like the first one otherwise in Doxygen link is broken. Reply by plucia on 04 November 2020, 10:13 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:15 > RESOLVED Revision Comment by Behrouz NematiPour on 29 October 2020, 18:40 https://devapps.diality.us/cru/UI-DEN-4598-1#c5775 Please update this information for this class. Reply by plucia on 03 November 2020, 17:53 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:44 > RESOLVED Revision Comment by Behrouz NematiPour on 03 November 2020, 18:41 https://devapps.diality.us/cru/UI-DEN-4598-1#c5892 Should be "event" only broadcasts are "datum" Reply by plucia on 04 November 2020, 10:14 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:14 > RESOLVED ---------------------------------------- File: sources/view/hd/alarm/VAlarmStatus.h Revision Comment by pmontazemi on 29 October 2020, 14:23 https://devapps.diality.us/cru/UI-DEN-4598-1#c5773 Remove extra lines. Reply by plucia on 03 November 2020, 16:20 > Done Reply by pmontazemi on 04 November 2020, 09:10 > RESOLVED. ---------------------------------------- File: sources/storage/storageglobals.cpp Revision Comment by Behrouz NematiPour on 01 November 2020, 15:18 https://devapps.diality.us/cru/UI-DEN-4598-1#c5813 what is the difference between these two? namings show the variable "Treatment_Parameter_Ranges_Path" should be "/media/sd-card/treatment/" and not "/media/sd-card/treatment/denali.conf" and "denali.conf" needs to be removed, right? Reply by plucia on 04 November 2020, 10:38 > denali.conf is currently used and if it exists, the treatment > parameters are read directly into a QJsonObject on startup > denali.csv is currently unused and so I've just deleted it > for now (See > http://dvm-linux02:8060/cru/UI-DEN-4598-1#CFR-19459) Reply by Behrouz NematiPour on 09 November 2020, 10:35 > RESOLVED Revision Comment by Behrouz NematiPour on 01 November 2020, 15:20 https://devapps.diality.us/cru/UI-DEN-4598-1#c5814 if this variable keeps the name of the file which has the manufacturing default settings, I think the naming should be more descriptive. Reply by plucia on 04 November 2020, 11:03 > It was actually unused, so I've just deleted it for now (See > http://dvm-linux02:8060/cru/UI-DEN-4598-1#CFR-19459) Reply by Behrouz NematiPour on 09 November 2020, 10:36 > RESOLVED ---------------------------------------- File: sources/applicationcontroller.cpp Revision Comment by Behrouz NematiPour on 30 October 2020, 18:55 https://devapps.diality.us/cru/UI-DEN-4598-1#c5811 I checked out into the branch and {code} using namespace Storage; {code} is still there. I couldn't find any use case if that's so please remove. Reply by plucia on 03 November 2020, 11:12 > It has been removed: > http://dvm-linux02:8060/cru/UI-DEN-4598-1#CFR-19816 Reply by Behrouz NematiPour on 09 November 2020, 10:37 > RESOLVED Revision Comment by plucia on 30 October 2020, 13:10 https://devapps.diality.us/cru/UI-DEN-4598-1#c5803 I don't think these should be here. I'm going to look at removing them Reply by plucia on 30 October 2020, 13:30 > Ah Crucible fooled me. This file has been removed. I checked > and ApplicationController.cpp/h doesn't have the QJsonObject > and QJsonDocument imports on the ConfirmPrimingBegin branch. > The Storage namespace is used for SD Card related functions > in this file. Reply by plucia on 10 November 2020, 17:20 > RESOLVED ---------------------------------------- File: sources/applicationcontroller.h Revision Comment by Behrouz NematiPour on 30 October 2020, 18:52 https://devapps.diality.us/cru/UI-DEN-4598-1#c5810 Please remove this function definition there is no implementation in the cpp file. Reply by plucia on 03 November 2020, 11:13 > It has been removed: > http://dvm-linux02:8060/cru/UI-DEN-4598-1#CFR-19817 Reply by Behrouz NematiPour on 09 November 2020, 10:41 > RESOLVED ---------------------------------------- File: ProgressLine.qml Revision Comment by Behrouz NematiPour on 01 November 2020, 17:03 https://devapps.diality.us/cru/UI-DEN-4598-1#c5824 Please document why this file is created. And Please move it to its appropriate folder "./sources/gui/qml/components". And also this component seems unnecessary since it's so small and looks like being used only for one purpose, so please move it in the main component it has been used for. Reply by plucia on 02 November 2020, 15:49 > Done > It is removed now Reply by Behrouz NematiPour on 09 November 2020, 10:23 > RESOLVED ---------------------------------------- File: sources/model/MEndTreatmentResponse.cpp Revision Comment by Behrouz NematiPour on 29 October 2020, 13:02 https://devapps.diality.us/cru/UI-DEN-4598-1#c5759 Please rename the file to MTreatmentEndResponse Reply by Behrouz NematiPour on 10 November 2020, 17:21 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 ---------------------------------------- File: sources/model/MEndTreatmentResponse.h Revision Comment by Behrouz NematiPour on 09 November 2020, 11:55 https://devapps.diality.us/cru/UI-DEN-4598-1#c5958 Later please change the class name to MTreatmentEndResponse (Treatment after M and End After Treatment). Reply by Behrouz NematiPour on 10 November 2020, 17:12 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 Revision Comment by pmontazemi on 29 October 2020, 14:18 https://devapps.diality.us/cru/UI-DEN-4598-1#c5769 Remove extra space. Reply by plucia on 03 November 2020, 16:20 > Done Reply by pmontazemi on 04 November 2020, 09:04 > RESOLVED. ---------------------------------------- File: sources/model/MStartTreatmentResponse.h Revision Comment by Behrouz NematiPour on 09 November 2020, 11:55 https://devapps.diality.us/cru/UI-DEN-4598-1#c5959 Later please change the class name to MTreatmentStartResponse (Treatment after M and Start After Treatment). Reply by Behrouz NematiPour on 10 November 2020, 17:10 > RESOLVED > http://dvm-linux02:8080/browse/DEN-5642 Revision Comment by pmontazemi on 29 October 2020, 14:18 https://devapps.diality.us/cru/UI-DEN-4598-1#c5770 Remove extra space. Reply by plucia on 03 November 2020, 16:20 > Done Reply by pmontazemi on 04 November 2020, 09:10 > RESOLVED. ---------------------------------------- File: sources/model/hd/data/MPrimingData.h Revision Comment by Behrouz NematiPour on 03 November 2020, 18:47 https://devapps.diality.us/cru/UI-DEN-4598-1#c5895 Please put the message document for this class as well and all the other model classes. Reply by plucia on 04 November 2020, 10:09 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:13 > RESOLVED Revision Comment by Behrouz NematiPour on 03 November 2020, 18:48 https://devapps.diality.us/cru/UI-DEN-4598-1#c5896 Please align. Reply by plucia on 04 November 2020, 10:09 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:11 > RESOLVED Revision Comment by pmontazemi on 29 October 2020, 14:17 https://devapps.diality.us/cru/UI-DEN-4598-1#c5768 Remove extra space. Reply by plucia on 03 November 2020, 16:41 > Done Reply by pmontazemi on 04 November 2020, 09:05 > RESOLVED. ---------------------------------------- File: sources/model/mtreatmentparameters.h Revision Comment by Behrouz NematiPour on 01 November 2020, 15:24 https://devapps.diality.us/cru/UI-DEN-4598-1#c5815 If this class is the Treatment Parameters Request, please refactor the class and file names to TreatmentParametersRequest to be more clear since this is the first class which has its own separate request class. Reply by plucia on 03 November 2020, 14:51 > This file was subsequently renamed to MTreatmentParameters.h > and then was removed when I subclasses MModel in > MTreatmentAdjustRequests.h to create the > MAdjustTreatmentParametersReq class. Do you want me to rename > MAdjustTreatmentParametersReq to MTreatmentParametersRequest? Reply by Behrouz NematiPour on 09 November 2020, 10:32 > RESOLVED Revision Comment by pmontazemi on 29 October 2020, 14:19 https://devapps.diality.us/cru/UI-DEN-4598-1#c5771 Remove extra line. Reply by plucia on 03 November 2020, 16:19 > This file has been deleted Reply by pmontazemi on 04 November 2020, 09:04 > RESOLVED. ---------------------------------------- File: tst_ConfirmPrimingBegin/test.py Revision Comment by Behrouz NematiPour on 01 November 2020, 16:53 https://devapps.diality.us/cru/UI-DEN-4598-1#c5822 These are all the same how come they have different comments? Reply by plucia on 02 November 2020, 16:25 > Each reject reason (or none if no rejection) corresponds to a > treatment parameter. > Since there was no need to duplicate the lines for each > parameter, I've now updated it so they are generated using > list comprehension instead. > Also I added the docstrings that were missing. Reply by Behrouz NematiPour on 03 November 2020, 19:07 > RESOLVED Revision Comment by Behrouz NematiPour on 09 November 2020, 11:16 https://devapps.diality.us/cru/UI-DEN-4598-1#c5956 Please remove sleeps as much as possible. Only keep if it's related to the UI navigation animation. in that case also please use utils.waitForGUI(). Reply by plucia on 09 November 2020, 18:03 > Done Reply by Behrouz NematiPour on 10 November 2020, 16:38 > RESOLVED ---------------------------------------- File: tst_Alarm_Colors/test.py Revision Comment by Behrouz NematiPour on 01 November 2020, 16:45 https://devapps.diality.us/cru/UI-DEN-4598-1#c5819 Could you please explain why added delays? It was/is working without delay. The preferred way is not to slow down the test to have a successful test. I recall we had this conversation. Please remove the sleep functions. Reply by plucia on 03 November 2020, 11:03 > waitForObjectExists wasn't using the timeout of 200 ms set in > config.xml. > I've updated the test use waitForObject which waits until the > component is visible before clicking, so the delays are not > needed and are now removed Reply by Behrouz NematiPour on 09 November 2020, 10:26 > RESOLVED ---------------------------------------- File: tst_Treatment_Adjustment_BloodDialysate/test.py Revision Comment by Behrouz NematiPour on 01 November 2020, 16:51 https://devapps.diality.us/cru/UI-DEN-4598-1#c5821 Why it has been changed? Reply by plucia on 02 November 2020, 17:13 > Reverted now, sorry about that. > > When I added left and right margins to the mouse area in > RangeRect to make it easier to select the knob from the left > of a slider or the right of the slider when the knob was at > its minimum or maximum position, the unintended consequence > is that there is sometimes an offset between the click point > and the knob position, requiring small adjustment to tests > using sliders. > I've removed that change to RangeRect now and reverted the > values here back to 190. I think a better solution would be > needed if we still want to expand the left and right mouse > area touch margins of the slider. Reply by Behrouz NematiPour on 03 November 2020, 19:05 > RESOLVED Revision Comment by Behrouz NematiPour on 01 November 2020, 16:51 https://devapps.diality.us/cru/UI-DEN-4598-1#c5820 Why it has been changed? Reply by plucia on 02 November 2020, 17:21 > Reverted back now > (See above) Reply by Behrouz NematiPour on 03 November 2020, 19:05 > RESOLVED ---------------------------------------- File: tools/run_server.sh Revision Comment by Behrouz NematiPour on 01 November 2020, 16:56 https://devapps.diality.us/cru/UI-DEN-4598-1#c5823 Thanks for this effort. If this and the other scripts are the implementations regarding the "SquishQt headless server" in the following link https://kb.froglogic.com/squish/howto/using-squish-headless-systems/ Please work with [~dnavaei] to implement this on the server as well regarding the conversation Dara and I had a while ago and he is already aware of it. Reply by plucia on 02 November 2020, 15:53 > Yes, this is to be able to run the squishqt tests in a > headless mode. > Sounds good, I will work with Dara to get this on the server > as well. Reply by Behrouz NematiPour on 03 November 2020, 19:10 > RESOLVED ---------------------------------------- File: sources/canbus/MessageInterpreter.h Revision Comment by Behrouz NematiPour on 03 November 2020, 19:20 https://devapps.diality.us/cru/UI-DEN-4598-1#c5904 please remove this. As explained tests should not be in the tst_canbus and should be in tst_models. Reply by plucia on 04 November 2020, 10:22 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:11 > RESOLVED ---------------------------------------- File: unittests/tst_canbus.h Revision Comment by Behrouz NematiPour on 03 November 2020, 18:50 https://devapps.diality.us/cru/UI-DEN-4598-1#c5897 Please move this test into the tst_models. Generally, we should never have any more tests in the tst_canbus, tst_threads, tst_messaging, tst_logging and so. Those are specific to the very fundamental functionalities of the UI Software. Also then remove the {code} friend tst_canbus {code} from the classes which has been tested here. Reply by plucia on 04 November 2020, 10:22 > Done Reply by Behrouz NematiPour on 09 November 2020, 10:11 > RESOLVED ---------------------------------------- File: sources/view/VTreatmentBegin.h Revision Comment by pmontazemi on 02 November 2020, 11:36 https://devapps.diality.us/cru/UI-DEN-4598-1#c5863 Just one space between parameters. Reply by plucia on 02 November 2020, 15:48 > Done Reply by pmontazemi on 04 November 2020, 08:59 > RESOLVED. --- ID: UI-DEN-4598-1 https://devapps.diality.us/cru/UI-DEN-4598-1 Title: UI-DEN-4598_Confirm Priming Begin Statement of Objectives: State: Closed Summary: Author: plucia Reviewers: (0 active, 2 completed*) Behrouz NematiPour (*) pmontazemi (*)