This is a list of all comments for UI-DEN-4690-1. Review Summary: No summary General Comment by plucia on 30 September 2020, 11:17 https://devapps.diality.us/cru/UI-DEN-4690-1#c4987 This review has so many files and is quite monumental. It would be much easier to review if there were fewer changes. What are the list of features that are covered in this review? It seems like it's not just doxygenization Reply by Behrouz NematiPour on 07 October 2020, 22:12 > It is all documentations and Doxygenization. > If you see otherwise is because the file names changed and > the code review takes it as a new file and marks all the file > content as to be reviewed. > Let me know if otherwise. Reply by plucia on 14 October 2020, 10:40 > RESOLVED. ---------------------------------------- File: sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationEdit.h Revision Comment by pmontazemi on 08 September 2020, 09:49 https://devapps.diality.us/cru/UI-DEN-4690-1#c4415 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:05 > Removed. Reply by pmontazemi on 08 September 2020, 11:14 > RESOLVED. ---------------------------------------- File: sources/utility/types.cpp Revision Comment by pmontazemi on 08 September 2020, 13:24 https://devapps.diality.us/cru/UI-DEN-4690-1#c4486 Function description? Reply by Behrouz NematiPour on 08 September 2020, 18:09 > This has not been removed and is in my code currently. > Not sure why shows as removed! > Something is completely off with Crucible !!! > I'm investigating it. > My git log shows it has been added in commit hash bb74da. Reply by pmontazemi on 09 September 2020, 14:35 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:24 https://devapps.diality.us/cru/UI-DEN-4690-1#c4487 Function description? Reply by Behrouz NematiPour on 08 September 2020, 18:13 > Same here Reply by pmontazemi on 09 September 2020, 14:35 > RESOLVED. ---------------------------------------- File: sources/canbus/CanInterface.h Revision Comment by pmontazemi on 08 September 2020, 09:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c4411 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:05 > Removed. Reply by pmontazemi on 08 September 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageAcknowModel.h Revision Comment by pmontazemi on 08 September 2020, 09:38 https://devapps.diality.us/cru/UI-DEN-4690-1#c4410 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:06 > Removed. Reply by pmontazemi on 08 September 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageDispatcher.h Revision Comment by pmontazemi on 08 September 2020, 09:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4409 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:06 > Removed. Reply by pmontazemi on 08 September 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageGlobals.h Revision Comment by plucia on 09 September 2020, 13:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c4588 The last three are missing a description / comment Reply by Behrouz NematiPour on 16 September 2020, 01:30 > Please refer to the newer code review after the max revision > has been changed which has all the latest commits. > http://192.168.10.132:8060/cru/UI-DEN-4690-2-1 > Seems like it has appeared here as well. Reply by plucia on 07 October 2020, 13:38 > RESOLVED Revision Comment by pmontazemi on 08 September 2020, 09:36 https://devapps.diality.us/cru/UI-DEN-4690-1#c4404 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:07 > Removed. Reply by pmontazemi on 08 September 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageInterpreter.h Revision Comment by pmontazemi on 08 September 2020, 11:13 https://devapps.diality.us/cru/UI-DEN-4690-1#c4454 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:40 > Removed Reply by pmontazemi on 09 September 2020, 14:31 > RESOLVED. ---------------------------------------- File: sources/storage/StorageGlobals.h Revision Comment by pmontazemi on 08 September 2020, 09:46 https://devapps.diality.us/cru/UI-DEN-4690-1#c4412 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 11:06 > Removed. Reply by pmontazemi on 08 September 2020, 11:13 > RESOLVED. ---------------------------------------- File: sources/abstract/singleton.h Revision Comment by plucia on 09 September 2020, 13:33 https://devapps.diality.us/cru/UI-DEN-4690-1#c4584 The code documentation is missing Reply by Behrouz NematiPour on 09 September 2020, 14:16 > This file has been completely removed. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:19 > The code documentation is still missing: > [http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18520] Reply by Behrouz NematiPour on 06 October 2020, 12:37 > This file doesn't exist anymore. > For some reason, Crucible is showing it. Reply by plucia on 07 October 2020, 13:38 > RESOLVED Revision Comment by plucia on 09 September 2020, 14:02 https://devapps.diality.us/cru/UI-DEN-4690-1#c4597 This filename is not CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:17 > This file has been removed. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. > Please look at Please look at > http://192.168.10.132:8060/cru/UI-DEN-4690-2-1 Reply by plucia on 30 September 2020, 10:18 > RESOLVED. ---------------------------------------- File: sources/abstract/singleton.h._ Revision Comment by pmontazemi on 08 September 2020, 09:35 https://devapps.diality.us/cru/UI-DEN-4690-1#c4403 Why file name ends in .h._? Reply by Behrouz NematiPour on 08 September 2020, 10:59 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 12:59 > Remove. Reply by Behrouz NematiPour on 08 September 2020, 13:42 > This file has been removed. > Not sure why it shows up here! Reply by pmontazemi on 09 September 2020, 14:27 > RESOLVED. ---------------------------------------- File: sources/canbus/CanInterface.cpp Revision Comment by plucia on 09 September 2020, 13:34 https://devapps.diality.us/cru/UI-DEN-4690-1#c4585 Is quitThread() unused? How do you know, or what led you to realize that application termination isn't correctly done in coco? How did you test that it works perfectly fine? Reply by Behrouz NematiPour on 16 September 2020, 01:38 > "*** Off the subject ***" > At the time of testing application with SquishCoco, observed > that Coco can't safely quit application and terminates the > application and don't call the correct quit method of the > application and that makes sense since the Squish Coco is > another application and will immediately terminate the UI > application and don't know how to properly quit the UI > application. > So UI application can't safely quit the threads. > Therefore some threading features has been manually tested. > The quitThread in each class is basically should name > moveThread (move to main thread). > > I hope this is enough information ! Reply by plucia on 07 October 2020, 13:51 > When you say "the UI application can't safely quit the > threads" is this something you think should be fixed? > > If the UI quits itself will this and other similar methods > be called? Shouldn't there be a test to ensure the UI can > at least quit on its own properly? Reply by Behrouz NematiPour on 07 October 2020, 21:50 > "*** Off the subject ***" > > There are tests (manually/automatically) for that and the > application quits properly. > If terminates by SquishCoco or being killed in the > terminal may not have time to clean up correctly. > When shuts down by user within the UI by user quits > nicely and clean. > > "*** Also please don't check "Needs resolution" for every > comment you make, it happened many times regardless of > mentioning it multiple times ***" Reply by plucia on 14 October 2020, 10:40 > Fair, not related to story. > > RESOLVED. ---------------------------------------- File: sources/canbus/MessageBuilder.cpp Revision Comment by plucia on 09 September 2020, 13:42 https://devapps.diality.us/cru/UI-DEN-4690-1#c4589 What are you not sure is correct here? If it's calcCRC, is that function being used elsewhere? Reply by Behrouz NematiPour on 16 September 2020, 01:27 > Although the comment is not relevant to the Story and to the > code review, code comment has been removed regardless. Reply by plucia on 07 October 2020, 13:53 > RESOLVED Revision Comment by plucia on 07 October 2020, 14:44 https://devapps.diality.us/cru/UI-DEN-4690-1#c5374 Missing details and description Reply by Behrouz NematiPour on 07 October 2020, 22:43 > Added Reply by plucia on 14 October 2020, 10:29 > RESOLVED ---------------------------------------- File: sources/canbus/caninterface.cpp Revision Comment by plucia on 09 September 2020, 13:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c4587 Why can't you enable / disable the CANBus in test code? Reply by Behrouz NematiPour on 16 September 2020, 01:32 > "*** Off the subject ***" > This is not related to the story and is a code coverage of > another story. > Regardless it was decided to manually test the CANBus at that > moment since it could be better tested with more accurate > results which all of those test couldn't be achieved manually > and took a long time to test because 10 or 100 of thousands > of frames tested and wasn't reasonable to do it each time > automatically on server with virtual CANBus and had to be > tested on a real physical CANBus. > I hope this is enough information! Reply by plucia on 07 October 2020, 13:44 > RESOLVED Revision Comment by plucia on 07 October 2020, 13:46 https://devapps.diality.us/cru/UI-DEN-4690-1#c5358 return type is missing Reply by Behrouz NematiPour on 07 October 2020, 22:49 > Added > http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18398 > line 203 Reply by plucia on 14 October 2020, 10:39 > RESOLVED. Revision Comment by plucia on 07 October 2020, 13:47 https://devapps.diality.us/cru/UI-DEN-4690-1#c5359 Return type is not here but it's sometimes provided elsewhere (see frameFlags docstring) Reply by Behrouz NematiPour on 07 October 2020, 22:07 > How is framFlags related to this function? > The return type is FrameCount and as it says it is the count > of frames that had an error as the function comment says. Reply by plucia on 14 October 2020, 10:38 > RESOLVED. ---------------------------------------- File: sources/canbus/frameinterface.cpp Revision Comment by plucia on 09 September 2020, 14:03 https://devapps.diality.us/cru/UI-DEN-4690-1#c4598 This filename is not CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:16 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:18 > RESOLVED. ---------------------------------------- File: sources/canbus/messageacknowmodel.cpp Revision Comment by plucia on 07 October 2020, 14:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c5373 Should indicate the return type and what is returned when. if init() changes, this function will behave differently, but it won't be reflected in the documentation Reply by Behrouz NematiPour on 07 October 2020, 21:41 > What do you mean by : > "if init() changes, this function will behave differently, > but it won't be reflected in the documentation" > the function document says the same thing: > "returns the return value of the init() method" > so if init() changes this function return changes because > it's an overloaded method of the init() function. Reply by plucia on 14 October 2020, 10:31 > RESOLVED. ---------------------------------------- File: sources/canbus/messageacknowmodel.h Revision Comment by plucia on 07 October 2020, 14:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c5367 A parameter description is missing here Reply by Behrouz NematiPour on 07 October 2020, 22:47 > Added > http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18400 > line 152 Reply by plucia on 14 October 2020, 10:35 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:06 https://devapps.diality.us/cru/UI-DEN-4690-1#c4471 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:32 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:35 > RESOLVED. ---------------------------------------- File: sources/canbus/messagebuilder.cpp Revision Comment by plucia on 07 October 2020, 14:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c5372 The docstrings need to include information about when true and false are returned Reply by Behrouz NematiPour on 07 October 2020, 21:44 > what docstring, where in the code? Reply by plucia on 14 October 2020, 10:34 > RESOLVED. Revision Comment by plucia on 07 October 2020, 14:38 https://devapps.diality.us/cru/UI-DEN-4690-1#c5368 Doesn't indicate when it returns true Reply by Behrouz NematiPour on 07 October 2020, 22:46 > added. > please refer to > http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18381 > line 44 Reply by plucia on 14 October 2020, 10:32 > RESOLVED. Revision Comment by plucia on 07 October 2020, 14:38 https://devapps.diality.us/cru/UI-DEN-4690-1#c5369 Doesn't indicate when true is returned Reply by Behrouz NematiPour on 07 October 2020, 21:47 > I think if it's not false (false if the vData of type > QByteArray is not sufficient regarding vAction) then it would > be true, right ?! Reply by plucia on 14 October 2020, 10:33 > RESOLVED. Revision Comment by plucia on 07 October 2020, 14:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c5370 Needs an explanation of when true is returned, which depends on a #define DISABLE_CRC Reply by Behrouz NematiPour on 07 October 2020, 21:46 > DISABLE_CRC is only for development debugging purposes. > and is not part of this function definition. > Will be defined/enabled in case for debugging. Reply by plucia on 14 October 2020, 10:34 > RESOLVED. ---------------------------------------- File: sources/canbus/messagebuilder.h Revision Comment by pmontazemi on 08 September 2020, 13:07 https://devapps.diality.us/cru/UI-DEN-4690-1#c4472 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:32 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:28 > RESOLVED. ---------------------------------------- File: sources/canbus/messagedispatcher.h Revision Comment by pmontazemi on 08 September 2020, 13:08 https://devapps.diality.us/cru/UI-DEN-4690-1#c4473 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:32 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:28 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:08 https://devapps.diality.us/cru/UI-DEN-4690-1#c4474 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:32 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:28 > RESOLVED. ---------------------------------------- File: sources/canbus/messageglobals.h Revision Comment by plucia on 09 September 2020, 14:03 https://devapps.diality.us/cru/UI-DEN-4690-1#c4600 This filename is not CamelCase Reply by Behrouz NematiPour on 16 September 2020, 01:24 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:18 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:08 https://devapps.diality.us/cru/UI-DEN-4690-1#c4475 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:32 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:28 > RESOLVED. ---------------------------------------- File: sources/canbus/messageinterpreter.cpp Revision Comment by plucia on 09 September 2020, 14:03 https://devapps.diality.us/cru/UI-DEN-4690-1#c4599 This filename is not CamelCase Reply by Behrouz NematiPour on 16 September 2020, 01:24 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:18 > RESOLVED ---------------------------------------- File: sources/canbus/messageinterpreter.h Revision Comment by pmontazemi on 08 September 2020, 13:08 https://devapps.diality.us/cru/UI-DEN-4690-1#c4476 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:27 > this file has been replaced by its Camel Case version. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:08 https://devapps.diality.us/cru/UI-DEN-4690-1#c4477 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:39 > This file has been replaced by its Camel Case version. > Not sure why it shows up here! Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. ---------------------------------------- File: sources/configuration/display.cpp._ Revision Comment by pmontazemi on 08 September 2020, 09:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4405 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:01 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 12:59 > Remove. Reply by Behrouz NematiPour on 08 September 2020, 13:33 > this file has been removed. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:27 > RESOLVED. ---------------------------------------- File: sources/configuration/display.h Revision Comment by pmontazemi on 08 September 2020, 13:09 https://devapps.diality.us/cru/UI-DEN-4690-1#c4478 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:27 > this file has been removed. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. ---------------------------------------- File: sources/configuration/display.h._ Revision Comment by pmontazemi on 08 September 2020, 09:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4406 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:01 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 12:59 > Remove. Reply by Behrouz NematiPour on 08 September 2020, 13:38 > This file has been removed. > Not sure why is showing up here! Reply by pmontazemi on 09 September 2020, 14:28 > RESOLVED. ---------------------------------------- File: sources/configuration/sound.cpp Revision Comment by plucia on 30 September 2020, 11:10 https://devapps.diality.us/cru/UI-DEN-4690-1#c4984 I didn't realize you were already working on the UI sound playback. Are you planning on leaving this class as or will continue to work on playing sound? Reply by Behrouz NematiPour on 30 September 2020, 11:55 > This class has been created as a template and guideline for > later use. > Since it was renamed to not to be used in Coverage suggested, > being removed. > So this file doesn't exist anymore. > But please look at it and use it as a template for sound > settings implementation. > notice the Configuration namespace. Reply by plucia on 30 September 2020, 15:54 > Okay, RESOLVED. ---------------------------------------- File: sources/configuration/sound.cpp._ Revision Comment by pmontazemi on 08 September 2020, 09:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4407 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:01 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 12:59 > Remove. Reply by Behrouz NematiPour on 08 September 2020, 13:38 > This file has been removed. > Not sure why is showing up here! Reply by pmontazemi on 09 September 2020, 14:36 > RESOLVED. ---------------------------------------- File: sources/configuration/sound.h Revision Comment by pmontazemi on 08 September 2020, 13:09 https://devapps.diality.us/cru/UI-DEN-4690-1#c4479 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:26 > this file has been removed. > don't know why it shows up here! Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. ---------------------------------------- File: sources/configuration/sound.h._ Revision Comment by pmontazemi on 08 September 2020, 09:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4408 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:01 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 12:59 > Remove. Reply by Behrouz NematiPour on 08 September 2020, 13:38 > This file has been removed. > Not sure why is showing up here! Reply by pmontazemi on 09 September 2020, 14:36 > RESOLVED. ---------------------------------------- File: sources/gui/guicontroller.cpp Revision Comment by plucia on 09 September 2020, 14:02 https://devapps.diality.us/cru/UI-DEN-4690-1#c4596 This filename is not CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:17 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:20 > RESOLVED. ---------------------------------------- File: sources/maintimer.cpp Revision Comment by plucia on 09 September 2020, 14:01 https://devapps.diality.us/cru/UI-DEN-4690-1#c4593 This file is not in CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:18 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:21 > RESOLVED. ---------------------------------------- File: sources/storage/filehandler.cpp Revision Comment by plucia on 09 September 2020, 14:02 https://devapps.diality.us/cru/UI-DEN-4690-1#c4594 This filename is not CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:17 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:21 > RESOLVED. ---------------------------------------- File: sources/storage/logger.h Revision Comment by pmontazemi on 08 September 2020, 13:20 https://devapps.diality.us/cru/UI-DEN-4690-1#c4483 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:23 > Interesting !!! > This file doesn't even exist anymore and has been replaced by > Logger.h > I don't see it in my folder and don't see it in my git log. > Don't know why has been shown here. Reply by pmontazemi on 09 September 2020, 14:30 > RESOLVED. ---------------------------------------- File: sources/storage/settings.cpp._ Revision Comment by pmontazemi on 08 September 2020, 09:46 https://devapps.diality.us/cru/UI-DEN-4690-1#c4413 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:02 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by Behrouz NematiPour on 08 September 2020, 13:37 > This file has been removed. > Not sure why is showing up here! Reply by pmontazemi on 09 September 2020, 14:36 > RESOLVED. ---------------------------------------- File: sources/storage/settings.h._ Revision Comment by pmontazemi on 08 September 2020, 09:46 https://devapps.diality.us/cru/UI-DEN-4690-1#c4414 Why does file name end in ._? Reply by Behrouz NematiPour on 08 September 2020, 11:02 > Changed the file name so Doxygen is not documenting it. > Doxygen is looking for .h/.cpp/.qml only. Reply by pmontazemi on 08 September 2020, 11:15 > If these files are part of the repo/build, Doxygen should > look for them. If these files are not part of repo/build, > then they should be removed. To have a better > understanding, what is the purpose of these ._ files? Reply by Behrouz NematiPour on 08 September 2020, 11:39 > You are right Peman. > I kept them as a template and removed them from the > project for later use. > Now I had to remove it from Doxygen sight. > Prefer to keep it if you don't mind. > Can be removed as well. Reply by pmontazemi on 08 September 2020, 12:57 > Please remove them all. Always a good practice to keep > only used/compiled/linked/built code in the repo. Reply by Behrouz NematiPour on 08 September 2020, 13:37 > This file has been removed. > Not sure why is showing up here! Reply by pmontazemi on 09 September 2020, 14:36 > RESOLVED. ---------------------------------------- File: sources/storage/storageglobals.cpp Revision Comment by plucia on 09 September 2020, 14:02 https://devapps.diality.us/cru/UI-DEN-4690-1#c4595 This filename is not CamelCase Reply by Behrouz NematiPour on 09 September 2020, 14:17 > This file has been replaced with its Camel Case version. > But since it had a copyright change on server which had no > code review assigned to it Crucible is showing it here after > I merged master into my branch. > So actually this file doesn't exist anymore. Reply by plucia on 30 September 2020, 10:21 > RESOLVED. ---------------------------------------- File: sources/storage/storageglobals.h Revision Comment by pmontazemi on 08 September 2020, 13:21 https://devapps.diality.us/cru/UI-DEN-4690-1#c4484 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:07 > This file replaced with its Camel Case version. Reply by pmontazemi on 09 September 2020, 14:30 > RESOLVED. ---------------------------------------- File: sources/view/valarmstatus.cpp Revision Comment by pmontazemi on 08 September 2020, 13:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4498 Remove extra lines. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:35 > RESOLVED. ---------------------------------------- File: sources/view/valarmstatus.h Revision Comment by pmontazemi on 08 September 2020, 13:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4500 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:34 > RESOLVED. ---------------------------------------- File: sources/view/vpoweroff.h Revision Comment by pmontazemi on 08 September 2020, 13:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4502 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:34 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:37 https://devapps.diality.us/cru/UI-DEN-4690-1#c4503 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:34 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentadjustmentduration.h Revision Comment by pmontazemi on 08 September 2020, 13:38 https://devapps.diality.us/cru/UI-DEN-4690-1#c4506 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:34 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentadjustmentflows.h Revision Comment by pmontazemi on 08 September 2020, 13:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c4509 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c4510 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:37 > This file is removed with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentadjustmentultrafiltrationedit.h Revision Comment by pmontazemi on 08 September 2020, 13:39 https://devapps.diality.us/cru/UI-DEN-4690-1#c4512 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentadjustmentultrafiltrationstate.h Revision Comment by pmontazemi on 08 September 2020, 13:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c4513 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentbloodflow.h Revision Comment by pmontazemi on 08 September 2020, 13:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c4514 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c4516 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:33 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentdialysateflow.h Revision Comment by pmontazemi on 08 September 2020, 13:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c4517 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:32 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:40 https://devapps.diality.us/cru/UI-DEN-4690-1#c4518 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:38 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:32 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentpressureocclusion.h Revision Comment by pmontazemi on 08 September 2020, 13:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c4519 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:40 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:32 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentranges.h Revision Comment by pmontazemi on 08 September 2020, 13:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c4520 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:41 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:32 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmenttime.h Revision Comment by pmontazemi on 08 September 2020, 13:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c4521 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:41 > This file is replaced with its Camel Case name version. Reply by pmontazemi on 09 September 2020, 14:31 > RESOLVED. ---------------------------------------- File: sources/view/vtreatmentultrafiltration.h Revision Comment by pmontazemi on 08 September 2020, 13:41 https://devapps.diality.us/cru/UI-DEN-4690-1#c4522 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 18:04 > This file replaced with its Camel Case version. Reply by pmontazemi on 09 September 2020, 14:31 > RESOLVED. ---------------------------------------- File: sources/gui/qml/globals/Colors.qml Revision Comment by plucia on 09 September 2020, 13:47 https://devapps.diality.us/cru/UI-DEN-4690-1#c4590 These comments should be deleted, no? If they are serving a purpose, there should be some description as to why there are kept Reply by Behrouz NematiPour on 09 September 2020, 14:15 > These are different color themes on the UI screens which I > found during testing on different displays. > I would rather keep them until a good release. Reply by plucia on 30 September 2020, 15:54 > Okay could you put a comment in indicating that it's for > the different displays so its clear? Reply by Behrouz NematiPour on 05 October 2020, 12:58 > put. Reply by plucia on 07 October 2020, 13:43 > RESOLVED ---------------------------------------- File: sources/gui/qml/globals/Fonts.qml Revision Comment by pmontazemi on 08 September 2020, 13:09 https://devapps.diality.us/cru/UI-DEN-4690-1#c4480 Remove extra lines. Reply by Behrouz NematiPour on 08 September 2020, 13:58 > Removed but not showing up here. Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. Revision Comment by pmontazemi on 08 September 2020, 13:09 https://devapps.diality.us/cru/UI-DEN-4690-1#c4481 Remove extra lines. Reply by Behrouz NematiPour on 08 September 2020, 13:58 > Removed but not showing up here. Reply by pmontazemi on 09 September 2020, 14:29 > RESOLVED. ---------------------------------------- File: sources/model/MAbstract.cpp Revision Comment by pmontazemi on 08 September 2020, 13:14 https://devapps.diality.us/cru/UI-DEN-4690-1#c4482 Remove extra line. Reply by Behrouz NematiPour on 08 September 2020, 13:59 > Removed but not showing up here. Reply by pmontazemi on 09 September 2020, 14:30 > RESOLVED. --- ID: UI-DEN-4690-1 https://devapps.diality.us/cru/UI-DEN-4690-1 Title: UI-DEN-4690_ Doxygenization Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)