This is a list of all comments for UI-DEN-4691-1. Review Summary: No summary ---------------------------------------- File: sources/model/hd/adjustment/MTreatmentAdjustRequests.h Revision Comment by plucia on 09 November 2020, 17:59 https://devapps.diality.us/cru/UI-DEN-4691-1#c5972 The message ID is in decimal not hex Reply by Behrouz NematiPour on 10 November 2020, 14:24 > Thanks for reminding that. > updated all the other ones as well. > done. Reply by plucia on 16 November 2020, 09:37 > RESOLVED ---------------------------------------- File: sources/view/hd/adjustment/VTreatmentAdjustmentPressuresLimits.cpp Revision Comment by plucia on 09 November 2020, 17:50 https://devapps.diality.us/cru/UI-DEN-4691-1#c5970 Once the user has selected the arterial and venous pressure limits in pre-treatment, before they try to adjust them, how are the values they chose in pre-treatment displayed here? Reply by Behrouz NematiPour on 10 November 2020, 14:20 > Great question. > There would be another connection for the message "Treatment > Parameters validation" and that will update the properties > here when that message with parameters received. > It would be an extra : > > ACTION_VIEW_CONNECTION(AdjustPressuresLimitsResponseData); > with the correct model as a parameter and another: > void > VTreatmentAdjustmentPressuresLimits::onActionReceive(const > AdjustPressuresLimitsResponseData &vData) > with that model as parameter. Reply by plucia on 19 November 2020, 10:08 > RESOLVED. > My understanding is that this will be connected in a future > story ---------------------------------------- File: sources/canbus/MessageInterpreter.cpp Revision Comment by pmontazemi on 09 November 2020, 10:42 https://devapps.diality.us/cru/UI-DEN-4691-1#c5952 Remove extra line. Reply by Behrouz NematiPour on 10 November 2020, 14:25 > done Reply by pmontazemi on 10 November 2020, 18:36 > RESOLVED. ---------------------------------------- File: sources/gui/qml/globals/Colors.qml Revision Comment by plucia on 10 November 2020, 16:43 https://devapps.diality.us/cru/UI-DEN-4691-1#c6093 To make it consistent these could also be red and white without double quotes Reply by Behrouz NematiPour on 15 November 2020, 17:37 > Done Reply by plucia on 16 November 2020, 09:37 > RESOLVED ---------------------------------------- File: unittests/tst_views.cpp Revision Comment by plucia on 12 November 2020, 10:48 https://devapps.diality.us/cru/UI-DEN-4691-1#c6150 Is there a reason these shouldn't be deleted? Reply by Behrouz NematiPour on 15 November 2020, 17:35 > Removed. Reply by plucia on 16 November 2020, 09:37 > RESOLVED --- ID: UI-DEN-4691-1 https://devapps.diality.us/cru/UI-DEN-4691-1 Title: UI-DEN-4691_Inline Blood Pressure Adjustments Statement of Objectives: Story: DEN-4691: UI Blood In-Line Pressure Adjustments Note : - Some codes have been pulled from master and are subject to change/update in other stories. Will refer to this not if commented. - Some changes have been reviewed already since this story has been suspended for a while and has been branched out from within the Doxygenization branch and after branch, the source branch was moving forward. - Some codes have been mixed up with the "Create Treatment" story due to the fact that these are parallel stories. ChangeLog: 01 - The messages for Adjusting Inline Arterial/Venous blood pressures request/response implemented. 02 - RangeBar.qml Component updated to have out of range RangeMarker color. 03 - RangeSlider.qml component has been created. 04 - TickMarks.qml component ranges type changed from int to real. 05 - TouchArea.qml component now has a property to hide the arrow/chevron. 06 - A compound component PressureRangeSlider.qml has been created specifically for the pressures adjustment screen which contains a double progressbar (a progressbar for the current pressure values and another progress for the limits on top of it) and a double slider to allow the user to adjust the limits. 07 - The Inline Arterial/Venous blood pressures adjustment screen has been created. 08 - Updated TreatmentPressures.qml section. 09 - Added CONSTANT property. 10 - Some other minor tweaks. State: Closed Summary: Author: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)