This is a list of all comments for UI-DEN-5283-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/GuiGlobals.h
Revision Comment by plucia on 19 October 2020, 14:05 
https://devapps.diality.us/cru/UI-DEN-5283-1#c5610

  If it was necessary to rename Saline_States to
  Saline_Bolus_States, shouldn't you rename GuiSalineStates to
  GuiSalineBolusStates as well?

  Reply by Behrouz NematiPour on 19 October 2020, 15:02
  > This is not UI Application Software naming conventions.
  > This enum comes from HDDefs.h@223 as part of the Firmware
  > shared code with Software on Common repo.
  > In short, it is not our code.

    Reply by plucia on 20 October 2020, 11:04
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
Revision Comment by plucia on 19 October 2020, 14:04 
https://devapps.diality.us/cru/UI-DEN-5283-1#c5609

  Why is this named _private? Could there be a better name?

  Reply by Behrouz NematiPour on 19 October 2020, 15:05
  > in Qml codes when needs to have private members since we
  > don't have that concept, a QtObject item with id "\_private"
  > will be created.
  > "\_" is for private and private is to emphasis on the private
  > since there is no actual private keyword in Qt<6 available.
  > And there should be a unique one in each context.

    Reply by plucia on 20 October 2020, 11:04
    > RESOLVED

----------------------------------------
File: tst_Treatment_Adjustment_Saline/test.py
Revision Comment by plucia on 19 October 2020, 14:02 
https://devapps.diality.us/cru/UI-DEN-5283-1#c5608

  Better to not use global variables unless absolutely necessary

  Reply by Behrouz NematiPour on 19 October 2020, 21:44
  > done.

    Reply by plucia on 20 October 2020, 09:20
    > RESOLVED


---

ID: UI-DEN-5283-1 https://devapps.diality.us/cru/UI-DEN-5283-1

Title: UI-DEN-5283_Saline Bolus FW Modification
Statement of Objectives:
Application repo :
------------------------
Story related fixes:
 - Used FW enum for Saline Bolus in Common repo
 - txPaused modified the way FW understands and transmits.

Extra fixes:
 - Changed the Ultrafiltration ref/meas vol to 3 decimals.
 - Application version wasn't correctly shown
 - Added a #define for the mouse event spy since on target it's not usually happening and is not useful neither on a target nor on the desktop for now.
 - Fixed the author typo
 - Cherry Picked the fix for the version from the In-Line branch.

testsuites repo:
------------------------
Story fixes:
 - Unit testing and integration testing for the sub-task DEN-5284: implementation
 - modified the HDOutletFlow test for the 3 decimals.

Extra fixes:
 - Modified the Simulator to be Object-Oriented designed.
 - Removed backward compatibility with the old squish codes out of Dialin.

State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)