This is a list of all comments for UI-DEN-5736-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentStack.qml Revision Comment by plucia on 30 November 2020, 10:24 https://devapps.diality.us/cru/UI-DEN-5736-1#c6317 isSalineBolusInProgress is clearer Reply by Behrouz NematiPour on 30 November 2020, 11:40 > I agree, but I wanted to keep this naming consistent with Tx, > Uf only in two letters. Reply by plucia on 03 December 2020, 10:19 > RESOLVED. ---------------------------------------- File: sources/model/hd/data/MTreatmentStatesData.h Revision Comment by plucia on 03 December 2020, 10:00 https://devapps.diality.us/cru/UI-DEN-5736-1#c6635 This should be #4 Reply by Behrouz NematiPour on 03 December 2020, 11:48 > done Reply by plucia on 03 December 2020, 11:52 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Revision Comment by pmontazemi on 01 December 2020, 09:02 https://devapps.diality.us/cru/UI-DEN-5736-1#c6483 "change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language. Reply by Behrouz NematiPour on 02 December 2020, 20:21 > done Reply by pmontazemi on 03 December 2020, 10:40 > RESOLVED. Revision Comment by pmontazemi on 01 December 2020, 09:02 https://devapps.diality.us/cru/UI-DEN-5736-1#c6484 "notices" instead of "notice" Reply by Behrouz NematiPour on 01 December 2020, 13:29 > Done Reply by pmontazemi on 03 December 2020, 10:41 > RESOLVED. Revision Comment by pmontazemi on 01 December 2020, 09:03 https://devapps.diality.us/cru/UI-DEN-5736-1#c6485 Please get with SYS Engineering and SeanN of FW to get to the bottom of this. Once you got an answer, please remove comment. Reply by Behrouz NematiPour on 01 December 2020, 13:54 > DEN-5928: Investigation on the ultrafiltration founded bug > > Created a Bug for investigation put on next spring. > Created a tag on this git commit. > Put enough information in the bug description. Reply by pmontazemi on 03 December 2020, 10:41 > RESOLVED. Revision Comment by pmontazemi on 01 December 2020, 09:01 https://devapps.diality.us/cru/UI-DEN-5736-1#c6482 "change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language. Reply by Behrouz NematiPour on 01 December 2020, 13:25 > done, > Sure from now on. Reply by pmontazemi on 03 December 2020, 10:41 > RESOLVED. Revision Comment by pmontazemi on 01 December 2020, 09:03 https://devapps.diality.us/cru/UI-DEN-5736-1#c6486 Same comment as above here. Reply by Behrouz NematiPour on 01 December 2020, 13:25 > done, > Sure from now on. Reply by pmontazemi on 03 December 2020, 10:40 > RESOLVED. ---------------------------------------- File: tst_TreatmentHeparineData/test.py Revision Comment by plucia on 30 November 2020, 10:20 https://devapps.diality.us/cru/UI-DEN-5736-1#c6315 Same comment about waitForObjectExists as in here: http://dvm-linux02:8060/cru/UI-DEN-5736-1#CFR-20566 Reply by Behrouz NematiPour on 30 November 2020, 11:49 > Thanks for the comment. > I replied to the same comment. Reply by plucia on 03 December 2020, 11:53 > RESOLVED ---------------------------------------- File: tst_Treatment_Adjustment_Heparin/test.py Revision Comment by plucia on 30 November 2020, 09:48 https://devapps.diality.us/cru/UI-DEN-5736-1#c6313 The object being waited for will always exist. Instead, the buttonText should be added to the object that is being waited for. e.g. {code} your_var = names.o_treatmentStart_heparinSection your_var["buttonText"] = "{} DELIVERY".format(vText) waitForObjectExists(your_var) {code} To address this problem, in my current Dialin Branch I've created a dict_update convenience function that allows you to add or update a dictionary's key and value. It will return a new dictionary object without modifying the original. The default python update call modifies the original and doesn't return a new object. So, using dict_update allows a simple one-liner for situations like these. Once merged with my branch, you can use {code}ui.utils.dict_update{code} and this operation can be simplified to a one-liner: {code} waitForObjectExists(dict_update(names.o_treatmentStart_heparinSection, "buttonText", "{} DELIVERY".format(vText))) {code} Reply by Behrouz NematiPour on 30 November 2020, 11:44 > I'm not sure I see what's the issue to resolve here since I > notice only a helper method for waitForObjectExists of > SquishQt. > And also I would strongly not want to play with SquishQt APIs > so when an error happens or when the test is not working I > don't want to debug the helper or wrappers and want to only > focus on the test. > Please use simple direct SquishQt API. > You are free to do any sophisticated logic in dialin but > please keep the tests as simple as possible (just copy/paste > if applicable) and only use SquishQt API unless it's > absolutely necessary. Reply by plucia on 02 December 2020, 13:06 > Basically, you're calling waitForObjectExists on a > component that will always exist. It will be visible and > enabled too, so waitForObject wouldn't help you. What would > help you is to wait for the object to exist that > distinguishes it from the object being waited for in > previous calls to test_state. The dictionary, > names.o_treatmentStart_HeparinSection, is not unique with > each call, but if you set the buttonText property of that > dictionary on each call, then it will be unique. So that > property needs to be part of the object you're waiting for > in order for repeated calls to waitForObjectExists to be > useful. Using the helper function is up to you. I'm just > letting you know of its existence and purpose should you > choose to use it in the future once it's merged. Hope this > clarifies things Reply by plucia on 03 December 2020, 11:52 > RESOLVED. > As per our conversation today, these uncovered issues > will be addressed as part of the squish migration. --- ID: UI-DEN-5736-1 https://devapps.diality.us/cru/UI-DEN-5736-1 Title: UI-DEN-5736_UI Heparin Bolus Statement of Objectives: Application: - Implemented Heparin request/response/data. - Saline progress bar not moving fixed. - Ultrafiltration suspected bug has been fixed but commented out since no one ever complained. TestSuites: - Made the Duration slider work. - Made the simulator MDI layout - Made the simulator a little bit more plugin-based to be able to add more sections easier. - It still needs work to load/register the plugins automatically. - Added Heparin plugin - Renamed all the .py and .ui to loader.py and interface.ui to be one step closer to load dynamically - Fixed the API bug when implementing the request. State: Closed Summary: Author: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)