This is a list of all comments for UI-DEN-5777-1.

Review Summary: No summary


----------------------------------------
File: sources/storage/FileHandler.cpp
Revision Comment by pmontazemi on 01 February 2021, 14:20 
https://devapps.diality.us/cru/UI-DEN-5777-1#c7744

  cannot

  Reply by Behrouz NematiPour on 01 February 2021, 16:27
  > Corrected the sentences and updated "can't" to "cannot"
  > everywhere in the file.

    Reply by pmontazemi on 01 February 2021, 16:49
    > RESOLVED.

Revision Comment by pmontazemi on 01 February 2021, 14:21 
https://devapps.diality.us/cru/UI-DEN-5777-1#c7746

  "File cannot be opened for read (%1). Possible corrupted file
  system."
  
  1. Rephrase and spell cannot as mentioned.
  2. Add space between two sentences.
  3. Add "." at end of 2nd sentence.

  Reply by Behrouz NematiPour on 01 February 2021, 16:26
  > Corrected the sentences and updated "can't" to "cannot"
  > everywhere in the file.

    Reply by pmontazemi on 01 February 2021, 16:41
    > RESOLVED.

Revision Comment by pmontazemi on 01 February 2021, 14:25 
https://devapps.diality.us/cru/UI-DEN-5777-1#c7749

  Did you mean retained? If so, change all these to retained as
  well as hte name of the quint8 variable to vRetainedPercent.

  Reply by Behrouz NematiPour on 01 February 2021, 16:28
  > I meant "retains" and "retain".
  > A complete sentence would be :
  > "if 90% retains ...." or
  > "if 90% shall retain"
  > I prefer to have *a present verb, for input* and if it was
  > *output, a past verb*.

    Reply by pmontazemi on 01 February 2021, 16:49
    > RESOLVED.

----------------------------------------
File: sources/storage/Logger.h
Revision Comment by pmontazemi on 01 February 2021, 16:42 
https://devapps.diality.us/cru/UI-DEN-5777-1#c7763

  16GB and 2.4GB (units are Bytes).

  Reply by Behrouz NematiPour on 01 February 2021, 16:45
  > fixed.

    Reply by pmontazemi on 01 February 2021, 16:48
    > RESOLVED.


---

ID: UI-DEN-5777-1 https://devapps.diality.us/cru/UI-DEN-5777-1

Title: UI-DEN-5777_UI Dev Convert Logging From Hours to %
Statement of Objectives:
*Applicarion:*
- Added a signal named didSDCardSpaceTooLow in the DriveWatcher which will be triggered when the free storage space available on the SD-CARD is less than 10%. (No action on UI happens currently)
     - Added a flag in DriveWatcher to stop emitting the Logger while it is cleaning the Logs [[ IMPORTANT : is is handled by signal/slots for thread synchronization and safety ]].
     - Added a function to find the total size of the file in a path.
     - Added find function to find files with a list of filter in a path.
     - Added an overloaded version of find to help find the files in a path which are exceeding the storage limit from the oldest files.
     - Added error check in the read overloaded which works with Json.
     - Re-implemented the FileHandler::removeLogs to clean up the logs by % instead of date.
     - Removed unused global log paths from StorageGlobal.


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)