This is a list of all comments for UI-DEN-6631-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentStack.qml
Revision Comment by pmontazemi on 16 February 2021, 11:15 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8139

  Only two "/" for comments in QML.

  Reply by Behrouz NematiPour on 16 February 2021, 11:22
  > it is a kind of hierarchy commenting that the //// is the
  > title and the rest beneath that are like 1.1 and 1.2 so it
  > helps to organize better.

    Reply by pmontazemi on 16 February 2021, 13:04
    > RESOLVED.

----------------------------------------
File: sources/view/hd/data/VHDTreatmentStatesData.cpp
Revision Comment by pmontazemi on 15 February 2021, 13:04 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8109

  it is as formal (instead of it's as informal)

  Reply by Behrouz NematiPour on 15 February 2021, 17:18
  > fixed.

    Reply by pmontazemi on 16 February 2021, 13:03
    > RESOLVED.

Revision Comment by pmontazemi on 15 February 2021, 13:05 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8110

  Remove perhaps which suggest incertitude in Class B code.

  Reply by Behrouz NematiPour on 15 February 2021, 17:18
  > Removed.

    Reply by pmontazemi on 16 February 2021, 13:03
    > RESOLVED.

----------------------------------------
File: sources/view/hd/data/VHDTreatmentStatesData.h
Revision Comment by plucia on 15 February 2021, 13:19 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8112

  These are currently unused, maybe they can be deleted?

  Reply by Behrouz NematiPour on 16 February 2021, 13:48
  > Removed.

    Reply by plucia on 16 February 2021, 13:48
    > RESOLVED

----------------------------------------
File: sources/view/hd/adjustment/VTreatmentAdjustmentRecirculate.cpp
Revision Comment by pmontazemi on 15 February 2021, 13:03 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8108

  Remove extra lines.

  Reply by Behrouz NematiPour on 15 February 2021, 17:18
  > Removed.

    Reply by pmontazemi on 16 February 2021, 11:13
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
Revision Comment by plucia on 16 February 2021, 13:42 
https://devapps.diality.us/cru/UI-DEN-6631-1#c8153

  I think you meant fontsPixelCreateTreatmentTable

  Reply by Behrouz NematiPour on 16 February 2021, 13:48
  > Thanks for catching that,
  > Fixed.

    Reply by plucia on 16 February 2021, 13:49
    > RESOLVED


---

ID: UI-DEN-6631-1 https://devapps.diality.us/cru/UI-DEN-6631-1

Title: UI-DEN-6631_UI DEV POST Treatment Rinseback
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)