This is a list of all comments for UI-DEN-7752-1.

Review Summary: No summary


----------------------------------------
File: sources/model/dg/adjustment/MAdjustDGServiceResponse.h
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:09 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9672

  please change this to eDG.

  Reply by plucia on 04 May 2021, 15:23
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:04
    > RESOLVED

----------------------------------------
File: sources/model/hd/adjustment/MTreatmentAdjustRequests.h
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:11 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9673

  Where it is used?

  Reply by plucia on 04 May 2021, 15:26
  > This is used in INTERPRET_RECVD_MT_MESSAGE in
  > MessageInterpreter.cpp.
  > It is overridden so a broadcast is sent out instead of a
  > direct message to the HD.

    Reply by Behrouz NematiPour on 06 May 2021, 14:19
    > RESOLVED.

----------------------------------------
File: sources/view/VDeviceInformation.cpp
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:32 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9679

  please put tr() for translation.

  Reply by plucia on 04 May 2021, 15:41
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:21
    > RESOLVED

Revision Comment by Behrouz NematiPour on 29 April 2021, 11:32 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9678

  please put tr() for translation.

  Reply by plucia on 04 May 2021, 15:40
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:21
    > RESOLVED

----------------------------------------
File: sources/view/VDeviceInformation.h
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:35 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9680

  As it seems in the qml these properties are not used directly
  in UI and only the key/value pairs are used.
  So it would be better to have key or value as QStringList
  properties and change these properties to just values.

  Reply by plucia on 04 May 2021, 15:15
  > Now updated to just variables since they are not used in qml

    Reply by Behrouz NematiPour on 06 May 2021, 14:48
    > RESOLVED

Revision Comment by Behrouz NematiPour on 29 April 2021, 11:27 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9677

  For the properties, we don't use 'm' as a prefix and only start
  the name with no capital letter.

  Reply by plucia on 04 May 2021, 15:16
  > The m is now removed and replaced with underscores to
  > indicate that they are private.

    Reply by Behrouz NematiPour on 06 May 2021, 14:48
    > RESOLVED

----------------------------------------
File: sources/model/MDGSerialNumberResponse.h
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:17 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9674

  please move it in an appropriate folder(dg/adjustment)

  Reply by plucia on 04 May 2021, 15:38
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:20
    > RESOLVED

----------------------------------------
File: sources/model/MHDSerialNumberResponse.h
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:18 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9675

  please move it in an appropriate folder(hd/adjustment)

  Reply by plucia on 04 May 2021, 15:39
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:20
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
Revision Comment by Behrouz NematiPour on 29 April 2021, 11:06 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9671

  Please use 'fontPixel' prefix for your font's pixelSize
  variables to distinguish between the different properties of
  the font.

  Reply by plucia on 04 May 2021, 15:23
  > Done

    Reply by Behrouz NematiPour on 06 May 2021, 14:49
    > RESOLVED

----------------------------------------
File: sources/model/dg/adjustment/MDGSerialNumberResponse.h
Revision Comment by Behrouz NematiPour on 06 May 2021, 14:01 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9777

  Please change to "Event".
  Datum: is a message that comes regularly in a certain period.
  Event: is a message that comes on a request only and can happen
  anytime.
  Please update the SDDUI 285.

  Reply by plucia on 11 May 2021, 15:47
  > Done

    Reply by Behrouz NematiPour on 11 May 2021, 16:35
    > RESOLVED

----------------------------------------
File: sources/model/hd/adjustment/MHDSerialNumberResponse.h
Revision Comment by Behrouz NematiPour on 06 May 2021, 14:03 
https://devapps.diality.us/cru/UI-DEN-7752-1#c9778

  Please change to "Event".
  Datum: is a message that comes regularly in a certain period.
  Event: is a message that comes on a request only and can happen
  anytime.
  Please update the SDDUI 286.

  Reply by plucia on 11 May 2021, 15:45
  > Done

    Reply by Behrouz NematiPour on 11 May 2021, 16:34
    > RESOLVED


---

ID: UI-DEN-7752-1 https://devapps.diality.us/cru/UI-DEN-7752-1

Title: UI-DEN-7752_Device Information
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (0 active, 2 completed*)
     Behrouz NematiPour   (*)
     pmontazemi   (*)