This is a list of all comments for UI-DEN-7820-1.

Review Summary: No summary


----------------------------------------
File: sources/canbus/MessageDispatcher.cpp
Revision Comment by pmontazemi on 22 April 2021, 12:17 
https://devapps.diality.us/cru/UI-DEN-7820-1#c9564

  Dereferencing which parameter here? (sorry I have never seen
  this in the past)

  Reply by Behrouz NematiPour on 22 April 2021, 12:25
  > That is the function signature and doesn't have to have any
  > parameter defined if it is not being used and no argument is
  > passing to it.
  > This way we don't need to use the Q_UNUSED(vData); anymore
  > for parameters not being used.

    Reply by pmontazemi on 22 April 2021, 13:31
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/SDItem.qml
Revision Comment by plucia on 26 April 2021, 11:15 
https://devapps.diality.us/cru/UI-DEN-7820-1#c9629

  Looks like this needs to be updated

  Reply by Behrouz NematiPour on 26 April 2021, 15:52
  > Updated.

    Reply by plucia on 27 April 2021, 10:49
    > RESOLVED


---

ID: UI-DEN-7820-1 https://devapps.diality.us/cru/UI-DEN-7820-1

Title: UI-DEN-7820_UI DEV Post Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)