This is a list of all comments for UI-DEN-8308-1. Review Summary: No summary ---------------------------------------- File: sources/storage/Logger.cpp Revision Comment by plucia on 21 May 2021, 07:01 https://devapps.diality.us/cru/UI-DEN-8308-1#c9997 The docstring is missing Reply by Behrouz NematiPour on 22 May 2021, 16:19 > Added Reply by plucia on 25 May 2021, 10:44 > RESOLVED ---------------------------------------- File: sources/storage/TreatmentLog.cpp Revision Comment by plucia on 11 May 2021, 12:38 https://devapps.diality.us/cru/UI-DEN-8308-1#c9825 Code documentation is missing Reply by Behrouz NematiPour on 11 May 2021, 14:16 > Done Reply by plucia on 13 May 2021, 08:53 > RESOLVED ---------------------------------------- File: sources/storage/TreatmentLog.h Revision Comment by plucia on 11 May 2021, 12:39 https://devapps.diality.us/cru/UI-DEN-8308-1#c9826 Are these placeholders? If not, why are they blank? Reply by Behrouz NematiPour on 11 May 2021, 12:48 > There is no unit for the items in these indexes for example > Device ID doesn't have a unit and then it will leave blank > for that one. Reply by plucia on 13 May 2021, 08:54 > RESOLVED ---------------------------------------- File: simulator/plugins/PostTreatment/loader.py Revision Comment by plucia on 24 May 2021, 07:10 https://devapps.diality.us/cru/UI-DEN-8308-1#c10037 The bytearray conversions need to be inside the cmd_send_post_treatment_log_response function Reply by Behrouz NematiPour on 24 May 2021, 23:36 > It has been updated regarding our conversation. Reply by plucia on 25 May 2021, 10:41 > RESOLVED Revision Comment by plucia on 24 May 2021, 07:13 https://devapps.diality.us/cru/UI-DEN-8308-1#c10038 The bytearray conversions need to be inside the dialin function Reply by Behrouz NematiPour on 24 May 2021, 23:36 > It has been updated regarding our conversation. Reply by plucia on 25 May 2021, 10:41 > RESOLVED ---------------------------------------- File: alarmMapping Revision Comment by plucia on 24 May 2021, 06:58 https://devapps.diality.us/cru/UI-DEN-8308-1#c10032 Shouldn't the source code be added to the repository instead of the binary file? Reply by Behrouz NematiPour on 24 May 2021, 14:07 > Correct, > A repository will be created for this tool very soon, but > still, the executable will be here regardless. Reply by plucia on 25 May 2021, 10:43 > RESOLVED ---------------------------------------- File: alarmMapping.err Revision Comment by plucia on 24 May 2021, 07:00 https://devapps.diality.us/cru/UI-DEN-8308-1#c10035 I assume this is just the stderr output from running alarmMapping. Is there a reason why it needs to be part of the repository? Reply by Behrouz NematiPour on 24 May 2021, 13:52 > It's like running the cppcheck script that we keep the > outputs. Reply by plucia on 25 May 2021, 10:45 > RESOLVED ---------------------------------------- File: alarmMapping.log Revision Comment by plucia on 24 May 2021, 06:59 https://devapps.diality.us/cru/UI-DEN-8308-1#c10034 Should the log file be added to the repository? Reply by Behrouz NematiPour on 24 May 2021, 14:08 > It's like running the cppcheck script that we keep the > outputs. Reply by plucia on 25 May 2021, 10:42 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/UserConfirmation.qml Revision Comment by plucia on 24 May 2021, 06:46 https://devapps.diality.us/cru/UI-DEN-8308-1#c10024 The filename needs to be updated Reply by Behrouz NematiPour on 24 May 2021, 23:44 > Updated Reply by plucia on 25 May 2021, 10:44 > RESOLVED ---------------------------------------- File: sources/model/settings/MWifiNetwork.h Revision Comment by plucia on 24 May 2021, 06:52 https://devapps.diality.us/cru/UI-DEN-8308-1#c10026 The copyright is missing Reply by Behrouz NematiPour on 24 May 2021, 23:44 > The original file didn't have the copyright so couldn't find > easily what was the actual dates, just put some dates. Bamboo > will later update the copyright with correct information. Reply by plucia on 25 May 2021, 10:45 > RESOLVED ---------------------------------------- File: sources/view/settings/VNetworkModel.cpp Revision Comment by plucia on 24 May 2021, 06:55 https://devapps.diality.us/cru/UI-DEN-8308-1#c10028 The copyright is missing Reply by Behrouz NematiPour on 24 May 2021, 23:40 > The original file didn't have the copyright. later Bamboo > will update with the correct information on top. > I updated the other two comments. Reply by plucia on 25 May 2021, 10:45 > RESOLVED ---------------------------------------- File: sources/view/settings/VNetworkModel.h Revision Comment by plucia on 24 May 2021, 06:55 https://devapps.diality.us/cru/UI-DEN-8308-1#c10029 The copyright is missing Reply by Behrouz NematiPour on 24 May 2021, 23:40 > The original file didn't have the copyright. later Bamboo > will update with the correct information on top. > I updated the other two comments. Reply by plucia on 25 May 2021, 10:43 > RESOLVED ---------------------------------------- File: sources/wifi/WifiInterface.cpp Revision Comment by plucia on 24 May 2021, 06:56 https://devapps.diality.us/cru/UI-DEN-8308-1#c10031 Copyright is missing Reply by Behrouz NematiPour on 24 May 2021, 23:37 > The original file didn't have the copyright so couldn't find > easily what was the actual dates, just put some dates. Bamboo > will later update the copyright with correct information. Reply by plucia on 25 May 2021, 10:42 > RESOLVED ---------------------------------------- File: sources/wifi/WifiInterface.h Revision Comment by plucia on 24 May 2021, 06:56 https://devapps.diality.us/cru/UI-DEN-8308-1#c10030 Copyright is missing Reply by Behrouz NematiPour on 24 May 2021, 23:38 > The original file didn't have the copyright so couldn't find > easily what was the actual dates, just put some dates. Bamboo > will later update the copyright with correct information. Reply by plucia on 25 May 2021, 10:44 > RESOLVED ---------------------------------------- File: sources/view/settings/VDateTime.cpp Revision Comment by plucia on 24 May 2021, 06:53 https://devapps.diality.us/cru/UI-DEN-8308-1#c10027 Docstring is missing Reply by Behrouz NematiPour on 24 May 2021, 23:43 > added Reply by plucia on 25 May 2021, 10:44 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/FooterStatic.qml Revision Comment by plucia on 21 May 2021, 06:58 https://devapps.diality.us/cru/UI-DEN-8308-1#c9996 This could be clearer. From just reading this it's unclear what the purpose of the footer is Reply by Behrouz NematiPour on 22 May 2021, 16:26 > Added more info. Reply by plucia on 24 May 2021, 06:45 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/TreatmentFlowBase.qml Revision Comment by plucia on 24 May 2021, 06:46 https://devapps.diality.us/cru/UI-DEN-8308-1#c10023 This filename needs to be updated Reply by Behrouz NematiPour on 24 May 2021, 23:44 > Updated Reply by plucia on 25 May 2021, 10:44 > RESOLVED ---------------------------------------- File: simulator/plugins/GeneralResponseMessage/loader.py Revision Comment by plucia on 24 May 2021, 08:01 https://devapps.diality.us/cru/UI-DEN-8308-1#c10043 The dialin usage is incorrect here. Please see my comments in the dialin code review. Reply by Behrouz NematiPour on 24 May 2021, 23:36 > It has been updated regarding our conversation. Reply by plucia on 25 May 2021, 10:40 > The dg simulator needs to be used for dg responses here > still Reply by Behrouz NematiPour on 25 May 2021, 12:04 > I don't have dg_simulator. > It would be a merge task later to merge this code into > the staging, I think it's out of the code review scope. Reply by plucia on 25 May 2021, 12:27 > From what I can tell the dg command is separated from > the hd command which is good. > Please let me know when your code is ready to be merged > to staging and I will handle it. > Also for the next feature you're working on please > branch off of the latest staging. Reply by plucia on 28 May 2021, 17:12 > RESOLVED --- ID: UI-DEN-8308-1 https://devapps.diality.us/cru/UI-DEN-8308-1 Title: UI-DEN-8308_UI DEV Treatment Log Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)