This is a list of all comments for UI-DEN-8495-1.

Review Summary: No summary


----------------------------------------
File: sources/view/hd/data/VHDOperationModeData.cpp
Revision Comment by pmontazemi on 24 May 2021, 11:16 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10063

  change (instead of changed)

  Reply by Behrouz NematiPour on 24 May 2021, 13:34
  > Updated

    Reply by pmontazemi on 25 May 2021, 09:30
    > RESOLVED.

Revision Comment by pmontazemi on 24 May 2021, 11:16 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10064

  does not (instead of doesn't)

  Reply by Behrouz NematiPour on 24 May 2021, 13:34
  > Updated

    Reply by pmontazemi on 25 May 2021, 09:30
    > RESOLVED.

Revision Comment by pmontazemi on 24 May 2021, 11:17 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10065

  remove the before anything

  Reply by Behrouz NematiPour on 24 May 2021, 13:34
  > Updated

    Reply by pmontazemi on 25 May 2021, 09:30
    > RESOLVED.

----------------------------------------
File: resources/settings/Service.conf
Revision Comment by pmontazemi on 24 May 2021, 11:12 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10062

  Add TODO

  Reply by Behrouz NematiPour on 24 May 2021, 13:35
  > Added a FIXME which is more important than TODO.
  > Updated

    Reply by pmontazemi on 25 May 2021, 09:30
    > RESOLVED.

----------------------------------------
File: sources/canbus/MessageGlobals.h
Revision Comment by plucia on 24 May 2021, 08:18 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10046

  Dialin is a known CAN source.

  Reply by Behrouz NematiPour on 24 May 2021, 08:49
  > On the UI side, we have no plan, for now, to listen to
  > Dialin.

    Reply by plucia on 24 May 2021, 09:06
    > V&V has requested to be able to get the version from the UI
    > using dialin to automate their testing

      Reply by Behrouz NematiPour on 24 May 2021, 13:37
      > As we had a conversation, the V&V request can be covered
      > in the effort of the three stacks checking their versions
      > and compatibility, then a message can be sent over the HD
      > channel.

        Reply by plucia on 25 May 2021, 10:54
        > RESOLVED

----------------------------------------
File: sources/canbus/MessageInterpreter.cpp
Revision Comment by plucia on 24 May 2021, 08:41 
https://devapps.diality.us/cru/UI-DEN-8495-1#c10051

  These definitions force dialin to talk on an HD/DG channels in
  order to simulate the UI. Seems like a security risk and that
  the UI should be able to tell the difference.

  Reply by Behrouz NematiPour on 24 May 2021, 08:50
  > If we decide UI to talk with Dialin we need to add Dialin
  > channels later, but it is not the case now.

    Reply by plucia on 24 May 2021, 08:53
    > The UI is already talking with Dialin. Your simulator is
    > using dialin to talk to the UI.
    > Because the UI doesn't recognize Dialin at all, Dialin has
    > to talk on the HD to UI or DG to UI channels instead when
    > sending up commands to the UI.
    > This poses a security risk because the UI could never
    > restrict communication to just the DG/HD only. If Dialin
    > can talk to the UI on separate channels then those channels
    > can be ignored in production mode later. 
    > 
    > It's your stack so your call but something I think we
    > should consider

      Reply by Behrouz NematiPour on 24 May 2021, 13:35
      > As we had a conversation, we will keep that in mind and
      > should see how much that affects UI for something like
      > Logging and so on.

        Reply by plucia on 25 May 2021, 10:54
        > RESOLVED


---

ID: UI-DEN-8495-1 https://devapps.diality.us/cru/UI-DEN-8495-1

Title: UI-DEN-8495_UI Dev Service Manual Disinfection & Flush
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)