This is a list of all comments for UI-DEN-9411-1. Review Summary: No summary ---------------------------------------- File: scripts/run.sh Revision Comment by pmontazemi on 12 August 2021, 10:42 https://devapps.diality.us/cru/UI-DEN-9411-1#c10632 1. Replace couldn't with could not; 2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it reflected in this code? Reply by Behrouz NematiPour on 12 August 2021, 12:51 > This is not the version of the code presented in the demo and > now it reads the actual HWClock, not the system clock is > being kept by the Linux system. > The first one was using the date which has been noted, and it > has been changed to the current implementation. Reply by pmontazemi on 30 August 2021, 08:21 > RESOLVED. ---------------------------------------- File: sources/ApplicationController.cpp Revision Comment by Sean Nash on 12 August 2021, 14:23 https://devapps.diality.us/cru/UI-DEN-9411-1#c10681 Missing brief. Reply by Behrouz NematiPour on 12 August 2021, 14:56 > Added. Reply by Sean Nash on 13 August 2021, 11:11 > RESOLVED. ---------------------------------------- File: sources/ApplicationPost.cpp Revision Comment by Sean Nash on 12 August 2021, 14:24 https://devapps.diality.us/cru/UI-DEN-9411-1#c10682 Missing brief for these methods. Reply by Behrouz NematiPour on 12 August 2021, 14:55 > Added. Reply by Sean Nash on 13 August 2021, 11:11 > RESOLVED. ---------------------------------------- File: sources/AlarmGenerator.cpp Revision Comment by Sean Nash on 12 August 2021, 14:22 https://devapps.diality.us/cru/UI-DEN-9411-1#c10680 Missing brief. Reply by Behrouz NematiPour on 12 August 2021, 14:47 > It has been removed. > We should reserve our Alarm System mostly for critical HW > issues during treatment. Reply by Sean Nash on 13 August 2021, 11:10 > RESOLVED. ---------------------------------------- File: sources/view/settings/VNetworkModel.cpp Revision Comment by Sean Nash on 12 August 2021, 14:13 https://devapps.diality.us/cru/UI-DEN-9411-1#c10678 Missing brief. Reply by Behrouz NematiPour on 12 August 2021, 14:57 > Added. Reply by Sean Nash on 13 August 2021, 11:10 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 14:13 https://devapps.diality.us/cru/UI-DEN-9411-1#c10679 Missing brief. Reply by Behrouz NematiPour on 12 August 2021, 14:57 > Added. Reply by Sean Nash on 13 August 2021, 11:10 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageDispatcher.cpp Revision Comment by Sean Nash on 12 August 2021, 13:03 https://devapps.diality.us/cru/UI-DEN-9411-1#c10652 Magic number? Reply by Behrouz NematiPour on 12 August 2021, 13:53 > Updated. Reply by Sean Nash on 12 August 2021, 14:30 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageGlobals.h Revision Comment by Sean Nash on 12 August 2021, 13:08 https://devapps.diality.us/cru/UI-DEN-9411-1#c10659 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:31 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:08 https://devapps.diality.us/cru/UI-DEN-9411-1#c10658 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:31 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:07 https://devapps.diality.us/cru/UI-DEN-9411-1#c10656 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:32 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:07 https://devapps.diality.us/cru/UI-DEN-9411-1#c10657 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:31 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:07 https://devapps.diality.us/cru/UI-DEN-9411-1#c10655 No comment? Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:32 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:06 https://devapps.diality.us/cru/UI-DEN-9411-1#c10654 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:52 > Updated. Reply by Sean Nash on 12 August 2021, 14:32 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:06 https://devapps.diality.us/cru/UI-DEN-9411-1#c10653 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:51 > Updated. Reply by Sean Nash on 12 August 2021, 14:32 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:09 https://devapps.diality.us/cru/UI-DEN-9411-1#c10660 Should this be 1 * 15 for consistency? Reply by Behrouz NematiPour on 12 August 2021, 13:34 > It has only one parameter and is 15 bytes long. > By definition, it is different than the others. > > |0x9900 |153 |0x020 |Rsp |Y |HD |UI |HD serial number |ASCII > text - 15 bytes, not null term| > |0x8800 |136 |0x070 |Rsp |Y |DG |UI |DG serial number |ASCII > text - 15 bytes, not null term| Reply by Sean Nash on 12 August 2021, 14:33 > I mean, all others appear to be in the following order: 1) > number of params and 2) size of params. > So to be consistent, shouldn't this be 1 * 15 (1 param, 15 > bytes)? Reply by Behrouz NematiPour on 12 August 2021, 14:58 > Updated. Reply by Sean Nash on 13 August 2021, 11:00 > RESOLVED. Revision Comment by Sean Nash on 12 August 2021, 13:14 https://devapps.diality.us/cru/UI-DEN-9411-1#c10661 Comment doesn't match code. Reply by Behrouz NematiPour on 12 August 2021, 13:51 > Updated. Reply by Sean Nash on 12 August 2021, 14:34 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/DebugDataColumn.qml Revision Comment by Sean Nash on 12 August 2021, 13:19 https://devapps.diality.us/cru/UI-DEN-9411-1#c10662 Why commented out? Can we remove? Reply by Behrouz NematiPour on 12 August 2021, 13:50 > Removed. Reply by Sean Nash on 12 August 2021, 14:30 > RESOLVED. ---------------------------------------- File: sources/gui/qml/dialogs/DiagnosticsDialog.qml Revision Comment by Sean Nash on 12 August 2021, 13:20 https://devapps.diality.us/cru/UI-DEN-9411-1#c10663 Why not - 40? Can we remove? Reply by Behrouz NematiPour on 12 August 2021, 13:32 > It is a red line and has already been removed. Reply by Sean Nash on 12 August 2021, 14:29 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentStack.qml Revision Comment by Sean Nash on 12 August 2021, 13:21 https://devapps.diality.us/cru/UI-DEN-9411-1#c10664 If this is test code, add TODO to remove later. Reply by Behrouz NematiPour on 12 August 2021, 13:49 > Updated. > In UI Software we also have different TODO flags like TEST, > DEBUG, FIXME, and so on. > In this case, I used TEST. Reply by Sean Nash on 12 August 2021, 14:29 > RESOLVED. --- ID: UI-DEN-9411-1 https://devapps.diality.us/cru/UI-DEN-9411-1 Title: UI-DEN-9411_UI Dev POST Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (0 active, 2 completed*) Sean Nash (*) pmontazemi (*)