This is a list of all comments for VV-DEN-1434-1.

Review Summary: No summary

General Comment by plucia on 10 June 2020, 13:19 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2218

  Looks good overall! I've added a few comments. Also to conform
  to PEP8, all folders should be lowercase_with_underscores. The
  Dialin_API folder should be renamed to dialin_scripts since the
  Dialin API is a located in a separate repository

  Reply by plucia on 12 June 2020, 17:40
  > RESOLVED

General Comment by Sarina Cheung on 11 June 2020, 13:37 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2235

  Fixed, rename directories to lowercase.

  Reply by plucia on 12 June 2020, 17:40
  > Thanks Sarina! RESOLVED


----------------------------------------
File: .gitignore
Revision Comment by plucia on 10 June 2020, 13:14 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2215

  Add *.pyc

  Reply by Sarina Cheung on 11 June 2020, 13:36
  > Fixed

    Reply by plucia on 12 June 2020, 17:41
    > RESOLVED

----------------------------------------
File: SquishQt_UI_Testing/suite_treatment_screen_py/shared/scripts/names.pyc
Revision Comment by plucia on 10 June 2020, 13:14 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2214

  Any pyc file should not be committed to the repository

  Reply by Sarina Cheung on 11 June 2020, 13:36
  > Fixed

    Reply by plucia on 12 June 2020, 17:40
    > RESOLVED

Revision Comment by pmontazemi on 11 June 2020, 15:56 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2255

  Remove file from repo.

  Reply by Sarina Cheung on 11 June 2020, 17:51
  > Fixed. Removed *.pyc from repo.

    Reply by pmontazemi on 12 June 2020, 08:05
    > RESOLVED.

----------------------------------------
File: SquishQt_UI_Testing/squishreport.sh
Revision Comment by plucia on 10 June 2020, 13:18 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2217

  Needs a script header

----------------------------------------
File: SquishQt_UI_Testing/start_squishserver.bat
Revision Comment by plucia on 10 June 2020, 13:17 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2216

  .bat a script file in DOS, OS/2 and Microsoft Windows. I think
  the filename should be .sh since this script will be run on
  linux.

  Reply by Sarina Cheung on 11 June 2020, 13:36
  > Fixed

    Reply by plucia on 12 June 2020, 17:40
    > RESOLVED

----------------------------------------
File: dialin_scripts/dg_uf_test.py_bkup
Revision Comment by pmontazemi on 11 June 2020, 15:57 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2257

  Why is this file named bkup?

  Reply by Sarina Cheung on 11 June 2020, 17:50
  > Fixed. File is moved to a branch.

    Reply by pmontazemi on 12 June 2020, 08:05
    > RESOLVED.

----------------------------------------
File: dialin_scripts/dg_uf_test.py_bkup1
Revision Comment by pmontazemi on 11 June 2020, 15:57 
https://devapps.diality.us/cru/VV-DEN-1434-1#c2258

  Why is this file named bkup?

  Reply by Sarina Cheung on 11 June 2020, 17:49
  > Fixed. File is moved to a branch.

    Reply by pmontazemi on 12 June 2020, 08:04
    > RESOLVED.


---

ID: VV-DEN-1434-1 https://devapps.diality.us/cru/VV-DEN-1434-1

Title: VV-DEN-1434_UI Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Sarina Cheung
Moderator: Sarina Cheung
Reviewers: (1 active, 3 completed*)
     Sean Nash   (*)
     plucia   (*)
     pmontazemi   (*)
     Behrouz NematiPour