Index: cppcheck.err =================================================================== diff -u -r1f2e7dbd08b00f8c56eedf29f083733570aa642e -rcf61c7736f11f4b75a4e2df803f29bdc7769db53 --- cppcheck.err (.../cppcheck.err) (revision 1f2e7dbd08b00f8c56eedf29f083733570aa642e) +++ cppcheck.err (.../cppcheck.err) (revision cf61c7736f11f4b75a4e2df803f29bdc7769db53) @@ -1,4 +1,4 @@ -02/10/2023 9:49 +05/31/2023 2:53 Behrouz NematiPour sources/canbus/MessageAcknowModel.h:58:9: performance: When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning '_sequence' a value by passing the value to the constructor in the initialization list. [useInitializationList] _sequence = vSequence ; @@ -18,32 +18,32 @@ sources/storage/FileHandler.h:102:14: note: Condition '!createFolder' is always false if ( ! createFolder ) { if ( ! dstDir.exists() ) { err = eDstFolderNotExist ; goto lErr; }} ^ -sources/ApplicationPost.cpp:111:9: style: Condition '!ok' is always false [knownConditionTrueFalse] - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_DISPLAY); +sources/ApplicationPost.cpp:113:9: style: Condition '!ok' is always false [knownConditionTrueFalse] + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_DISPLAY); ^ -sources/ApplicationPost.cpp:109:15: note: Assignment 'ok=true', assigned value is 1 +sources/ApplicationPost.cpp:111:15: note: Assignment 'ok=true', assigned value is 1 bool ok = true; ^ -sources/ApplicationPost.cpp:111:9: note: Condition '!ok' is always false - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_DISPLAY); +sources/ApplicationPost.cpp:113:9: note: Condition '!ok' is always false + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_DISPLAY); ^ -sources/ApplicationPost.cpp:206:9: style: Condition '!ok' is always false [knownConditionTrueFalse] - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_ETHERNET); +sources/ApplicationPost.cpp:208:9: style: Condition '!ok' is always false [knownConditionTrueFalse] + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_ETHERNET); ^ -sources/ApplicationPost.cpp:204:15: note: Assignment 'ok=true', assigned value is 1 +sources/ApplicationPost.cpp:206:15: note: Assignment 'ok=true', assigned value is 1 bool ok = true; ^ -sources/ApplicationPost.cpp:206:9: note: Condition '!ok' is always false - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_ETHERNET); +sources/ApplicationPost.cpp:208:9: note: Condition '!ok' is always false + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_ETHERNET); ^ -sources/ApplicationPost.cpp:220:9: style: Condition '!ok' is always false [knownConditionTrueFalse] - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_SOUND); +sources/ApplicationPost.cpp:222:9: style: Condition '!ok' is always false [knownConditionTrueFalse] + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_SOUND); ^ -sources/ApplicationPost.cpp:218:15: note: Assignment 'ok=true', assigned value is 1 +sources/ApplicationPost.cpp:220:15: note: Assignment 'ok=true', assigned value is 1 bool ok = true; ^ -sources/ApplicationPost.cpp:220:9: note: Condition '!ok' is always false - if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_UI_POST_FAILURE_SOUND); +sources/ApplicationPost.cpp:222:9: note: Condition '!ok' is always false + if (! ok) emit didFail(Gui::GuiAlarmID::ALARM_ID_HD_UI_POST_FAILURE_SOUND); ^ sources/storage/FileHandler.h:92:17: style: Local variable 'totalSize' shadows outer function [shadowFunction] qint64 totalSize = 0; @@ -102,36 +102,42 @@ When you see this message it is always safe to reduce the variable scope 1 level. [variableScope] static int oH,oM,oS; int cH,cM,cS; ^ -sources/cloudsync/CloudSyncController.cpp:396:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] +sources/cloudsync/CloudSyncController.cpp:420:13: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] buf += item.toString(); ^ -sources/cloudsync/CloudSyncController.cpp:202:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:226:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] Errors_Enum error = eError_Unknown; ^ -sources/cloudsync/CloudSyncController.cpp:226:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:250:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] Errors_Enum error = eError_Unknown; ^ -sources/cloudsync/CloudSyncController.cpp:499:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:523:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] Errors_Enum error = eError_Unknown; ^ -sources/cloudsync/CloudSyncController.cpp:548:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:572:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] Errors_Enum error = eError_Unknown; ^ -sources/cloudsync/CloudSyncController.cpp:557:51: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:581:51: style: Variable 'error' is assigned a value that is never used. [unreadVariable] if ( isDuplicate(messageID, data) ) { error = eError_Duplicate; args = { messageID }; ok = false; return ok; } // TODO: goto lErr; } don't log it just ignore and return false. ^ -sources/cloudsync/CloudSyncController.cpp:557:76: style: Variable 'args' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:581:76: style: Variable 'args' is assigned a value that is never used. [unreadVariable] if ( isDuplicate(messageID, data) ) { error = eError_Duplicate; args = { messageID }; ok = false; return ok; } // TODO: goto lErr; } don't log it just ignore and return false. ^ -sources/cloudsync/CloudSyncController.cpp:579:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] +sources/cloudsync/CloudSyncController.cpp:603:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] Errors_Enum error = eError_Unknown; ^ +sources/cloudsync/CloudSyncController.cpp:667:27: style: Variable 'error' is assigned a value that is never used. [unreadVariable] + Errors_Enum error = eError_Unknown; + ^ sources/model/MAbstractDynamic.h:80:5: warning: Member variable 'MAbstractDynamic::_data' is not initialized in the constructor. [uninitMemberVar] MAbstractDynamic () { } ^ sources/model/confirm/MDuetConfirmHDi.h:78:5: warning: Member variable 'MDuetConfirmHDi::_data' is not initialized in the constructor. [uninitMemberVar] MDuetConfirmHDi () { } ^ +sources/model/dg/adjustment/settings/MAdjustDGCleaningUsageResponse.h:99:5: warning: Member variable 'MAdjustDGCleaningUsageResponse::_data' is not initialized in the constructor. [uninitMemberVar] + MAdjustDGCleaningUsageResponse () { } + ^ sources/model/dg/adjustment/settings/MAdjustDGDateTimeResponse.h:75:5: warning: Member variable 'MAdjustDGDateTimeResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustDGDateTimeResponse () { } ^ @@ -141,13 +147,16 @@ sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.h:97:5: warning: Member variable 'MAdjustVersionsDGResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustVersionsDGResponse () { } ^ +sources/model/dg/adjustment/settings/MDuetRoWaterDG.h:120:5: warning: Member variable 'MDuetRoWaterModeDGr::_data' is not initialized in the constructor. [uninitMemberVar] + MDuetRoWaterModeDGr () { } + ^ sources/model/dg/data/MDGAccelerometerData.h:103:5: warning: Member variable 'MDGAccelerometer::_data' is not initialized in the constructor. [uninitMemberVar] MDGAccelerometer () { } ^ -sources/model/dg/data/MDGConductivityData.h:83:5: warning: Member variable 'MDGConductivityData::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/dg/data/MDGConductivityData.h:108:5: warning: Member variable 'MDGConductivityData::_data' is not initialized in the constructor. [uninitMemberVar] MDGConductivityData () { } ^ -sources/model/dg/data/MDGDrainPumpData.h:81:5: warning: Member variable 'MDGDrainPump::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/dg/data/MDGDrainPumpData.h:91:5: warning: Member variable 'MDGDrainPump::_data' is not initialized in the constructor. [uninitMemberVar] MDGDrainPump () { } ^ sources/model/dg/data/MDGHeatersData.h:102:5: warning: Member variable 'MDGHeaters::_data' is not initialized in the constructor. [uninitMemberVar] @@ -162,15 +171,18 @@ sources/model/dg/data/MDGPressuresData.h:84:5: warning: Member variable 'MDGPressures::_data' is not initialized in the constructor. [uninitMemberVar] MDGPressures () {} ^ -sources/model/dg/data/MDGROPumpData.h:81:5: warning: Member variable 'MDGROPump::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/dg/data/MDGROPumpData.h:87:5: warning: Member variable 'MDGROPump::_data' is not initialized in the constructor. [uninitMemberVar] MDGROPump () { } ^ -sources/model/dg/data/MDGReservoirData.h:78:5: warning: Member variable 'MDGReservoir::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/dg/data/MDGReservoirData.h:113:5: warning: Member variable 'MDGReservoir::_data' is not initialized in the constructor. [uninitMemberVar] MDGReservoir () {} ^ sources/model/dg/data/MDGTemperaturesData.h:136:5: warning: Member variable 'MDGTemperatures::_data' is not initialized in the constructor. [uninitMemberVar] MDGTemperatures() { } ^ +sources/model/dg/data/MDGValvesStatesData.h:135:5: warning: Member variable 'MDGValvesStates::_data' is not initialized in the constructor. [uninitMemberVar] + MDGValvesStates () { } + ^ sources/model/dg/data/post/MDGPostFinalResultData.h:74:5: warning: Member variable 'MDGPostFinalResult::_data' is not initialized in the constructor. [uninitMemberVar] MDGPostFinalResult() {} ^ @@ -204,7 +216,7 @@ sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustInitTreatmentResponse.h:75:5: warning: Member variable 'MAdjustInitTreatmentResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustInitTreatmentResponse () {} ^ -sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustParametersValidationResponse.h:124:5: warning: Member variable 'MAdjustParametersValidationResponse::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustParametersValidationResponse.h:121:5: warning: Member variable 'MAdjustParametersValidationResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustParametersValidationResponse () {} ^ sources/model/hd/adjustment/pretreatment/MPreTreatmentAdjustPatientConnectionBeginResponse.h:77:5: warning: Member variable 'MAdjustPatientConnectionBeginResponse::_data' is not initialized in the constructor. [uninitMemberVar] @@ -249,7 +261,7 @@ sources/model/hd/adjustment/treatment/MTreatmentAdjustHeparinResponse.h:77:5: warning: Member variable 'MAdjustHeparinResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustHeparinResponse () { } ^ -sources/model/hd/adjustment/treatment/MTreatmentAdjustPressuresLimitsResponse.h:89:5: warning: Member variable 'MAdjustPressuresLimitsResponse::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/adjustment/treatment/MTreatmentAdjustPressuresLimitsResponse.h:86:5: warning: Member variable 'MAdjustPressuresLimitsResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustPressuresLimitsResponse () { } ^ sources/model/hd/adjustment/treatment/MTreatmentAdjustRecirculateResponse.h:77:5: warning: Member variable 'MAdjustRecirculateResponse::_data' is not initialized in the constructor. [uninitMemberVar] @@ -264,7 +276,7 @@ sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:82:5: warning: Member variable 'MAdjustUltrafiltrationConfirmResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustUltrafiltrationConfirmResponse () { } ^ -sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:82:5: warning: Member variable 'MAdjustUltrafiltrationEditResponse::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:85:5: warning: Member variable 'MAdjustUltrafiltrationEditResponse::_data' is not initialized in the constructor. [uninitMemberVar] MAdjustUltrafiltrationEditResponse () { } ^ sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67:14: warning: The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name 'stringPrefix' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [duplInheritedMember] @@ -276,13 +288,13 @@ sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67:14: note: Derived variable 'MAdjustUltrafiltrationEditResponse::stringPrefix' QString stringPrefix = "AdjustUFEdit"; ^ -sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79:7: warning: The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [duplInheritedMember] +sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:82:7: warning: The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [duplInheritedMember] } _data; ^ sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:79:7: note: Parent variable 'MAdjustUltrafiltrationConfirmResponse::_data' } _data; ^ -sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79:7: note: Derived variable 'MAdjustUltrafiltrationEditResponse::_data' +sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:82:7: note: Derived variable 'MAdjustUltrafiltrationEditResponse::_data' } _data; ^ sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationStateResponse.h:78:5: warning: Member variable 'MAdjustUltrafiltrationStateResponse::_data' is not initialized in the constructor. [uninitMemberVar] @@ -321,7 +333,7 @@ sources/model/hd/data/MHDAirTrapData.h:77:5: warning: Member variable 'MHDAirTrapData::_data' is not initialized in the constructor. [uninitMemberVar] MHDAirTrapData () { } ^ -sources/model/hd/data/MHDBloodLeakData.h:102:5: warning: Member variable 'MHDBloodLeakData::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/MHDBloodLeakData.h:77:5: warning: Member variable 'MHDBloodLeakData::_data' is not initialized in the constructor. [uninitMemberVar] MHDBloodLeakData () { } ^ sources/model/hd/data/MHDOperationModeData.h:75:5: warning: Member variable 'MHDOperationMode::_data' is not initialized in the constructor. [uninitMemberVar] @@ -339,7 +351,7 @@ sources/model/hd/data/post/MHDPostSingleResultData.h:77:5: warning: Member variable 'MHDPostSingleResult::_data' is not initialized in the constructor. [uninitMemberVar] MHDPostSingleResult() {} ^ -sources/model/hd/data/posttreatment/MPostTreatmentStatesData.h:74:5: warning: Member variable 'MPostTreatmentStates::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/posttreatment/MPostTreatmentStatesData.h:77:5: warning: Member variable 'MPostTreatmentStates::_data' is not initialized in the constructor. [uninitMemberVar] MPostTreatmentStates() { } ^ sources/model/hd/data/pretreatment/MPreTreatmentDisposablesPrimeData.h:72:5: warning: Member variable 'MPreTreatmentDisposablesPrime::_data' is not initialized in the constructor. [uninitMemberVar] @@ -354,22 +366,22 @@ sources/model/hd/data/pretreatment/MPreTreatmentStatesData.h:111:5: warning: Member variable 'MPreTreatmentStates::_data' is not initialized in the constructor. [uninitMemberVar] MPreTreatmentStates() { } ^ -sources/model/hd/data/treatment/MTreatmentBloodFlowData.h:90:5: warning: Member variable 'MBloodFlow::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentBloodFlowData.h:93:5: warning: Member variable 'MBloodFlow::_data' is not initialized in the constructor. [uninitMemberVar] MBloodFlow() { } ^ -sources/model/hd/data/treatment/MTreatmentBloodPrimeData.h:77:5: warning: Member variable 'MTreatmentBloodPrime::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentBloodPrimeData.h:76:5: warning: Member variable 'MTreatmentBloodPrime::_data' is not initialized in the constructor. [uninitMemberVar] MTreatmentBloodPrime () { } ^ -sources/model/hd/data/treatment/MTreatmentDialysateFlowData.h:89:5: warning: Member variable 'MDialysateFlow::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentDialysateFlowData.h:95:5: warning: Member variable 'MDialysateFlow::_data' is not initialized in the constructor. [uninitMemberVar] MDialysateFlow() { } ^ sources/model/hd/data/treatment/MTreatmentHeparinData.h:78:5: warning: Member variable 'MTreatmentHeparin::_data' is not initialized in the constructor. [uninitMemberVar] MTreatmentHeparin () { } ^ -sources/model/hd/data/treatment/MTreatmentOutletFlowData.h:90:5: warning: Member variable 'MOutletFlow::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentOutletFlowData.h:99:5: warning: Member variable 'MOutletFlow::_data' is not initialized in the constructor. [uninitMemberVar] MOutletFlow () { } ^ -sources/model/hd/data/treatment/MTreatmentPressureOcclusionData.h:84:5: warning: Member variable 'MPressureOcclusion::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentPressureOcclusionData.h:93:5: warning: Member variable 'MPressureOcclusion::_data' is not initialized in the constructor. [uninitMemberVar] MPressureOcclusion () { } ^ sources/model/hd/data/treatment/MTreatmentRecirculateData.h:78:5: warning: Member variable 'MTreatmentRecirculate::_data' is not initialized in the constructor. [uninitMemberVar] @@ -381,7 +393,7 @@ sources/model/hd/data/treatment/MTreatmentSalineData.h:81:5: warning: Member variable 'MTreatmentSaline::_data' is not initialized in the constructor. [uninitMemberVar] MTreatmentSaline () { } ^ -sources/model/hd/data/treatment/MTreatmentStatesData.h:109:5: warning: Member variable 'MTreatmentStates::_data' is not initialized in the constructor. [uninitMemberVar] +sources/model/hd/data/treatment/MTreatmentStatesData.h:110:5: warning: Member variable 'MTreatmentStates::_data' is not initialized in the constructor. [uninitMemberVar] MTreatmentStates() { } ^ sources/model/hd/data/treatment/MTreatmentStopData.h:76:5: warning: Member variable 'MTreatmentStop::_data' is not initialized in the constructor. [uninitMemberVar] @@ -435,31 +447,31 @@ When you see this message it is always safe to reduce the variable scope 1 level. [variableScope] static bool notified = false; ^ -sources/storage/TreatmentLog.cpp:467:10: style: Condition '!ok' is always false [knownConditionTrueFalse] +sources/storage/TreatmentLog.cpp:487:10: style: Condition '!ok' is always false [knownConditionTrueFalse] if ( ! ok ) { ^ -sources/storage/TreatmentLog.cpp:461:10: note: Assuming that condition '!ok' is not redundant +sources/storage/TreatmentLog.cpp:481:10: note: Assuming that condition '!ok' is not redundant if ( ! ok ) { ^ -sources/storage/TreatmentLog.cpp:467:10: note: Condition '!ok' is always false +sources/storage/TreatmentLog.cpp:487:10: note: Condition '!ok' is always false if ( ! ok ) { ^ -sources/storage/TreatmentLog.cpp:90:41: style: Variable 'mTreatmentDurationFmt' is assigned a value that is never used. [unreadVariable] +sources/storage/TreatmentLog.cpp:92:41: style: Variable 'mTreatmentDurationFmt' is assigned a value that is never used. [unreadVariable] QString mTreatmentDurationFmt = QTime (0, 0).addSecs(int(vData.mTreatmentDuration )).toString(_timeFormat); ^ -sources/storage/TreatmentLog.cpp:91:41: style: Variable 'mActualTreatmentDurationFmt' is assigned a value that is never used. [unreadVariable] +sources/storage/TreatmentLog.cpp:93:41: style: Variable 'mActualTreatmentDurationFmt' is assigned a value that is never used. [unreadVariable] QString mActualTreatmentDurationFmt = QTime (0, 0).addSecs(int(vData.mActualTreatmentDuration )).toString(_timeFormat); ^ sources/utility/format.cpp:98:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] mData += fromVariant(item); ^ -sources/view/settings/VNetworkModel.cpp:264:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] +sources/view/settings/VNetworkModel.cpp:262:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] { ^ -sources/view/settings/VNetworkModel.cpp:282:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] +sources/view/settings/VNetworkModel.cpp:280:9: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm] { ^ -sources/view/settings/VSettings.cpp:164:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] +sources/view/settings/VSettings.cpp:184:17: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] keyList += keys.join(""); ^ unittests/tst_messaging.cpp:294:18: style: Variable 'msg.actionId' is reassigned a value before the old one has been used. [redundantAssignment] @@ -474,6 +486,9 @@ unittests/tst_views.cpp:711:26: style: Variable 'action' is assigned a value that is never used. [unreadVariable] GuiActionType action = GuiActionType::ID_AdjustParametersValidationRsp; ^ +sources/AlarmGenerator.cpp:72:0: style: The function 'ALARM_ID_UI_POST_FAILURE_SDCARD' is never used. [unusedFunction] + +^ unittests/tst_views.cpp:406:0: style: The function 'VCreateTreatment_check_init' is never used. [unusedFunction] ^ @@ -519,39 +534,48 @@ sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentPatientConnectionBegin.cpp:49:0: style: The function 'doBegin' is never used. [unusedFunction] ^ -sources/view/VTreatmentCreate.cpp:83:0: style: The function 'doCancel' is never used. [unusedFunction] +sources/view/VTreatmentCreate.cpp:82:0: style: The function 'doCancel' is never used. [unusedFunction] ^ -sources/view/settings/VNetworkModel.cpp:245:0: style: The function 'doCheckIfConnected' is never used. [unusedFunction] +sources/view/settings/VNetworkModel.cpp:243:0: style: The function 'doCheckIfConnected' is never used. [unusedFunction] ^ sources/view/hd/alarm/VAlarmStatus.cpp:95:0: style: The function 'doClearCondition' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:89:0: style: The function 'doDisinfectCancel' is never used. [unusedFunction] +sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:83:0: style: The function 'doConfirmDisconnect' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:137:0: style: The function 'doDisinfectChemFlush' is never used. [unusedFunction] +sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:59:0: style: The function 'doConfirmReconnect' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:128:0: style: The function 'doDisinfectChemical' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:90:0: style: The function 'doDisinfectCancel' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:100:0: style: The function 'doDisinfectClear' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:138:0: style: The function 'doDisinfectChemFlush' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:142:0: style: The function 'doDisinfectConfirm' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:129:0: style: The function 'doDisinfectChemical' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:110:0: style: The function 'doDisinfectFlush' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:101:0: style: The function 'doDisinfectClear' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:119:0: style: The function 'doDisinfectHeat' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:152:0: style: The function 'doDisinfectConfirm' is never used. [unusedFunction] ^ -sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:77:0: style: The function 'doDisinfectInitiate' is never used. [unusedFunction] +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:111:0: style: The function 'doDisinfectFlush' is never used. [unusedFunction] ^ +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:120:0: style: The function 'doDisinfectHeat' is never used. [unusedFunction] + +^ +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:78:0: style: The function 'doDisinfectInitiate' is never used. [unusedFunction] + +^ +sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.cpp:147:0: style: The function 'doDisinfectROPermeate' is never used. [unusedFunction] + +^ sources/gui/GuiView.cpp:250:0: style: The function 'doExportListInsert' is never used. [unusedFunction] ^ @@ -612,16 +636,16 @@ sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentWaterSample.cpp:51:0: style: The function 'doSample' is never used. [unusedFunction] ^ -sources/view/settings/VNetworkModel.cpp:369:0: style: The function 'doSetDNS' is never used. [unusedFunction] +sources/view/settings/VNetworkModel.cpp:367:0: style: The function 'doSetDNS' is never used. [unusedFunction] ^ -sources/view/settings/VNetworkModel.cpp:351:0: style: The function 'doSetGateway' is never used. [unusedFunction] +sources/view/settings/VNetworkModel.cpp:349:0: style: The function 'doSetGateway' is never used. [unusedFunction] ^ -sources/view/settings/VNetworkModel.cpp:342:0: style: The function 'doSetIPAddress' is never used. [unusedFunction] +sources/view/settings/VNetworkModel.cpp:340:0: style: The function 'doSetIPAddress' is never used. [unusedFunction] ^ -sources/view/settings/VNetworkModel.cpp:360:0: style: The function 'doSetSubnetMask' is never used. [unusedFunction] +sources/view/settings/VNetworkModel.cpp:358:0: style: The function 'doSetSubnetMask' is never used. [unusedFunction] ^ sources/view/hd/alarm/VAlarmStatus.cpp:78:0: style: The function 'doSilence' is never used. [unusedFunction] @@ -663,6 +687,12 @@ sources/view/hd/alarm/VAlarmStatus.cpp:201:0: style: The function 'instructionValues' is never used. [unusedFunction] ^ +sources/view/settings/VSettings.cpp:286:0: style: The function 'isPasswordMatch' is never used. [unusedFunction] + +^ +sources/view/settings/VSettings.cpp:241:0: style: The function 'isPasswordValid' is never used. [unusedFunction] + +^ unittests/tst_logging.cpp:66:0: style: The function 'logDatum' is never used. [unusedFunction] ^ @@ -684,7 +714,7 @@ unittests/tst_logging.cpp:82:0: style: The function 'logUnknown' is never used. [unusedFunction] ^ -sources/bluetooth/BluetoothInterface.cpp:1159:0: style: The function 'mimic' is never used. [unusedFunction] +sources/bluetooth/BluetoothInterface.cpp:1207:0: style: The function 'mimic' is never used. [unusedFunction] ^ sources/storage/FileHandler.cpp:167:0: style: The function 'moveFolder' is never used. [unusedFunction] @@ -699,13 +729,13 @@ sources/storage/FileHandler.cpp:188:0: style: The function 'removeFolder' is never used. [unusedFunction] ^ -sources/bluetooth/BluetoothInterface.cpp:1239:0: style: The function 'requestBattery' is never used. [unusedFunction] +sources/bluetooth/BluetoothInterface.cpp:1287:0: style: The function 'requestBattery' is never used. [unusedFunction] ^ -sources/bluetooth/BluetoothInterface.cpp:1226:0: style: The function 'requestInformation' is never used. [unusedFunction] +sources/bluetooth/BluetoothInterface.cpp:1274:0: style: The function 'requestInformation' is never used. [unusedFunction] ^ -sources/bluetooth/BluetoothInterface.cpp:1207:0: style: The function 'requestMeasurements' is never used. [unusedFunction] +sources/bluetooth/BluetoothInterface.cpp:1255:0: style: The function 'requestMeasurements' is never used. [unusedFunction] ^ sources/view/settings/VBluetooth.cpp:79:0: style: The function 'roleNames' is never used. [unusedFunction] @@ -1278,5 +1308,11 @@ unittests/tst_utilities.cpp:204:0: style: The function 'tst_toStringList_RemoveDuplicate' is never used. [unusedFunction] ^ +sources/view/settings/VSettings.cpp:290:0: style: The function 'updatePassword' is never used. [unusedFunction] + +^ +sources/wifi/WifiInterface.cpp:936:0: style: The function 'variantListToSecurityTypes' is never used. [unusedFunction] + +^ nofile:0:0: information: Cppcheck cannot find all the include files. Cppcheck can check the code without the include files found. But the results will probably be more accurate if all the include files are found. Please check your project's include directories and add all of them as include directories for Cppcheck. To see what files Cppcheck cannot find use --check-config. [missingInclude]