Index: cppcheck.err =================================================================== diff -u -r365071735de19125835b4b35a784e31eaae81bf9 -r7e503c5459ec77a2816d6c7789da9b206cedbe8a --- cppcheck.err (.../cppcheck.err) (revision 365071735de19125835b4b35a784e31eaae81bf9) +++ cppcheck.err (.../cppcheck.err) (revision 7e503c5459ec77a2816d6c7789da9b206cedbe8a) @@ -1,6 +1,6 @@ -[sources/ApplicationPost.cpp:104] -> [sources/ApplicationPost.cpp:106]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:183] -> [sources/ApplicationPost.cpp:185]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:197] -> [sources/ApplicationPost.cpp:199]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:107] -> [sources/ApplicationPost.cpp:109]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:186] -> [sources/ApplicationPost.cpp:188]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:200] -> [sources/ApplicationPost.cpp:202]: (style) Condition '!ok' is always false [sources/MainTimer.cpp:69]: (style) The scope of the variable 'oH' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced: void f(int x) { @@ -40,11 +40,12 @@ } } When you see this message it is always safe to reduce the variable scope 1 level. -[sources/cloudsync/CloudSyncController.cpp:485] -> [sources/cloudsync/CloudSyncController.cpp:493]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:632] -> [sources/cloudsync/CloudSyncController.cpp:633]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:659] -> [sources/cloudsync/CloudSyncController.cpp:660]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:725] -> [sources/cloudsync/CloudSyncController.cpp:726]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:814] -> [sources/cloudsync/CloudSyncController.cpp:815]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:489] -> [sources/cloudsync/CloudSyncController.cpp:497]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:651] -> [sources/cloudsync/CloudSyncController.cpp:652]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:662] -> [sources/cloudsync/CloudSyncController.cpp:664]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:690] -> [sources/cloudsync/CloudSyncController.cpp:691]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:780] -> [sources/cloudsync/CloudSyncController.cpp:781]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:869] -> [sources/cloudsync/CloudSyncController.cpp:870]: (style) Variable 'ok' is reassigned a value before the old one has been used. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:61]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name 'stringPrefix' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:79]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/storage/Settings.h:44]: (style) Unused private function: 'Settings::makeSetting'