Index: cppcheck.err =================================================================== diff -u -r7e503c5459ec77a2816d6c7789da9b206cedbe8a -r41733a7b1d156427923a8d0cf61fa0a4315e9725 --- cppcheck.err (.../cppcheck.err) (revision 7e503c5459ec77a2816d6c7789da9b206cedbe8a) +++ cppcheck.err (.../cppcheck.err) (revision 41733a7b1d156427923a8d0cf61fa0a4315e9725) @@ -40,15 +40,16 @@ } } When you see this message it is always safe to reduce the variable scope 1 level. -[sources/cloudsync/CloudSyncController.cpp:489] -> [sources/cloudsync/CloudSyncController.cpp:497]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:651] -> [sources/cloudsync/CloudSyncController.cpp:652]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:662] -> [sources/cloudsync/CloudSyncController.cpp:664]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:690] -> [sources/cloudsync/CloudSyncController.cpp:691]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:780] -> [sources/cloudsync/CloudSyncController.cpp:781]: (style) Variable 'ok' is reassigned a value before the old one has been used. -[sources/cloudsync/CloudSyncController.cpp:869] -> [sources/cloudsync/CloudSyncController.cpp:870]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:493] -> [sources/cloudsync/CloudSyncController.cpp:501]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:655] -> [sources/cloudsync/CloudSyncController.cpp:656]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:666] -> [sources/cloudsync/CloudSyncController.cpp:668]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:694] -> [sources/cloudsync/CloudSyncController.cpp:695]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:805] -> [sources/cloudsync/CloudSyncController.cpp:806]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/cloudsync/CloudSyncController.cpp:894] -> [sources/cloudsync/CloudSyncController.cpp:895]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/device/DeviceController.cpp:327] -> [sources/device/DeviceController.cpp:329]: (style) Variable 'mCIsReady' is reassigned a value before the old one has been used. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:61]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name 'stringPrefix' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:79]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. -[sources/storage/Settings.h:44]: (style) Unused private function: 'Settings::makeSetting' +[sources/storage/Settings.h:48]: (style) Unused private function: 'Settings::makeSetting' [sources/view/VEventSpy.cpp]: (information) The configuration 'DEBUG_BCUFF_MIMIC' was not checked because its code equals another one. [sources/view/VTreatmentCreate.cpp:132]: (style) The function 'doCancel' is never used. [sources/view/settings/VNetworkModel.cpp:238]: (style) The function 'doCheckIfConnected' is never used. @@ -61,11 +62,11 @@ [sources/view/VTreatmentCreate(legacy).cpp:487]: (style) The function 'doGetPrescriptionParameterNames' is never used. [sources/view/VTreatmentCreate(legacy).cpp:504]: (style) The function 'doGetPrescriptionParameterValues' is never used. [sources/view/settings/VDateTime.cpp:44]: (style) The function 'doInit' is never used. -[sources/view/VEventSpy.cpp:147]: (style) The function 'doMouseReset' is never used. +[sources/view/VEventSpy.cpp:149]: (style) The function 'doMouseReset' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp:66]: (style) The function 'doOptionDuration' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:51]: (style) The function 'doReconnect' is never used. [sources/view/hd/alarm/VAlarmActiveList.cpp:106]: (style) The function 'doRequest' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:113]: (style) The function 'doReset' is never used. +[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:98]: (style) The function 'doReset' is never used. [sources/view/VTreatmentCreate(legacy).cpp:111]: (style) The function 'doResetCreateTreatment' is never used. [sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentWaterSample.cpp:64]: (style) The function 'doResult' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentHeparin.cpp:51]: (style) The function 'doResume' is never used. @@ -74,10 +75,9 @@ [sources/view/settings/VNetworkModel.cpp:335]: (style) The function 'doSetIPAddress' is never used. [sources/view/settings/VNetworkModel.cpp:353]: (style) The function 'doSetSubnetMask' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:76]: (style) The function 'doSilence' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:93]: (style) The function 'doSkip' is never used. +[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:86]: (style) The function 'doSkip' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentSaline.cpp:58]: (style) The function 'doStop' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:102]: (style) The function 'doTimeout' is never used. -[sources/view/VEventSpy.cpp:190]: (style) The function 'doTouchReset' is never used. +[sources/view/VEventSpy.cpp:192]: (style) The function 'doTouchReset' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:75]: (style) The function 'doTreatmentEnd' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:55]: (style) The function 'doUserActionEnd' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:65]: (style) The function 'doUserActionOk' is never used.