Index: cppcheck.err =================================================================== diff -u -rb238ed3e1aa94f5c03d4e1a6ed6c9fdfdd2a3cb5 -r16bd55822fa77e5bea6fdfa7b54abf123c1da8bb --- cppcheck.err (.../cppcheck.err) (revision b238ed3e1aa94f5c03d4e1a6ed6c9fdfdd2a3cb5) +++ cppcheck.err (.../cppcheck.err) (revision 16bd55822fa77e5bea6fdfa7b54abf123c1da8bb) @@ -51,7 +51,10 @@ [sources/device/DeviceController.cpp:311] -> [sources/device/DeviceController.cpp:313]: (style) Variable 'mCIsReady' is reassigned a value before the old one has been used. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:61]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name 'stringPrefix' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:79]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. -[sources/storage/Logger.cpp:188]: (style) The scope of the variable 'notified' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced: +[sources/model/settings/MSettings.h:56]: (style) The KeyValue::operator= does not conform to standard C/C++ behaviour. To conform to standard C/C++ behaviour, return a reference to self (such as: 'KeyValue &KeyValue::operator=(..) { .. return *this; }'. For safety reasons it might be better to not fix this message. If you think that safety is always more important than conformance then please ignore/suppress this message. For more details about this topic, see the book "Effective C++" by Scott Meyers. +[sources/model/settings/MSettings.h:44]: (warning) The class 'KeyValue' has 'operator=' but lack of 'copy constructor'. +[sources/storage/Logger.cpp:259] -> [sources/storage/Logger.cpp:261]: (style) Variable 'ok' is reassigned a value before the old one has been used. +[sources/storage/Logger.cpp:189]: (style) The scope of the variable 'notified' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced: void f(int x) { int i = 0; @@ -64,7 +67,6 @@ } } When you see this message it is always safe to reduce the variable scope 1 level. -[sources/storage/Logger.cpp]: (information) The configuration 'MIXED_EVENT_DATUM' was not checked because its code equals another one. [sources/view/VEventSpy.cpp]: (information) The configuration 'DEBUG_BCUFF_MIMIC' was not checked because its code equals another one. [sources/view/VTreatmentCreate.cpp:132]: (style) The function 'doCancel' is never used. [sources/view/settings/VNetworkModel.cpp:238]: (style) The function 'doCheckIfConnected' is never used.