Index: sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.cpp =================================================================== diff -u -r2ef03b2ce51b4dc507f66e9671953a8e0824bde9 -ra09c1a91b8eaf9d7164ba7f274d4ccd557c05f22 --- sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.cpp (.../MAdjustDGVersionsResponse.cpp) (revision 2ef03b2ce51b4dc507f66e9671953a8e0824bde9) +++ sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.cpp (.../MAdjustDGVersionsResponse.cpp) (revision a09c1a91b8eaf9d7164ba7f274d4ccd557c05f22) @@ -32,25 +32,22 @@ bool MAdjustVersionsDGResponse::fromByteArray(const QByteArray &vByteArray, int *vIndex) { int index = 0; // message data start position - if (GetValue(vByteArray, index, _data.mMajor )) - if (GetValue(vByteArray, index, _data.mMinor )) - if (GetValue(vByteArray, index, _data.mMicro )) - if (GetValue(vByteArray, index, _data.mBuild )) - if (GetValue(vByteArray, index, _data.mFPGAId )) - if (GetValue(vByteArray, index, _data.mFPGAMajor )) - if (GetValue(vByteArray, index, _data.mFPGAMinor )) - if (GetValue(vByteArray, index, _data.mFPGALab )) - if (GetValue(vByteArray, index, _data.mCompatibilityRev )) - return true ; - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } - else { if(vIndex) *vIndex = index; return false; } + if ( ! GetValue(vByteArray, index, _data.mMajor )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mMinor )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mMicro )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mBuild )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mFPGAId )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mFPGAMajor )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mFPGAMinor )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mFPGALab )) goto lError; + if ( ! GetValue(vByteArray, index, _data.mCompatibilityRev )) goto lError; + + return true ; + +lError: + if(vIndex) { *vIndex = index; } + + return false; } AdjustVersionsDGResponseData MAdjustVersionsDGResponse::data() const {