Index: sources/ApplicationController.cpp =================================================================== diff -u -r0b9adc7308a25148a2704bc0bf4f08373acee8b7 -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/ApplicationController.cpp (.../ApplicationController.cpp) (revision 0b9adc7308a25148a2704bc0bf4f08373acee8b7) +++ sources/ApplicationController.cpp (.../ApplicationController.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -660,8 +660,13 @@ _post.start(); } +/*! + * \brief ApplicationController::onCryptSetupMount + * \details It is the slot to handle _DeviceController::didCryptSetupMount signal. + * Tels the settings start initate. + */ void ApplicationController::onCryptSetupMount(bool /*vPass*/) { - // if ( vPass ) // in needs more investigation + // if ( vPass ) // it needs more investigation initSettings(); } Index: sources/canbus/MessageInterpreter.cpp =================================================================== diff -u -r9c7a790376d07de7ddaa67e39d47102d68693c87 -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/canbus/MessageInterpreter.cpp (.../MessageInterpreter.cpp) (revision 9c7a790376d07de7ddaa67e39d47102d68693c87) +++ sources/canbus/MessageInterpreter.cpp (.../MessageInterpreter.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -211,9 +211,9 @@ if ( length ) { // this message has a variable length vPayload = Format::fromVariant(vData.first()); } - if ( ! gDisableCheckInLog ) + if ( ! gDisableCheckInLog ) { LOG_APPED_UI(QString("CheckIn")); - + } break; case Gui::GuiActionType::ID_RawData: // len: 255, can have any len @@ -222,6 +222,7 @@ } LOG_APPED_UI(QString("RawData")); break; + // Generic Confirm case Gui::GuiActionType::ID_DuetConfirmUIr : INTERPRET_TRANSMIT_MESSAGE(DuetConfirmUIrData ); break; // RO Water Index: sources/device/DeviceController.cpp =================================================================== diff -u -r7fb3037f90ac302238f618243a137bee1653ca2b -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/device/DeviceController.cpp (.../DeviceController.cpp) (revision 7fb3037f90ac302238f618243a137bee1653ca2b) +++ sources/device/DeviceController.cpp (.../DeviceController.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -797,11 +797,23 @@ checkConfugurationMountReady(); } +/*! + * \brief DeviceController::onPOSTEthernetData + * \details Collects the ethernet mac address + * when it is ready after the POST is done for the Ethernet + * \param vMacAddress - The Ethernet MAC address + */ void DeviceController::onPOSTEthernetData(const QString &vMacAddress) { _macEthernet = vMacAddress; emit didPOSTEthernetData (vMacAddress); } +/*! + * \brief DeviceController::onPOSTWirelessData + * \details Collects the wireless mac address + * when it is ready after the POST is done for the Wireless connection + * \param vMacAddress - The Wireless MAC address + */ void DeviceController::onPOSTWirelessData(const QString &vMacAddress) { _macWireless = vMacAddress; @@ -812,11 +824,23 @@ emit didPOSTWirelessData (vMacAddress); } +/*! + * \brief DeviceController::onPOSTBluetoothData + * \details Collects the bluetooth mac address + * when it is ready after the POST is done for the Bluetooth + * \param vMacAddress - The Bluetooth MAC address + */ void DeviceController::onPOSTBluetoothData(const QString &vMacAddress) { _macBluetooth = vMacAddress; emit didPOSTBluetoothData (vMacAddress); } +/*! + * \brief DeviceController::onPOSTCloudSyncData + * \details Collects the CloudSync Network Address + * when it is ready after the POST is done for the CloudSync + * \param vNetAddress - *** Not defined yet and is a placeholder for later use *** + */ void DeviceController::onPOSTCloudSyncData(const QString &vNetAddress) { _netCloudSync = vNetAddress; emit didPOSTCloudSyncData (vNetAddress); @@ -992,7 +1016,7 @@ } /*! - * \brief DeviceController::onProcessFactoryResetExitCode + * \brief DeviceController::onProcessUSBMountExitCode * \param vExitCode * \param vStatus */ Index: sources/device/DeviceView.h =================================================================== diff -u -r4ef7cb77805b64ac89966a9581cdc111520f21d1 -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/device/DeviceView.h (.../DeviceView.h) (revision 4ef7cb77805b64ac89966a9581cdc111520f21d1) +++ sources/device/DeviceView.h (.../DeviceView.h) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -63,7 +63,7 @@ private: bool isCompleteResponse(Model::MDeviceResponseBase::Data vData) { // Either the script exited successfully or the script failed and the reason is provided - // There are situaltoins that the script is using the attribute response to update the UI + // There are situations that the script is using the attribute response to update the UI // but it is not the final/completed response return vData.mAccepted || (!vData.mAccepted && vData.mReason != 0 ); } Index: sources/storage/FileHandler.cpp =================================================================== diff -u -r1f5b2250ae70d305654d014a9aa1fd8baa29779c -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/storage/FileHandler.cpp (.../FileHandler.cpp) (revision 1f5b2250ae70d305654d014a9aa1fd8baa29779c) +++ sources/storage/FileHandler.cpp (.../FileHandler.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -292,7 +292,7 @@ /*! * \brief FileHandler::tmpUsable - * \details Checks if the temp folder is availabel for read and write to file and directory + * \details Checks if the temp folder is available for read and write to file and directory * \note This function will only chek the temp folder usability once * and next call will just return the first result, * assuming that the temp file situation is not going to change and is stable. Index: sources/storage/Logger.cpp =================================================================== diff -u -r86a8bf85503555e814b049a30f2759501d785315 -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/storage/Logger.cpp (.../Logger.cpp) (revision 86a8bf85503555e814b049a30f2759501d785315) +++ sources/storage/Logger.cpp (.../Logger.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -224,7 +224,7 @@ _dir.setPath(Storage::Standard_tmp); // NOTE: Do not use LOG_XXXXX, At this moment Logger has not been initialized yet QString msg = QString("temp location used for events logging (%1)").arg(_dir.path()); - qDebug() << msg; + //DEBUG qDebug() << msg; FileHandler::errOut(msg); } else { @@ -245,6 +245,13 @@ return ok; } +/*! + * \brief Logger::onCryptSetupMount + * \details the handlet for the _DeviceController::didCryptSetupMount + * to set the treatment fodler when the encrypted parttion is ready + * and successfully decrypted and mounted. + * It checks to make sure the folder exist and is able to be written and read. + */ void Logger::onCryptSetupMount(bool /*vPass*/) { LogType vLogType = LogType::eLogTrtmt; Index: sources/storage/Settings.cpp =================================================================== diff -u -r1f5b2250ae70d305654d014a9aa1fd8baa29779c -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/storage/Settings.cpp (.../Settings.cpp) (revision 1f5b2250ae70d305654d014a9aa1fd8baa29779c) +++ sources/storage/Settings.cpp (.../Settings.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -61,7 +61,7 @@ QStringList settingFolders = FileHandler::subFolders(Storage::Settings_Path()); if ( ! settingFolders.count() ) { - err = Settings::Settings_Error::eError_No_SettingFolder; + err = Settings::Settings_Error::eError_No_SettingsFolder; LOG_DEBUG(errorMessage(err).arg(Storage::Settings_Path())); return err; } @@ -77,7 +77,7 @@ // QFileInfo("/home/denali/Projects/application/resources/settings/Alarms/Alarms.conf") // }; if ( ! settingFiles.count() ) { - err = Settings::Settings_Error::eError_No_SettingFile; + err = Settings::Settings_Error::eError_No_SettingsFile; LOG_DEBUG(errorMessage(err).arg(Storage::Settings_Path())); return err; } @@ -241,6 +241,6 @@ Storage::Settings_Secured(); lOut: - if ( vMessage ) *vMessage = msg; + if ( vMessage ) { *vMessage = msg; } return err; } Index: sources/storage/Settings.h =================================================================== diff -u -r389f028cb9d4d320eae393de7c4408a58a619356 -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/storage/Settings.h (.../Settings.h) (revision 389f028cb9d4d320eae393de7c4408a58a619356) +++ sources/storage/Settings.h (.../Settings.h) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -62,21 +62,21 @@ eError_Write , eError_Copy , eError_Remove , - eError_No_SettingFolder , - eError_No_SettingFile , + eError_No_SettingsFolder , + eError_No_SettingsFile , eError_SettingNotExits , }; private: - const QHash settingsError_Message { // no translation for the error. My experience shows the error messages if trasnlated is not useful for serviceability and debugging. + const QHash settingsError_Message { // no translation for the error. My experience shows the error messages if translated is not useful for serviceability and debugging. { eError_None , "" }, { eError_POST , "The configuration source check failed." }, { eError_PathEmpty , "The settings path is empty." }, { eError_MkDir , "The configuration folder '%1' cannot be created." }, { eError_Write , "The settings file %1 can't be written." }, { eError_Copy , "The configuration folder '%1' cannot be copied." }, { eError_Remove , "The configuration folder '%1' cannot be removed." }, - { eError_No_SettingFolder , "No setting folder in the %1 path found." }, - { eError_No_SettingFile , "No setting files in the %1 folder found." }, + { eError_No_SettingsFolder , "No settings folder in the %1 path found." }, + { eError_No_SettingsFile , "No settings file in the %1 folder found." }, { eError_SettingNotExits , "The setting file %1 doesn't exists." }, }; public: Index: sources/storage/StorageGlobals.cpp =================================================================== diff -u -r7fb3037f90ac302238f618243a137bee1653ca2b -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/storage/StorageGlobals.cpp (.../StorageGlobals.cpp) (revision 7fb3037f90ac302238f618243a137bee1653ca2b) +++ sources/storage/StorageGlobals.cpp (.../StorageGlobals.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -178,7 +178,7 @@ const char *Brightness_Set = "brightness_set.sh"; const char *Brightness_Get = "brightness_get.sh"; - // Brightness + // Root SSH const char *RootSSHAccess_Set = "rootsshaccess_set.sh"; const char *RootSSHAccess_Get = "rootsshaccess_get.sh"; Index: sources/view/settings/VAdjustmentAlarmVolume.cpp =================================================================== diff -u -r1da89b0452b8ef9448847618e75c118f3f58bd0c -rcf51c19d82d667644d7f70eaa521b43f908c7068 --- sources/view/settings/VAdjustmentAlarmVolume.cpp (.../VAdjustmentAlarmVolume.cpp) (revision 1da89b0452b8ef9448847618e75c118f3f58bd0c) +++ sources/view/settings/VAdjustmentAlarmVolume.cpp (.../VAdjustmentAlarmVolume.cpp) (revision cf51c19d82d667644d7f70eaa521b43f908c7068) @@ -64,9 +64,10 @@ } /*! - * \brief VDuetRoWaterDG::onSettingsDone - * \details fills the items below, read from the settings file, when the reading is notified done by ApplicationController. - * acidConcentrateOptions + * \brief VAdjustmentAlarmVolume::onActionReceive + * \details This will send a message to update its Alarm Volume with the read value from configurations, + * When the Settings is done reading the SettingsData. + * */ void View::VAdjustmentAlarmVolume::onActionReceive(const SettingsData &) {