Index: firmware/App/Controllers/RinsePump.c =================================================================== diff -u -rbe3fa274cd01b6dec1f98fa7266739b55648d582 -rcc893e9b6656058542c82ca3a72532944e46375b --- firmware/App/Controllers/RinsePump.c (.../RinsePump.c) (revision be3fa274cd01b6dec1f98fa7266739b55648d582) +++ firmware/App/Controllers/RinsePump.c (.../RinsePump.c) (revision cc893e9b6656058542c82ca3a72532944e46375b) @@ -46,6 +46,7 @@ #define RINSE_PUMP_PULSE_WIDTH_INVALID_MIN 0U ///< Invalid pulse width minimum (no rotation). #define RINSE_PUMP_PULSE_WIDTH_INVALID_MAX 0xFFFFU ///< Invalid pulse width maximum (sensor fault). +//TODO: to be tested once the Beta 2 units are out #define RINSE_PUMP_SPD_OUT_OF_RANGE_TOL_PCT 0.10F ///< Rinse pump commanded vs measured speed tolerance (10%). #define RINSE_PUMP_SPEED_OUT_PERSISTENCE_MS 500 ///< Persistence time (ms) before declaring speed-out-of-range alarm. #define RINSE_PUMP_MAX_RPM_ESTIMATE 3000U ///< Estimated max rinse pump RPM (for PWM-to-target conversion). @@ -264,6 +265,7 @@ isRpSpeedOut = ( rpError > tolerance ? TRUE : FALSE ); } + //TODO: to be tested once the Beta 2 units are out checkPersistentAlarm( ALARM_ID_DD_D79_RINSE_PUMP_SPEED_OUT_OF_RANGE, isRpSpeedOut, (F32)rinsePumpMeasuredSpeed, (F32)rinsePumpTargetSpeedRPM ); }