Index: firmware/App/Controllers/Valves.c =================================================================== diff -u -ra7bb148f195e19802a905fade4a43e8fb403d474 -r8b5a8c816d953cfc1e2ee17a2f4b447e96e85d44 --- firmware/App/Controllers/Valves.c (.../Valves.c) (revision a7bb148f195e19802a905fade4a43e8fb403d474) +++ firmware/App/Controllers/Valves.c (.../Valves.c) (revision 8b5a8c816d953cfc1e2ee17a2f4b447e96e85d44) @@ -35,7 +35,7 @@ #define ENERGIZED 1 ///< 1 for energized valve. #define ALL_VALVES_DEENERGIZED 0x0000 ///< 0 in U16 bit field for all valves. -#define VALVE_PWM_PERIOD 500 ///< Valve PWM Period in 0.1 us res ( 20kHz ) +#define VALVE_PWM_PERIOD 500 ///< Valve PWM Period in 0.1 us res ( 20kHz ) #define VALVE_PWM_LOW ( VALVE_PWM_PERIOD * 0.2 ) ///< Valve low PWM percentage #define VALVE_PWM_PULL_IN 100 ///< Valve 'strike' period at 100% PWM in ms @@ -126,7 +126,7 @@ // TODO set FPGA PWM after finalizing the decision on valve strike and hold behavior // initially set valve PWM configuration and enable -// setFPGAPWMConfigurations(); + //setFPGAPWMConfigurations(); // initially set all valves to de-energized state via FPGA setFPGADDValveStates( commandedValvesStates ); @@ -175,7 +175,7 @@ valveSPBits |= 0x01 << ( i - FIRST_SP_VALVE ); } - for ( i = M12_VALV; i <= LAST_IO_VALVE; i++ ) + for ( i = FIRST_IO_VALVE; i <= LAST_IO_VALVE; i++ ) { valveIOBits |= 0x01 << ( i - FIRST_IO_VALVE ); }