Index: firmware/App/Drivers/ConductivityTeensy.c =================================================================== diff -u -rbd896114f304304a7096b30b2a85067a64645e82 -r8b5a8c816d953cfc1e2ee17a2f4b447e96e85d44 --- firmware/App/Drivers/ConductivityTeensy.c (.../ConductivityTeensy.c) (revision bd896114f304304a7096b30b2a85067a64645e82) +++ firmware/App/Drivers/ConductivityTeensy.c (.../ConductivityTeensy.c) (revision 8b5a8c816d953cfc1e2ee17a2f4b447e96e85d44) @@ -52,6 +52,7 @@ #define RX_SIZE_SELECT_SENSOR 1 ///< Expected response bytes length of select sensor cmd. #define RX_SIZE_GET_SINGLE_MEASUREMENT ( sizeof( COND_SENSOR_DATA_T ) ) ///< Expected response bytes length of get single sensor measurement cmd. +#define COND_INIT_TIMEOUT_MS ( 3 * MS_PER_SECOND ) ///< Timeout before which we should transition to idle state. #define COND_STATUS_TIMEOUT_MS ( 10 * MS_PER_SECOND ) ///< Timeout before which we should receive acknowledgment from teensy #define COND_DATA_TIMEOUT_MS ( 10 * MS_PER_SECOND ) ///< Timeout before which we should receive data from teensy #define COND_TEMP_OFFSET 25 ///< Temperature offset constant used in RTD calculations. @@ -62,6 +63,7 @@ static COND_COMM_STATE_T condCommState; ///< current Conductivity driver comm state. +static U32 condInitTime; ///< Tracks duration of init state. static U32 condResponseTime; ///< Tracks duration between cmd sent and its response received. static U32 condReceiptCounter; ///< Conductivity response receipt counter. static U32 condTransmitCounter; ///< Conductivity command transmit counter. @@ -128,6 +130,7 @@ static void initEEPROMdata( void ); static void initMeasurementSettings( void ); +static COND_COMM_STATE_T handleConductivityInit( void ); static COND_COMM_STATE_T handleConductivityIdle( void ); static COND_COMM_STATE_T handleConductivityTX( void ); static COND_COMM_STATE_T handleConductivityRX( void ); @@ -201,7 +204,8 @@ *************************************************************************/ void initConductivityTeensy( void ) { - condCommState = COND_COMM_STATE_IDLE; + condCommState = COND_COMM_STATE_INIT; + condInitTime = getMSTimerCount(); condResponseTime = 0; condReceiptCounter = 0; condTransmitCounter = 0; @@ -218,9 +222,9 @@ memset( &condCmdQ, 0, COND_CMD_Q_LEN ); memset( &condUpdateSettingStatus, 0, MAX_COND_MST_PARAM_IDX ); - memset( &condRawMeasurement, 0, MAX_TEENSY_SENSOR ); - memset( &condCalculatedMeasurement, 0, MAX_TEENSY_SENSOR ); - memset( &condCoeff, 0, MAX_TEENSY_SENSOR ); + memset( &condRawMeasurement, 0, ( sizeof( condRawMeasurement ) * MAX_TEENSY_SENSOR ) ); + memset( &condCalculatedMeasurement, 0, ( sizeof( condCalculatedMeasurement ) * MAX_TEENSY_SENSOR ) ); + memset( &condCoeff, 0, ( sizeof( condCoeff ) * MAX_TEENSY_SENSOR ) ); queueCount = 0; queueRearIndex = 0; @@ -380,6 +384,10 @@ { switch ( condCommState ) { + case COND_COMM_STATE_INIT: + condCommState = handleConductivityInit(); + break; + case COND_COMM_STATE_IDLE: condCommState = handleConductivityIdle(); break; @@ -404,6 +412,25 @@ /*********************************************************************//** * @brief + * The handleConductivityInit handles the init sequence and transitions to the respective + * comm state. + * @details \b Inputs: none + * @details \b Outputs: none + * @return state - Next state. + *************************************************************************/ +static COND_COMM_STATE_T handleConductivityInit( void ) +{ + COND_COMM_STATE_T state = COND_COMM_STATE_INIT; + + if ( TRUE == didTimeout( condInitTime, COND_INIT_TIMEOUT_MS ) ) + { + state = COND_COMM_STATE_IDLE; + } + return state; +} + +/*********************************************************************//** + * @brief * The handleConductivityIdle handles the command queue and transitions to the respective * comm state. * @details \b Inputs: condAutomatedDataPolling @@ -1970,7 +1997,7 @@ /*********************************************************************//** * @brief - * The getConductivityValue function gets the current calculated conductivity / + * The getTeensyConductivityValue function gets the current calculated conductivity / impedance value. * @details \b Inputs: condCalculatedMeasurement * @details \b Outputs: none @@ -1984,15 +2011,19 @@ if ( D74_COND != sensorId ) { - result = ( F32 )condCalculatedMeasurement[ sensorNum ].Conductivity; + result = condCalculatedMeasurement[ sensorNum ].Conductivity.data; + if ( OVERRIDE_KEY == condCalculatedMeasurement[ sensorNum ].Conductivity.override ) + { + result = condCalculatedMeasurement[ sensorNum ].Conductivity.ovData; + } } return result; } /*********************************************************************//** * @brief - * The getTemperatureValue function gets the current conductivity sensor + * The getTeensyConductivityTemperatureValue function gets the current conductivity sensor * temperature for a given conductivity sensor. * @details \b Inputs: condCalculatedMeasurement * @details \b Outputs: none @@ -2006,14 +2037,44 @@ if ( D74_COND != sensorId ) { - result = ( F32 )condCalculatedMeasurement[ sensorNum ].Temperature; + result = condCalculatedMeasurement[ sensorNum ].Temperature.data; + if ( OVERRIDE_KEY == condCalculatedMeasurement[ sensorNum ].Temperature.override ) + { + result = condCalculatedMeasurement[ sensorNum ].Temperature.ovData; + } } return result; } /*********************************************************************//** * @brief + * The getTeensyConductivityResistanceValue function gets the current conductivity sensor + * resistance for a given conductivity sensor. + * @details \b Inputs: condCalculatedMeasurement + * @details \b Outputs: none + * @param sensorId ID of conductivity sensor to get temperature. + * @return The current temperature of a given conductivity sensor. + *************************************************************************/ +F32 getTeensyConductivityResistanceValue( CONDUCTIVITY_SENSORS_T sensorId ) +{ + U32 sensorNum = getTeensyCondId( sensorId ); + F32 result = 0.0F; + + if ( D74_COND != sensorId ) + { + result = condCalculatedMeasurement[ sensorNum ].Resistance.data; + if ( OVERRIDE_KEY == condCalculatedMeasurement[ sensorNum ].Resistance.override ) + { + result = condCalculatedMeasurement[ sensorNum ].Resistance.ovData; + } + } + + return result; +} + +/*********************************************************************//** + * @brief * The calculateConductivity function calculates the conductivity value. * @details \b Inputs: currentConductivityModel - conductivity model being used. * @details \b Outputs: condCalculatedMeasurement - calculated conductivity value @@ -2093,7 +2154,7 @@ B0 ); - condCalculatedMeasurement[ sensorNum ].Conductivity = calculatedConductivity; + condCalculatedMeasurement[ sensorNum ].Conductivity.data = (F32)calculatedConductivity; } /*********************************************************************//** @@ -2125,9 +2186,9 @@ calculateResistance( sensorNum, isFPSensor ); calculateTemperature( sensorNum ); - calculatedConductivity = ( ( k / condCalculatedMeasurement[ sensorNum ].Resistance ) * - ( 1 + alpha * ( COND_TEMP_OFFSET - condCalculatedMeasurement[ sensorNum ].Temperature ) ) ); - condCalculatedMeasurement[ sensorNum ].Conductivity = calculatedConductivity; + calculatedConductivity = ( ( k / getTeensyConductivityResistanceValue( sensorNum ) ) * + ( 1 + alpha * ( COND_TEMP_OFFSET - getTeensyConductivityTemperatureValue( sensorNum ) ) ) ); + condCalculatedMeasurement[ sensorNum ].Conductivity.data = (F32)calculatedConductivity; } /*********************************************************************//** @@ -2168,10 +2229,10 @@ calculateTemperature( sensorNum ); calculatedConductivity = ( ( k / R ) * - ( 1 + alpha * ( COND_TEMP_OFFSET - condCalculatedMeasurement[ sensorNum ].Temperature ) ) ); + ( 1 + alpha * ( COND_TEMP_OFFSET - getTeensyConductivityTemperatureValue( sensorNum ) ) ) ); calculatedConductivity = calculatedConductivity * COND_CONVERSION_SM_TO_USCM; - condCalculatedMeasurement[ sensorNum ].Conductivity = calculatedConductivity; + condCalculatedMeasurement[ sensorNum ].Conductivity.data = (F32)calculatedConductivity; } /*********************************************************************//** @@ -2211,7 +2272,7 @@ zeta = condCoeff[ sensorNum ].zetaHighDDUS; } calculatedResistance = ( ( eta * R ) + zeta ); - condCalculatedMeasurement[ sensorNum ].Resistance = calculatedResistance; + condCalculatedMeasurement[ sensorNum ].Resistance.data = (F32)calculatedResistance; } /*********************************************************************//** @@ -2232,16 +2293,135 @@ F64 Z = condRawMeasurement[ sensorNum ].rtdRzMag; calculatedTemperature = ( ( beta * Z ) + gamma ); - condCalculatedMeasurement[ sensorNum ].Temperature = calculatedTemperature; + condCalculatedMeasurement[ sensorNum ].Temperature.data = (F32)calculatedTemperature; } + /************************************************************************* * TEST SUPPORT FUNCTIONS *************************************************************************/ /*********************************************************************//** * @brief + * The testTeensyConductivitySensorReadingsOverride function overrides the value of the + * specified conductivity sensor with a given value. + * @details \b Inputs: none + * @details \b Outputs: condCalculatedMeasurement[] + * @param message Override message from Dialin which includes an sensor + * ID and override value of the conductivity sensor. + * @return TRUE if override successful, FALSE if not + *************************************************************************/ +BOOL testTeensyConductivitySensorReadingsOverride( MESSAGE_T *message ) +{ + BOOL result = FALSE; + TEST_OVERRIDE_ARRAY_PAYLOAD_T payload; + OVERRIDE_TYPE_T ovType = getOverrideArrayPayloadFromMessage( message, &payload ); + + if ( ( payload.index >= FIRST_DD_COND_SENSOR ) && ( payload.index <= LAST_FP_COND_SENSOR ) ) + { + // D74 is not connected to Teensy and does not have a data structure to override. + if ( LAST_DD_COND_SENSOR != payload.index ) + { + result = TRUE; + if ( OVERRIDE_OVERRIDE == ovType ) + { + F32 value = payload.state.f32; + + condCalculatedMeasurement[ payload.index ].Conductivity.ovData = value; + condCalculatedMeasurement[ payload.index ].Conductivity.override = OVERRIDE_KEY; + } + else + { + condCalculatedMeasurement[ payload.index ].Conductivity.override = OVERRIDE_RESET; + condCalculatedMeasurement[ payload.index ].Conductivity.ovData = condCalculatedMeasurement[ payload.index ].Conductivity.ovInitData; + } + } + } + return result; +} + +/*********************************************************************//** + * @brief + * The testTeensyConductivitySensorTemperatureReadingsOverride function overrides + * the value of the specified conductivity sensor temperature with a given value. + * @details \b Inputs: none + * @details \b Outputs: condCalculatedMeasurement[] + * @param message Override message from Dialin which includes an sensor + * ID and override value of the conductivity sensor temperature. + * @return TRUE if override successful, FALSE if not + *************************************************************************/ +BOOL testTeensyConductivitySensorTemperatureReadingsOverride( MESSAGE_T *message ) +{ + BOOL result = FALSE; + TEST_OVERRIDE_ARRAY_PAYLOAD_T payload; + OVERRIDE_TYPE_T ovType = getOverrideArrayPayloadFromMessage( message, &payload ); + + if ( ( payload.index >= FIRST_DD_COND_SENSOR ) && ( payload.index <= LAST_FP_COND_SENSOR ) ) + { + // D74 is not connected to Teensy and does not have a data structure to override. + if ( LAST_DD_COND_SENSOR != payload.index ) + { + result = TRUE; + if ( OVERRIDE_OVERRIDE == ovType ) + { + F32 value = payload.state.f32; + + condCalculatedMeasurement[ getTeensyCondId( payload.index ) ].Temperature.ovData = value; + condCalculatedMeasurement[ getTeensyCondId( payload.index ) ].Temperature.override = OVERRIDE_KEY; + } + else + { + condCalculatedMeasurement[ getTeensyCondId( payload.index ) ].Temperature.override = OVERRIDE_RESET; + condCalculatedMeasurement[ getTeensyCondId( payload.index ) ].Temperature.ovData = condCalculatedMeasurement[ getTeensyCondId( payload.index ) ].Temperature.ovInitData; + } + } + + } + return result; +} + +/*********************************************************************//** + * @brief + * The testTeensyConductivitySensorResistanceReadingsOverride function overrides + * the value of the specified conductivity sensor resistance with a given value. + * @details \b Inputs: none + * @details \b Outputs: condCalculatedMeasurement[] + * @param message Override message from Dialin which includes an sensor + * ID and override value of the conductivity sensor temperature. + * @return TRUE if override successful, FALSE if not + *************************************************************************/ +BOOL testTeensyConductivitySensorResistanceReadingsOverride( MESSAGE_T *message ) +{ + BOOL result = FALSE; + TEST_OVERRIDE_ARRAY_PAYLOAD_T payload; + OVERRIDE_TYPE_T ovType = getOverrideArrayPayloadFromMessage( message, &payload ); + + if ( ( payload.index >= FIRST_DD_COND_SENSOR ) && ( payload.index <= LAST_FP_COND_SENSOR ) ) + { + // D74 is not connected to Teensy and does not have a data structure to override. + if ( LAST_DD_COND_SENSOR != payload.index ) + { + result = TRUE; + if ( OVERRIDE_OVERRIDE == ovType ) + { + F32 value = payload.state.f32; + + condCalculatedMeasurement[ payload.index ].Resistance.ovData = value; + condCalculatedMeasurement[ payload.index ].Resistance.override = OVERRIDE_KEY; + } + else + { + condCalculatedMeasurement[ payload.index ].Resistance.override = OVERRIDE_RESET; + condCalculatedMeasurement[ payload.index ].Resistance.ovData = condCalculatedMeasurement[ payload.index ].Resistance.ovInitData; + } + } + + } + return result; +} +/*********************************************************************//** + * @brief * The testSetTeenyConductivityModel function sets the given conductivity model * @details \b Inputs: none * @details \b Outputs: currentConductivityModel[]