Index: firmware/App/Controllers/DrainPump.c =================================================================== diff -u -rfcdecd8b2c6b086ddf4700ecc1892bd47aef08c1 -r7fe3d2932b501e323a6fb0eb47964b32da6798d9 --- firmware/App/Controllers/DrainPump.c (.../DrainPump.c) (revision fcdecd8b2c6b086ddf4700ecc1892bd47aef08c1) +++ firmware/App/Controllers/DrainPump.c (.../DrainPump.c) (revision 7fe3d2932b501e323a6fb0eb47964b32da6798d9) @@ -122,7 +122,7 @@ static F32 targetDrainPumpOutletFlowLPM; ///< Target outlet pressure for the drain pump. static U32 drainControlTimerCtr; ///< Determines when to perform control on drain pump. static BOOL hasClosedLoopBeenRequested; ///< Closed loop pump control flag. -static OVERRIDE_U32_T drainPumpMeasuredRPM = { 0, 0, 0, 0 }; ///< Measured drain pump RPM from feedback. +static OVERRIDE_U32_T drainPumpHallMeasuredRPM = { 0, 0, 0, 0 }; ///< Measured drain pump RPM from feedback. static OVERRIDE_U32_T drainPumpMaxonMeasuredRPM = { 0, 0, 0, 0 }; ///< Measured Maxon drain pump RPM. static OVERRIDE_F32_T drainPumpMeasuredCurrentA = { 0.0F, 0.0F, 0.0F, 0 }; ///< Measured drain pump current feedback. static OVERRIDE_U32_T drainPumpMeasuredDir = { 0, 0, 0, 0 }; ///< Measured drain pump direction. @@ -341,8 +341,8 @@ U32 dirHallSensorErrorCount = (U32)( getFPGADrainPumpDirection() & DRAIN_PUMP_DIR_ERROR_CNT_BIT_MASK ); // Update the override variables - drainPumpMaxonMeasuredRPM.data = MAX_DRAIN_PUMP_RPM * ( fpgaMaxonADCSpeedCount / BITS_12_FULL_SCALE ); - drainPumpMeasuredRPM.data = ( DRAIN_PUMP_OFF_RPM_ADC_COUNT == fpgaADCSpeedCount ? 0 : (U32)( RPM_CONVERSION_COEFF / (F32)fpgaADCSpeedCount ) ); + drainPumpMaxonMeasuredRPM.data = MAX_DRAIN_PUMP_RPM * ( (F32)fpgaMaxonADCSpeedCount / (F32)BITS_12_FULL_SCALE ); + drainPumpHallMeasuredRPM.data = ( DRAIN_PUMP_OFF_RPM_ADC_COUNT == fpgaADCSpeedCount ? 0 : (U32)( RPM_CONVERSION_COEFF / (F32)fpgaADCSpeedCount ) ); drainPumpMeasuredCurrentA.data = (F32)fpgaADCCurrentCount * CURRENT_CONVERSION_COEFF; drainPumpMeasuredDir.data = (U32)( ( getFPGADrainPumpDirection() & DRAIN_PUMP_DIR_BIT_MASK ) >> SHIFT_BITS_BY_7 ); @@ -385,14 +385,24 @@ // The RPM is only checked in open loop state that the pump is run at a fixed RPM. case DRAIN_PUMP_OPEN_LOOP_STATE: { + U32 rpmHall = getDrainPumpMeasuredRPM( DRAIN_PUMP_HALL_SNSR_FB ); + U32 rpmMaxon = getDrainPumpMeasuredRPM( DRAIN_PUMP_MAXON_SNSR_FB ); + BOOL isRPMOutOfRange = FALSE; U32 direction = getDrainPumpMeasuredDirection(); BOOL isDirInvalid = ( direction != DRAIN_PUMP_FORWARD_DIR ? TRUE : FALSE ); - U32 rpmDiff = abs( getDrainPumpTargetRPM() - getDrainPumpMeasuredRPM( DRAIN_PUMP_HALL_SNSR_FB ) ); - BOOL isRPMOutOfRange = ( rpmDiff > MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ? TRUE : FALSE ); + U32 rpmHallDiff = abs( getDrainPumpTargetRPM() - rpmHall ); + U32 rpmMaxonDiff = abs( getDrainPumpTargetRPM() - rpmMaxon ); - checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_RPM_OUT_OF_RANGE, isRPMOutOfRange, getDrainPumpMeasuredRPM(), MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ); - checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_OFF_FAULT, FALSE, getDrainPumpMeasuredRPM(), MIN_DRAIN_PUMP_RPM ); + isRPMOutOfRange |= ( rpmHallDiff > MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ? TRUE : FALSE ); + if ( getHardwareConfigStatus() != HW_CONFIG_BETA ) + { + isRPMOutOfRange |= ( rpmMaxonDiff > MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ? TRUE : FALSE ); + } + + checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_RPM_OUT_OF_RANGE, isRPMOutOfRange, rpmHall, MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ); + checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_OFF_FAULT, FALSE, rpmHall, MIN_DRAIN_PUMP_RPM ); + if ( ( getHardwareConfigStatus() != HW_CONFIG_BETA ) && ( getCurrentOperationMode() != DG_MODE_INIT ) ) { checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_DIRECTION_INVALID, isDirInvalid, (F32)direction, DRAIN_PUMP_FORWARD_DIR ); @@ -414,8 +424,8 @@ default: // There are not out of range conditions, clear the alarms - checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_RPM_OUT_OF_RANGE, FALSE, getDrainPumpMeasuredRPM(), MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ); - checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_OFF_FAULT, FALSE, getDrainPumpMeasuredRPM(), MIN_DRAIN_PUMP_RPM ); + checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_RPM_OUT_OF_RANGE, FALSE, getDrainPumpMeasuredRPM( DRAIN_PUMP_HALL_SNSR_FB ), MAX_ALLOWED_OPEN_LOOP_RPM_OUT_OF_RANGE ); + checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_OFF_FAULT, FALSE, getDrainPumpMeasuredRPM( DRAIN_PUMP_HALL_SNSR_FB ), MIN_DRAIN_PUMP_RPM ); checkPersistentAlarm( ALARM_ID_DG_DRAIN_PUMP_DIRECTION_INVALID, FALSE, getFPGADrainPumpDirection(), DRAIN_PUMP_FORWARD_DIR ); break; } @@ -553,12 +563,28 @@ * pump RPM sensor. * @details Inputs: drainPumpMeasuredRPM * @details Outputs: none + * @param sensor to get its RPM from (Hall sensor or Maxon board in DVT) * @return drain pump RPM *************************************************************************/ -U32 getDrainPumpMeasuredRPM( DRAIN_PUMP_SPEED_FB_SNSR_T speed ) +U32 getDrainPumpMeasuredRPM( DRAIN_PUMP_SPEED_FB_SNSR_T sensor ) { - U32 rpm = getU32OverrideValue( &drainPumpMeasuredRPM ); + U32 rpm = 0; + switch ( sensor ) + { + case DRAIN_PUMP_HALL_SNSR_FB: + rpm = getU32OverrideValue( &drainPumpHallMeasuredRPM ); + break; + + case DRAIN_PUMP_MAXON_SNSR_FB: + rpm = getU32OverrideValue( &drainPumpMaxonMeasuredRPM ); + break; + + default: + // Do nothing. Software fault? + break; + } + return rpm; } @@ -781,10 +807,11 @@ drainPumpData.rpmSetPoint = getDrainPumpTargetRPM(); drainPumpData.pumpDACSet = drainPumpDACSet; drainPumpData.drainPumpState = (U32)drainPumpState; - drainPumpData.drainPumpRPM = getDrainPumpMeasuredRPM(); + drainPumpData.drainPumpHallRPM = getDrainPumpMeasuredRPM( DRAIN_PUMP_HALL_SNSR_FB ); drainPumpData.trgtOutletFlowLPM = targetDrainPumpOutletFlowLPM; drainPumpData.drainPumpCurrentA = getDrainPumpMeasuredCurrentA(); drainPumpData.drainPumpDirection = getDrainPumpMeasuredDirection(); + drainPumpData.drainPumpMaxonRPM = getDrainPumpMeasuredRPM( DRAIN_PUMP_MAXON_SNSR_FB ); broadcastData( MSG_ID_DRAIN_PUMP_DATA, COMM_BUFFER_OUT_CAN_DG_BROADCAST, (U08*)&drainPumpData, sizeof( DRAIN_PUMP_DATA_T ) ); @@ -934,21 +961,34 @@ * The testSetDrainPumpMeasuredRPMOverride function overrides the drain pump * measured RPM data. * @details Inputs: none - * @details Outputs: drainPumpMeasuredRPM + * @details Outputs: drainPumpHallMeasuredRPM, drainPumpMaxonMeasuredRPM + * @param sensor the type of sensor to pick (hall sensor or Maxon board) * @param value override drain pump measured data * @return TRUE if override successful, FALSE if not *************************************************************************/ -BOOL testSetDrainPumpMeasuredRPMOverride( U32 value ) +BOOL testSetDrainPumpMeasuredRPMOverride( U32 sensor, U32 value ) { BOOL status = FALSE; // Check if the user is logged in - if ( TRUE == isTestingActivated() ) + if ( ( TRUE == isTestingActivated() ) && ( (DRAIN_PUMP_SPEED_FB_SNSR_T)sensor < NUM_OF_DRAIN_PUMP_SNSR_FB ) ) { - drainPumpMeasuredRPM.ovData = value; - drainPumpMeasuredRPM.override = OVERRIDE_KEY; - drainPumpMeasuredRPM.ovInitData = drainPumpMeasuredRPM.data; - status = TRUE; + switch( (DRAIN_PUMP_SPEED_FB_SNSR_T)sensor ) + { + case DRAIN_PUMP_HALL_SNSR_FB: + drainPumpHallMeasuredRPM.ovData = value; + drainPumpHallMeasuredRPM.override = OVERRIDE_KEY; + drainPumpHallMeasuredRPM.ovInitData = drainPumpHallMeasuredRPM.data; + break; + + case DRAIN_PUMP_MAXON_SNSR_FB: + drainPumpMaxonMeasuredRPM.ovData = value; + drainPumpMaxonMeasuredRPM.override = OVERRIDE_KEY; + drainPumpMaxonMeasuredRPM.ovInitData = drainPumpMaxonMeasuredRPM.data; + break; + } + + status = TRUE; } return status; @@ -960,18 +1000,30 @@ * measured RPM data. * @details Inputs: none * @details Outputs: drainPumpMeasuredRPM + * @param sensor the type of sensor to pick (hall sensor or Maxon board) * @return TRUE if override reset successful, FALSE if not *************************************************************************/ -BOOL testResetDrainPumpMeasuredRPMOverride( void ) +BOOL testResetDrainPumpMeasuredRPMOverride( U32 sensor ) { BOOL status = FALSE; // Check if the user is logged in - if ( TRUE == isTestingActivated() ) + if ( ( TRUE == isTestingActivated() ) && ( (DRAIN_PUMP_SPEED_FB_SNSR_T)sensor < NUM_OF_DRAIN_PUMP_SNSR_FB ) ) { - drainPumpMeasuredRPM.ovData = drainPumpMeasuredRPM.ovInitData; - drainPumpMeasuredRPM.override = OVERRIDE_RESET; - status = TRUE; + switch( (DRAIN_PUMP_SPEED_FB_SNSR_T)sensor ) + { + case DRAIN_PUMP_HALL_SNSR_FB: + drainPumpHallMeasuredRPM.ovData = drainPumpHallMeasuredRPM.ovInitData; + drainPumpHallMeasuredRPM.override = OVERRIDE_RESET; + break; + + case DRAIN_PUMP_MAXON_SNSR_FB: + drainPumpMaxonMeasuredRPM.ovData = drainPumpMaxonMeasuredRPM.ovInitData; + drainPumpMaxonMeasuredRPM.override = OVERRIDE_RESET; + break; + } + + status = TRUE; } return status;