Index: firmware/App/Services/WatchdogMgmt.c =================================================================== diff -u -r256d5cb05f1ef09e19e2f2733a111f600c73a7ee -rf192234d80556802fa42e62f8c1b20d1474f82f1 --- firmware/App/Services/WatchdogMgmt.c (.../WatchdogMgmt.c) (revision 256d5cb05f1ef09e19e2f2733a111f600c73a7ee) +++ firmware/App/Services/WatchdogMgmt.c (.../WatchdogMgmt.c) (revision f192234d80556802fa42e62f8c1b20d1474f82f1) @@ -49,13 +49,11 @@ // ********** private data ********** -static U32 lastWatchdogPetTime = 0; ///< Previous watchdog pet timestamp (in ms). - +static U32 lastWatchdogPetTime; ///< Previous watchdog pet timestamp (in ms). static OVERRIDE_U32_T watchdogTaskCheckedIn[ NUM_OF_TASKS ]; ///< Array of flags indicating whether individual tasks have checked in with watchdog manager. - static WATCHDOG_SELF_TEST_STATE_T watchdogSelfTestState; ///< Watchdog self-test current state. static SELF_TEST_STATUS_T watchdogSelfTestStatus; ///< Watchdog self-test status. -static U32 watchdogSelfTestTimerCount = 0; ///< Watchdog self-test timer count. +static U32 watchdogSelfTestTimerCount; ///< Watchdog self-test timer count. // ********** private function prototypes ********** @@ -75,17 +73,18 @@ { U32 i; - lastWatchdogPetTime = 0; - watchdogSelfTestState = WATCHDOG_SELF_TEST_STATE_START; - watchdogSelfTestStatus = SELF_TEST_STATUS_IN_PROGRESS; - watchdogSelfTestTimerCount = 0; + lastWatchdogPetTime = 0; + watchdogSelfTestState = WATCHDOG_SELF_TEST_STATE_START; + watchdogSelfTestStatus = SELF_TEST_STATUS_IN_PROGRESS; + watchdogSelfTestTimerCount = 0; + // initialize task check-ins to false for ( i = 0; i < NUM_OF_TASKS; i++ ) { - watchdogTaskCheckedIn[ i ].data = FALSE; - watchdogTaskCheckedIn[ i ].ovData = FALSE; + watchdogTaskCheckedIn[ i ].data = FALSE; + watchdogTaskCheckedIn[ i ].ovData = FALSE; watchdogTaskCheckedIn[ i ].ovInitData = FALSE; - watchdogTaskCheckedIn[ i ].override = OVERRIDE_RESET; + watchdogTaskCheckedIn[ i ].override = OVERRIDE_RESET; } } @@ -107,7 +106,7 @@ allTasksCheckedIn = haveAllTasksCheckedIn(); // if all monitored tasks checked in, pet watchdog and clear the slate - if ( ( TRUE == allTasksCheckedIn ) && ( didTimeout( lastWatchdogPetTime, MIN_WATCHDOG_PET_INTERVAL_MS ) ) ) + if ( ( TRUE == allTasksCheckedIn ) && ( TRUE == didTimeout( lastWatchdogPetTime, MIN_WATCHDOG_PET_INTERVAL_MS ) ) ) { petWatchdog(); resetWDTaskCheckIns(); @@ -175,7 +174,7 @@ // Verify 24V is down when w.d. expired if ( v24 > MAX_24V_LEVEL_ON_WATCHDOG_EXPIRED ) { - SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_WATCHDOG_POST_TEST_FAILED, 2.0, v24 ); + SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_WATCHDOG_POST_TEST_FAILED, 2.0F, v24 ); watchdogSelfTestStatus = SELF_TEST_STATUS_FAILED; } } @@ -195,14 +194,15 @@ { F32 v24 = getIntADCVoltageConverted( INT_ADC_SECONDARY_HEATER_24_VOLTS ); - // Verify 24V is down when w.d. recovered TODO - ask EE team why 24V does not quite recover all the way to 22.6V even after 750 ms. How long should it take? -// if ( v24 < MIN_24V_LEVEL_ON_WATCHDOG_RECOVER ) -// { -// SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_WATCHDOG_POST_TEST_FAILED, 3.0, v24 ); -// watchdogSelfTestStatus = SELF_TEST_STATUS_FAILED; -// } -// else + // Verify 24V is down when w.d. recovered TODO - If issue persisted + // ask EE team why 24V does not quite recover all the way to 22.6V even after 750 ms. How long should it take? + if ( v24 < MIN_24V_LEVEL_ON_WATCHDOG_RECOVER ) { + SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_WATCHDOG_POST_TEST_FAILED, 3.0, v24 ); + watchdogSelfTestStatus = SELF_TEST_STATUS_FAILED; + } + else + { watchdogSelfTestStatus = SELF_TEST_STATUS_PASSED; } }