Index: results/cppcheckError.csv =================================================================== diff -u -r110a5fef2962a0011148c3332a87e711e3ed65cd -rf308cc4c35eab630ebbbde405cfe47d049afeafb --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 110a5fef2962a0011148c3332a87e711e3ed65cd) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision f308cc4c35eab630ebbbde405cfe47d049afeafb) @@ -1,97 +1,87 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/DrainPump.c,168,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,350,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,351,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,352,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,568,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,80,style,variableScope,The scope of the variable 'controller' can be reduced. -dgfirmware/firmware/App/Services/Reservoirs.c,272,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/DrainPump.c,173,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,347,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,348,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,349,style,unusedVariable,Unused variable: newPWM +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,571,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,119,warning,redundantAssignInSwitch,Variable 'testStatus' is reassigned a value before the old one has been used. 'break;' missing? +dgfirmware/firmware/App/Services/Interrupts.c,171,style,variableScope,The scope of the variable 'debugStr' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/Reservoirs.c,258,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1551,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1552,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1555,style,variableScope,The scope of the variable 'i' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,1204,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/RTC.c,778,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,779,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,701,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -dgfirmware/firmware/FWCommon/Utilities.c,198,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1531,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1532,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1535,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,1178,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/RTC.c,764,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,765,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,689,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/Utilities.c,214,style,variableScope,The scope of the variable 'timeInMS' can be reduced. dgfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -dgfirmware/firmware/App/Drivers/InternalADC.c,119,style,unusedFunction,The function 'adcNotification' is never used. +dgfirmware/firmware/App/Drivers/InternalADC.c,118,style,unusedFunction,The function 'adcNotification' is never used. dgfirmware/firmware/FWCommon/Timers.c,147,style,unusedFunction,The function 'calcTimeBetween' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,225,style,unusedFunction,The function 'dmaGroupANotification' is never used. -dgfirmware/firmware/FWCommon/Accel.c,129,style,unusedFunction,The function 'execAccel' is never used. -dgfirmware/firmware/FWCommon/Accel.c,476,style,unusedFunction,The function 'execAccelTest' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,77,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,384,style,unusedFunction,The function 'execDrainPumpTest' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,168,style,unusedFunction,The function 'canErrorNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,147,style,unusedFunction,The function 'canMessageNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,313,style,unusedFunction,The function 'dmaGroupANotification' is never used. +dgfirmware/firmware/App/Services/AlarmMgmt.c,75,style,unusedFunction,The function 'execAlarmMgmt' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,398,style,unusedFunction,The function 'execDrainPumpTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,736,style,unusedFunction,The function 'execNVDataMgmt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/Pressures.c,327,style,unusedFunction,The function 'execPressuresTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,505,style,unusedFunction,The function 'execROPumpTest' is never used. -dgfirmware/firmware/FWCommon/RTC.c,359,style,unusedFunction,The function 'execRTC' is never used. -dgfirmware/firmware/FWCommon/RTC.c,301,style,unusedFunction,The function 'execRTCSelfTest' is never used. -dgfirmware/firmware/FWCommon/Accel.c,586,style,unusedFunction,The function 'getAccelCalibration' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,722,style,unusedFunction,The function 'getBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,613,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,502,style,unusedFunction,The function 'execROPumpTest' is never used. +dgfirmware/firmware/FWCommon/RTC.c,355,style,unusedFunction,The function 'execRTC' is never used. +dgfirmware/firmware/FWCommon/RTC.c,298,style,unusedFunction,The function 'execRTCSelfTest' is never used. +dgfirmware/firmware/FWCommon/Accel.c,670,style,unusedFunction,The function 'getAccelCalibration' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,723,style,unusedFunction,The function 'getBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,254,style,unusedFunction,The function 'getCriticalData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,95,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeDrain.c,154,style,unusedFunction,The function 'getCurrentDrainState' is never used. +dgfirmware/firmware/App/Modes/ModeDrain.c,151,style,unusedFunction,The function 'getCurrentDrainState' is never used. dgfirmware/firmware/App/Modes/ModeFault.c,93,style,unusedFunction,The function 'getCurrentFaultState' is never used. -dgfirmware/firmware/App/Modes/ModeFill.c,192,style,unusedFunction,The function 'getCurrentFillState' is never used. +dgfirmware/firmware/App/Modes/ModeFill.c,188,style,unusedFunction,The function 'getCurrentFillState' is never used. dgfirmware/firmware/App/Modes/ModeFlush.c,95,style,unusedFunction,The function 'getCurrentFlushState' is never used. dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,94,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,210,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,93,style,unusedFunction,The function 'getCurrentServiceState' is never used. -dgfirmware/firmware/App/Modes/ModeSolo.c,95,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,235,style,unusedFunction,The function 'getCurrentStandbyState' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,588,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/App/Services/FPGA.c,1477,style,unusedFunction,The function 'getFPGACPo' is never used. -dgfirmware/firmware/App/Services/FPGA.c,961,style,unusedFunction,The function 'getFPGAId' is never used. -dgfirmware/firmware/App/Services/FPGA.c,976,style,unusedFunction,The function 'getFPGARev' is never used. -dgfirmware/firmware/App/Services/FPGA.c,991,style,unusedFunction,The function 'getFPGAStatus' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. -dgfirmware/firmware/FWCommon/RTC.c,419,style,unusedFunction,The function 'getRTCTimestamp' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,409,style,unusedFunction,The function 'getServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,506,style,unusedFunction,The function 'getTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,546,style,unusedFunction,The function 'getWaterConsumption' is never used. -dgfirmware/firmware/FWCommon/Accel.c,100,style,unusedFunction,The function 'initAccel' is never used. +dgfirmware/firmware/App/Modes/ModeSolo.c,125,style,unusedFunction,The function 'getCurrentSoloState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,237,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,592,style,unusedFunction,The function 'getDisinfectionDate' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1491,style,unusedFunction,The function 'getFPGACPo' is never used. +dgfirmware/firmware/App/Services/FPGA.c,946,style,unusedFunction,The function 'getFPGAId' is never used. +dgfirmware/firmware/App/Services/FPGA.c,960,style,unusedFunction,The function 'getFPGARev' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,328,style,unusedFunction,The function 'getMfgData' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,189,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/FWCommon/RTC.c,414,style,unusedFunction,The function 'getRTCTimestamp' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,421,style,unusedFunction,The function 'getServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,514,style,unusedFunction,The function 'getTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,552,style,unusedFunction,The function 'getWaterConsumption' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,273,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,254,style,unusedFunction,The function 'isAlarmActive' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,156,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTPassed' is never used. -dgfirmware/firmware/App/Drivers/Comm.c,292,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +dgfirmware/firmware/App/Services/AlarmMgmt.c,259,style,unusedFunction,The function 'isAlarmActive' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,171,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Drivers/Comm.c,276,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Drivers/SafetyShutdown.c,75,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,456,style,unusedFunction,The function 'readLogData' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. -dgfirmware/firmware/FWCommon/Accel.c,547,style,unusedFunction,The function 'setAccelCalibration' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,699,style,unusedFunction,The function 'setBootloaderFlag' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,132,style,unusedFunction,The function 'setCPLDLampBlue' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,110,style,unusedFunction,The function 'setCPLDLampGreen' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,154,style,unusedFunction,The function 'setCPLDLampRed' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,562,style,unusedFunction,The function 'setDisinfectionDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,297,style,unusedFunction,The function 'setMfgData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,383,style,unusedFunction,The function 'setServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,480,style,unusedFunction,The function 'setTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,521,style,unusedFunction,The function 'setWaterConsumption' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,244,style,unusedFunction,The function 'stopDrainCmd' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,193,style,unusedFunction,The function 'stopFillCmd' is never used. -dgfirmware/firmware/App/Tasks/TaskGeneral.c,42,style,unusedFunction,The function 'taskGeneral' is never used. -dgfirmware/firmware/App/Tasks/TaskPriority.c,42,style,unusedFunction,The function 'taskPriority' is never used. -dgfirmware/firmware/App/Tasks/TaskTimer.c,33,style,unusedFunction,The function 'taskTimer' is never used. -dgfirmware/firmware/FWCommon/Accel.c,679,style,unusedFunction,The function 'testResetAccelAxisOverride' is never used. -dgfirmware/firmware/FWCommon/Accel.c,628,style,unusedFunction,The function 'testResetAccelDataPublishIntervalOverride' is never used. -dgfirmware/firmware/FWCommon/Accel.c,733,style,unusedFunction,The function 'testResetAccelMaxOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,400,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,494,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,447,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/FWCommon/Accel.c,652,style,unusedFunction,The function 'testSetAccelAxisOverride' is never used. -dgfirmware/firmware/FWCommon/Accel.c,603,style,unusedFunction,The function 'testSetAccelDataPublishIntervalOverride' is never used. -dgfirmware/firmware/FWCommon/Accel.c,706,style,unusedFunction,The function 'testSetAccelMaxOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,377,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,471,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,424,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,432,style,unusedFunction,The function 'writeLogData' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,88,style,unusedFunction,The function 'phantomInterrupt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,466,style,unusedFunction,The function 'readLogData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,320,style,unusedFunction,The function 'resetCriticalData' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,111,style,unusedFunction,The function 'rtiNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,242,style,unusedFunction,The function 'sciNotification' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,701,style,unusedFunction,The function 'setBootloaderFlag' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,129,style,unusedFunction,The function 'setCPLDLampBlue' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,107,style,unusedFunction,The function 'setCPLDLampGreen' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,151,style,unusedFunction,The function 'setCPLDLampRed' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,291,style,unusedFunction,The function 'setCriticalData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,567,style,unusedFunction,The function 'setDisinfectionDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'setMfgData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,396,style,unusedFunction,The function 'setServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,489,style,unusedFunction,The function 'setTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,528,style,unusedFunction,The function 'setWaterConsumption' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,230,style,unusedFunction,The function 'stopDrainCmd' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,179,style,unusedFunction,The function 'stopFillCmd' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,386,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,480,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,433,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,363,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,457,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,410,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,443,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)