Index: results/cppcheckError.csv =================================================================== diff -u -r43fcf6140ca7b3ec665067653a7d64dce65d71d4 -r5cfa1f3d17db625f92f046868812717e3f1f51c3 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 43fcf6140ca7b3ec665067653a7d64dce65d71d4) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 5cfa1f3d17db625f92f046868812717e3f1f51c3) @@ -8,13 +8,14 @@ dgfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,272,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1529,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1533,style,variableScope,The scope of the variable 'i' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/RTC.c,769,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,770,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1538,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1539,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1542,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,1203,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/RTC.c,777,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,778,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,700,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/Utilities.c,191,style,variableScope,The scope of the variable 'timeInMS' can be reduced. dgfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. dgfirmware/firmware/App/Drivers/InternalADC.c,119,style,unusedFunction,The function 'adcNotification' is never used. @@ -24,13 +25,13 @@ dgfirmware/firmware/App/Services/Interrupts.c,225,style,unusedFunction,The function 'dmaGroupANotification' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,77,style,unusedFunction,The function 'execAlarmMgmt' is never used. dgfirmware/firmware/App/Controllers/DrainPump.c,384,style,unusedFunction,The function 'execDrainPumpTest' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,728,style,unusedFunction,The function 'execNVDataMgmt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,732,style,unusedFunction,The function 'execNVDataMgmt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,606,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. dgfirmware/firmware/App/Controllers/Pressures.c,327,style,unusedFunction,The function 'execPressuresTest' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,505,style,unusedFunction,The function 'execROPumpTest' is never used. -dgfirmware/firmware/FWCommon/RTC.c,354,style,unusedFunction,The function 'execRTC' is never used. +dgfirmware/firmware/FWCommon/RTC.c,358,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/RTC.c,300,style,unusedFunction,The function 'execRTCSelfTest' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,714,style,unusedFunction,The function 'getBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,718,style,unusedFunction,The function 'getBootloaderFlag' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,356,style,unusedFunction,The function 'getCalibrationData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,95,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. dgfirmware/firmware/App/Modes/ModeDrain.c,152,style,unusedFunction,The function 'getCurrentDrainState' is never used. @@ -49,7 +50,7 @@ dgfirmware/firmware/App/Services/FPGA.c,991,style,unusedFunction,The function 'getFPGAStatus' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'getMfgData' is never used. dgfirmware/firmware/App/Services/PIControllers.c,193,style,unusedFunction,The function 'getPIControllerSignals' is never used. -dgfirmware/firmware/FWCommon/RTC.c,410,style,unusedFunction,The function 'getRTCTimestamp' is never used. +dgfirmware/firmware/FWCommon/RTC.c,418,style,unusedFunction,The function 'getRTCTimestamp' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,405,style,unusedFunction,The function 'getServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,502,style,unusedFunction,The function 'getTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,542,style,unusedFunction,The function 'getWaterConsumption' is never used. @@ -62,7 +63,7 @@ dgfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,452,style,unusedFunction,The function 'readLogData' is never used. dgfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,691,style,unusedFunction,The function 'setBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,695,style,unusedFunction,The function 'setBootloaderFlag' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,132,style,unusedFunction,The function 'setCPLDLampBlue' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,110,style,unusedFunction,The function 'setCPLDLampGreen' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,154,style,unusedFunction,The function 'setCPLDLampRed' is never used.