Index: results/cppcheckError.csv =================================================================== diff -u -r60e256a48cac7adbbdf5b51b2c1f2357436db103 -r8d0fc6d479a5191202d54f739d333f1001976ab7 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 60e256a48cac7adbbdf5b51b2c1f2357436db103) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 8d0fc6d479a5191202d54f739d333f1001976ab7) @@ -2,33 +2,35 @@ dgfirmware/firmware/App/Controllers/ConcentratePumps.c,360,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Controllers/ConcentratePumps.c,273,style,unreadVariable,Variable 'cp1Parked' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ConcentratePumps.c,274,style,unreadVariable,Variable 'cp2ParkFault' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ConductivitySensors.c,768,style,redundantAssignment,Variable 'conductivity' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/ConductivitySensors.c,321,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/ConductivitySensors.c,782,style,redundantAssignment,Variable 'conductivity' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Controllers/FlowSensors.c,105,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Controllers/Thermistors.c,120,style,redundantAssignment,Variable 'status' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFlush.c,344,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeInitPOST.c,362,warning,selfAssignment,Redundant assignment of 'systemREG1->SYSESR' to itself. dgfirmware/firmware/App/Services/PIControllers.c,297,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/SystemCommMessages.c,650,style,redundantAssignment,Variable 'acidConcMixRatio' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,651,style,redundantAssignment,Variable 'bicarbConcMixRatio' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/Integrity.c,137,style,variableScope,The scope of the variable 'err1' can be reduced. dgfirmware/firmware/FWCommon/Integrity.c,137,style,variableScope,The scope of the variable 'err2' can be reduced. dgfirmware/firmware/FWCommon/Integrity.c,190,style,variableScope,The scope of the variable 'remainingSize' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,2303,style,variableScope,The scope of the variable 'length' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,2546,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,2547,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,2550,style,variableScope,The scope of the variable 'i' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,910,style,unreadVariable,Variable 'scheduleStatus' is assigned a value that is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1010,style,unusedVariable,Unused variable: i -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1761,style,redundantAssignment,Variable 'haveCalGroupsPassed' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1762,style,redundantAssignment,Variable 'hasSystemRecordPassed' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1763,style,redundantAssignment,Variable 'hasServiceRecordPassed' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1764,style,redundantAssignment,Variable 'hasUsageRecordPassed' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1766,style,redundantAssignment,Variable 'hasSWConfigRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2312,style,variableScope,The scope of the variable 'length' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2555,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2556,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2559,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,911,style,unreadVariable,Variable 'scheduleStatus' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1011,style,unusedVariable,Unused variable: i dgfirmware/firmware/FWCommon/NVDataMgmt.c,1770,style,redundantAssignment,Variable 'haveCalGroupsPassed' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1771,style,redundantAssignment,Variable 'hasSystemRecordPassed' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1772,style,redundantAssignment,Variable 'hasServiceRecordPassed' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1773,style,redundantAssignment,Variable 'hasUsageRecordPassed' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1775,style,redundantAssignment,Variable 'hasSWConfigRecordPassed' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,4015,style,unreadVariable,Variable 'checkUIStatus' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1779,style,redundantAssignment,Variable 'haveCalGroupsPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1780,style,redundantAssignment,Variable 'hasSystemRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1781,style,redundantAssignment,Variable 'hasServiceRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1782,style,redundantAssignment,Variable 'hasUsageRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1784,style,redundantAssignment,Variable 'hasSWConfigRecordPassed' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/RTC.c,358,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/RTC.c,898,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. dgfirmware/firmware/FWCommon/RTC.c,899,style,variableScope,The scope of the variable 'decimalLow' can be reduced. @@ -45,9 +47,9 @@ dgfirmware/firmware/App/Services/Interrupts.c,124,style,unusedFunction,The function 'canMessageNotification' is never used. dgfirmware/firmware/FWCommon/PersistentAlarm.c,329,style,unusedFunction,The function 'checkFPGAPersistentErrorCountAlarm' is never used. dgfirmware/firmware/App/Drivers/Comm.c,133,style,unusedFunction,The function 'clearSCI2CommErrors' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,2608,style,unusedFunction,The function 'dequeue' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2617,style,unusedFunction,The function 'dequeue' is never used. dgfirmware/firmware/App/Services/Interrupts.c,219,style,unusedFunction,The function 'dmaGroupANotification' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1636,style,unusedFunction,The function 'enqueueNVRecordsForRead' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1645,style,unusedFunction,The function 'enqueueNVRecordsForRead' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,570,style,unusedFunction,The function 'execROPumpSelfTest' is never used. dgfirmware/firmware/FWCommon/Utilities.c,470,style,unusedFunction,The function 'getCriticalData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c,302,style,unusedFunction,The function 'getCurrentChemicalDisinfectFlushState' is never used. @@ -61,7 +63,7 @@ dgfirmware/firmware/App/Modes/ModeROPermeateSample.c,256,style,unusedFunction,The function 'getCurrentROPermeateSampleState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,96,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,122,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,879,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,881,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/App/Services/FPGA.c,2217,style,unusedFunction,The function 'getFPGAADC1ErrorCount' is never used. dgfirmware/firmware/App/Services/FPGA.c,2241,style,unusedFunction,The function 'getFPGAADC2ErrorCount' is never used. dgfirmware/firmware/App/Services/FPGA.c,2372,style,unusedFunction,The function 'getFPGABaroErrorCount' is never used. @@ -77,34 +79,34 @@ dgfirmware/firmware/App/Services/FPGA.c,1608,style,unusedFunction,The function 'getFPGATRoErrorCount' is never used. dgfirmware/firmware/App/Services/FPGA.c,1721,style,unusedFunction,The function 'getFPGATrimmerHeaterFlags' is never used. dgfirmware/firmware/App/Services/FPGA.c,1734,style,unusedFunction,The function 'getFPGATrimmerHeaterReadCount' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,645,style,unusedFunction,The function 'getFlushLineVolumeL' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,612,style,unusedFunction,The function 'getFlushLineVolumeL' is never used. dgfirmware/firmware/App/Controllers/LoadCell.c,495,style,unusedFunction,The function 'getLoadCellVelocity' is never used. dgfirmware/firmware/App/Services/PIControllers.c,231,style,unusedFunction,The function 'getPIControllerSignals' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,793,style,unusedFunction,The function 'getReservoirsCalRecord' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,819,style,unusedFunction,The function 'getReservoirsCalRecord' is never used. dgfirmware/firmware/FWCommon/TestSupport.c,94,style,unusedFunction,The function 'getS32OverrideValue' is never used. dgfirmware/firmware/FWCommon/TestSupport.c,51,style,unusedFunction,The function 'getU08OverrideValue' is never used. -dgfirmware/firmware/App/Services/SystemCommMessages.c,898,style,unusedFunction,The function 'handleDGScheduledRunsRequest' is never used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,896,style,unusedFunction,The function 'handleDGScheduledRunsRequest' is never used. dgfirmware/firmware/FWCommon/Utilities.c,677,style,unusedFunction,The function 'isCriticalDataSet' is never used. dgfirmware/firmware/App/Controllers/Valves.c,501,style,unusedFunction,The function 'isFliterFlushRequired' is never used. dgfirmware/firmware/App/Drivers/Comm.c,147,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Services/Interrupts.c,76,style,unusedFunction,The function 'phantomInterrupt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1404,style,unusedFunction,The function 'readLogData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1413,style,unusedFunction,The function 'readLogData' is never used. dgfirmware/firmware/FWCommon/Utilities.c,585,style,unusedFunction,The function 'resetCriticalData' is never used. dgfirmware/firmware/App/Controllers/LoadCell.c,396,style,unusedFunction,The function 'resetLoadCellOffset' is never used. dgfirmware/firmware/App/Services/Interrupts.c,89,style,unusedFunction,The function 'rtiNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,189,style,unusedFunction,The function 'sciNotification' is never used. dgfirmware/firmware/FWCommon/Utilities.c,545,style,unusedFunction,The function 'setCriticalData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1593,style,unusedFunction,The function 'setHeatersInfoRecord' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1602,style,unusedFunction,The function 'setHeatersInfoRecord' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,869,style,unusedFunction,The function 'setROPIFlowProfile' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,288,style,unusedFunction,The function 'setROPumpTargetFlowRateDelayed' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1457,style,unusedFunction,The function 'setTxLastStartTimeEpoch' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1426,style,unusedFunction,The function 'setTxTimeHours' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1466,style,unusedFunction,The function 'setTxLastStartTimeEpoch' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1435,style,unusedFunction,The function 'setTxTimeHours' is never used. dgfirmware/firmware/FWCommon/RTC.c,511,style,unusedFunction,The function 'syncDG2HDDateTime' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,1087,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,1132,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,1066,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,1110,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1113,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1158,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1092,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1136,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. dgfirmware/firmware/FWCommon/Utilities.c,345,style,unusedFunction,The function 'u16BiDiffWithWrap' is never used. dgfirmware/firmware/FWCommon/Utilities.c,296,style,unusedFunction,The function 'u32BiDiffWithWrap' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1380,style,unusedFunction,The function 'writeLogData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1389,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)