Index: results/cppcheckError.csv =================================================================== diff -u -r70bc28173fda2adb7541026630f40e37438a4d50 -r374bab15ea30aba82ee139e8a494764db312f468 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 70bc28173fda2adb7541026630f40e37438a4d50) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 374bab15ea30aba82ee139e8a494764db312f468) @@ -1,90 +1,89 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/DrainPump.c,173,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,347,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,348,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,349,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,525,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,656,style,unusedVariable,Unused variable: largestDelta -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,657,style,unusedVariable,Unused variable: i -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,657,style,unusedVariable,Unused variable: j -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,748,style,unreadVariable,Variable 'inletTemperature' is assigned a value that is never used. -dgfirmware/firmware/App/Services/Interrupts.c,171,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,78,style,variableScope,The scope of the variable 'controller' can be reduced. -dgfirmware/firmware/App/Services/Reservoirs.c,258,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/DrainPump.c,166,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/Fans.c,222,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/Fans.c,318,style,redundantAssignment,Variable 'temperature' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/ROPump.c,338,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,339,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,340,style,unusedVariable,Unused variable: newPWM +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,578,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,163,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,199,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,231,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/Reservoirs.c,269,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1531,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1532,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1535,style,variableScope,The scope of the variable 'i' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,1178,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/RTC.c,764,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,765,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,689,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -dgfirmware/firmware/FWCommon/Utilities.c,214,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1567,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1570,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/Utilities.c,246,style,variableScope,The scope of the variable 'timeInMS' can be reduced. dgfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -dgfirmware/firmware/App/Drivers/InternalADC.c,118,style,unusedFunction,The function 'adcNotification' is never used. -dgfirmware/firmware/FWCommon/Timers.c,147,style,unusedFunction,The function 'calcTimeBetween' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,168,style,unusedFunction,The function 'canErrorNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,147,style,unusedFunction,The function 'canMessageNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,313,style,unusedFunction,The function 'dmaGroupANotification' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,75,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,398,style,unusedFunction,The function 'execDrainPumpTest' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,736,style,unusedFunction,The function 'execNVDataMgmt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,613,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/Pressures.c,327,style,unusedFunction,The function 'execPressuresTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,502,style,unusedFunction,The function 'execROPumpTest' is never used. -dgfirmware/firmware/FWCommon/RTC.c,355,style,unusedFunction,The function 'execRTC' is never used. -dgfirmware/firmware/FWCommon/RTC.c,298,style,unusedFunction,The function 'execRTCSelfTest' is never used. -dgfirmware/firmware/FWCommon/Accel.c,669,style,unusedFunction,The function 'getAccelCalibration' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,723,style,unusedFunction,The function 'getBootloaderFlag' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,254,style,unusedFunction,The function 'getCriticalData' is never used. -dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,95,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeDrain.c,143,style,unusedFunction,The function 'getCurrentDrainState' is never used. -dgfirmware/firmware/App/Modes/ModeFault.c,93,style,unusedFunction,The function 'getCurrentFaultState' is never used. -dgfirmware/firmware/App/Modes/ModeFill.c,181,style,unusedFunction,The function 'getCurrentFillState' is never used. -dgfirmware/firmware/App/Modes/ModeFlush.c,95,style,unusedFunction,The function 'getCurrentFlushState' is never used. -dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,94,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,221,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. -dgfirmware/firmware/App/Modes/ModeService.c,93,style,unusedFunction,The function 'getCurrentServiceState' is never used. -dgfirmware/firmware/App/Modes/ModeSolo.c,125,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,237,style,unusedFunction,The function 'getCurrentStandbyState' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,592,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/App/Services/FPGA.c,942,style,unusedFunction,The function 'getFPGAId' is never used. -dgfirmware/firmware/App/Services/FPGA.c,956,style,unusedFunction,The function 'getFPGARev' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,328,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,190,style,unusedFunction,The function 'getPIControllerSignals' is never used. -dgfirmware/firmware/FWCommon/RTC.c,414,style,unusedFunction,The function 'getRTCTimestamp' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,421,style,unusedFunction,The function 'getServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,514,style,unusedFunction,The function 'getTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,552,style,unusedFunction,The function 'getWaterConsumption' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,273,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,259,style,unusedFunction,The function 'isAlarmActive' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,167,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,181,style,unusedFunction,The function 'isPOSTPassed' is never used. -dgfirmware/firmware/App/Drivers/Comm.c,276,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -dgfirmware/firmware/App/Drivers/SafetyShutdown.c,75,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,88,style,unusedFunction,The function 'phantomInterrupt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,466,style,unusedFunction,The function 'readLogData' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,320,style,unusedFunction,The function 'resetCriticalData' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,111,style,unusedFunction,The function 'rtiNotification' is never used. +dgfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. +dgfirmware/firmware/FWCommon/Timers.c,141,style,unusedFunction,The function 'calcTimeBetween' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,169,style,unusedFunction,The function 'canErrorNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,148,style,unusedFunction,The function 'canMessageNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,312,style,unusedFunction,The function 'dmaGroupANotification' is never used. +dgfirmware/firmware/App/Services/AlarmMgmt.c,70,style,unusedFunction,The function 'execAlarmMgmt' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,381,style,unusedFunction,The function 'execDrainPumpTest' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,776,style,unusedFunction,The function 'execNVDataMgmt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,655,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,482,style,unusedFunction,The function 'execROPumpTest' is never used. +dgfirmware/firmware/FWCommon/RTC.c,364,style,unusedFunction,The function 'execRTC' is never used. +dgfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,285,style,unusedFunction,The function 'getCriticalData' is never used. +dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,94,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeDrain.c,139,style,unusedFunction,The function 'getCurrentDrainState' is never used. +dgfirmware/firmware/App/Modes/ModeFault.c,88,style,unusedFunction,The function 'getCurrentFaultState' is never used. +dgfirmware/firmware/App/Modes/ModeFlush.c,92,style,unusedFunction,The function 'getCurrentFlushState' is never used. +dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,93,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,241,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeService.c,88,style,unusedFunction,The function 'getCurrentServiceState' is never used. +dgfirmware/firmware/App/Modes/ModeSolo.c,118,style,unusedFunction,The function 'getCurrentSoloState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,190,style,unusedFunction,The function 'getMeasuredFanRPM' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,188,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,1480,style,unusedFunction,The function 'handleTestROPumpSetPointOverrideRequest' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,287,style,unusedFunction,The function 'initNVDataMgmt' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,191,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,204,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Drivers/Comm.c,259,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +dgfirmware/firmware/App/Drivers/SafetyShutdown.c,71,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,91,style,unusedFunction,The function 'phantomInterrupt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,511,style,unusedFunction,The function 'readLogData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,400,style,unusedFunction,The function 'resetCriticalData' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,113,style,unusedFunction,The function 'rtiNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,242,style,unusedFunction,The function 'sciNotification' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,701,style,unusedFunction,The function 'setBootloaderFlag' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,129,style,unusedFunction,The function 'setCPLDLampBlue' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,107,style,unusedFunction,The function 'setCPLDLampGreen' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,151,style,unusedFunction,The function 'setCPLDLampRed' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,291,style,unusedFunction,The function 'setCriticalData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,567,style,unusedFunction,The function 'setDisinfectionDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'setMfgData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,396,style,unusedFunction,The function 'setServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,489,style,unusedFunction,The function 'setTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,528,style,unusedFunction,The function 'setWaterConsumption' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,230,style,unusedFunction,The function 'stopDrainCmd' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,179,style,unusedFunction,The function 'stopFillCmd' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,386,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,480,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,433,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,363,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,457,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,410,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,443,style,unusedFunction,The function 'writeLogData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'setBootloaderFlag' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,122,style,unusedFunction,The function 'setCPLDLampBlue' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,102,style,unusedFunction,The function 'setCPLDLampGreen' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,142,style,unusedFunction,The function 'setCPLDLampRed' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,360,style,unusedFunction,The function 'setCriticalData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'setDisinfectionDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,323,style,unusedFunction,The function 'setMfgData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,440,style,unusedFunction,The function 'setServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,534,style,unusedFunction,The function 'setTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,572,style,unusedFunction,The function 'setWaterConsumption' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,242,style,unusedFunction,The function 'stopDrainCmd' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,192,style,unusedFunction,The function 'stopFillCmd' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'testResetCalibrationData' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,476,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,566,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,521,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,455,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,544,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,499,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,161,style,unusedFunction,The function 'u32DiffWithWrap' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,487,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)