Index: results/cppcheckError.csv =================================================================== diff -u -r70bc28173fda2adb7541026630f40e37438a4d50 -rf308cc4c35eab630ebbbde405cfe47d049afeafb --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 70bc28173fda2adb7541026630f40e37438a4d50) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision f308cc4c35eab630ebbbde405cfe47d049afeafb) @@ -3,13 +3,10 @@ dgfirmware/firmware/App/Controllers/ROPump.c,347,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,348,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,349,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,525,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,656,style,unusedVariable,Unused variable: largestDelta -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,657,style,unusedVariable,Unused variable: i -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,657,style,unusedVariable,Unused variable: j -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,748,style,unreadVariable,Variable 'inletTemperature' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,571,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,119,warning,redundantAssignInSwitch,Variable 'testStatus' is reassigned a value before the old one has been used. 'break;' missing? dgfirmware/firmware/App/Services/Interrupts.c,171,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,78,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,258,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1531,style,variableScope,The scope of the variable 'quotient' can be reduced. @@ -31,36 +28,36 @@ dgfirmware/firmware/App/Controllers/DrainPump.c,398,style,unusedFunction,The function 'execDrainPumpTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,736,style,unusedFunction,The function 'execNVDataMgmt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,613,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/Pressures.c,327,style,unusedFunction,The function 'execPressuresTest' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,502,style,unusedFunction,The function 'execROPumpTest' is never used. dgfirmware/firmware/FWCommon/RTC.c,355,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/RTC.c,298,style,unusedFunction,The function 'execRTCSelfTest' is never used. -dgfirmware/firmware/FWCommon/Accel.c,669,style,unusedFunction,The function 'getAccelCalibration' is never used. +dgfirmware/firmware/FWCommon/Accel.c,670,style,unusedFunction,The function 'getAccelCalibration' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,723,style,unusedFunction,The function 'getBootloaderFlag' is never used. dgfirmware/firmware/FWCommon/Utilities.c,254,style,unusedFunction,The function 'getCriticalData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,95,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeDrain.c,143,style,unusedFunction,The function 'getCurrentDrainState' is never used. +dgfirmware/firmware/App/Modes/ModeDrain.c,151,style,unusedFunction,The function 'getCurrentDrainState' is never used. dgfirmware/firmware/App/Modes/ModeFault.c,93,style,unusedFunction,The function 'getCurrentFaultState' is never used. -dgfirmware/firmware/App/Modes/ModeFill.c,181,style,unusedFunction,The function 'getCurrentFillState' is never used. +dgfirmware/firmware/App/Modes/ModeFill.c,188,style,unusedFunction,The function 'getCurrentFillState' is never used. dgfirmware/firmware/App/Modes/ModeFlush.c,95,style,unusedFunction,The function 'getCurrentFlushState' is never used. dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,94,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,221,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,93,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,125,style,unusedFunction,The function 'getCurrentSoloState' is never used. dgfirmware/firmware/App/Modes/ModeStandby.c,237,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,592,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/App/Services/FPGA.c,942,style,unusedFunction,The function 'getFPGAId' is never used. -dgfirmware/firmware/App/Services/FPGA.c,956,style,unusedFunction,The function 'getFPGARev' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1491,style,unusedFunction,The function 'getFPGACPo' is never used. +dgfirmware/firmware/App/Services/FPGA.c,946,style,unusedFunction,The function 'getFPGAId' is never used. +dgfirmware/firmware/App/Services/FPGA.c,960,style,unusedFunction,The function 'getFPGARev' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,328,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,190,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,189,style,unusedFunction,The function 'getPIControllerSignals' is never used. dgfirmware/firmware/FWCommon/RTC.c,414,style,unusedFunction,The function 'getRTCTimestamp' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,421,style,unusedFunction,The function 'getServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,514,style,unusedFunction,The function 'getTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,552,style,unusedFunction,The function 'getWaterConsumption' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,273,style,unusedFunction,The function 'initNVDataMgmt' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,259,style,unusedFunction,The function 'isAlarmActive' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,167,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,181,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,171,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. dgfirmware/firmware/App/Drivers/Comm.c,276,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Drivers/SafetyShutdown.c,75,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,88,style,unusedFunction,The function 'phantomInterrupt' is never used.