Index: results/cppcheckError.csv =================================================================== diff -u -re8617763b12323b6719fe7cd8871375736e43c67 -rf0f670ddd7f5f16ca79f45b5dff58283f163f13f --- results/cppcheckError.csv (.../cppcheckError.csv) (revision e8617763b12323b6719fe7cd8871375736e43c67) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision f0f670ddd7f5f16ca79f45b5dff58283f163f13f) @@ -1,11 +1,11 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/DrainPump.c,167,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,349,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,350,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,351,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,511,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/DrainPump.c,168,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,350,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,351,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,352,style,unusedVariable,Unused variable: newPWM +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,512,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,80,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,272,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1529,style,variableScope,The scope of the variable 'quotient' can be reduced. @@ -17,54 +17,55 @@ dgfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. dgfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -dgfirmware/firmware/App/Drivers/InternalADC.c,118,style,unusedFunction,The function 'adcNotification' is never used. +dgfirmware/firmware/App/Drivers/InternalADC.c,119,style,unusedFunction,The function 'adcNotification' is never used. dgfirmware/firmware/FWCommon/Timers.c,146,style,unusedFunction,The function 'calcTimeBetween' is never used. dgfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,225,style,unusedFunction,The function 'dmaGroupANotification' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,78,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,383,style,unusedFunction,The function 'execDrainPumpTest' is never used. +dgfirmware/firmware/App/Services/AlarmMgmt.c,77,style,unusedFunction,The function 'execAlarmMgmt' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,384,style,unusedFunction,The function 'execDrainPumpTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,728,style,unusedFunction,The function 'execNVDataMgmt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,606,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/Pressures.c,326,style,unusedFunction,The function 'execPressuresTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,504,style,unusedFunction,The function 'execROPumpTest' is never used. +dgfirmware/firmware/App/Controllers/Pressures.c,327,style,unusedFunction,The function 'execPressuresTest' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,505,style,unusedFunction,The function 'execROPumpTest' is never used. dgfirmware/firmware/FWCommon/RTC.c,354,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/RTC.c,300,style,unusedFunction,The function 'execRTCSelfTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,714,style,unusedFunction,The function 'getBootloaderFlag' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,356,style,unusedFunction,The function 'getCalibrationData' is never used. -dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,94,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeDrain.c,146,style,unusedFunction,The function 'getCurrentDrainState' is never used. -dgfirmware/firmware/App/Modes/ModeFault.c,92,style,unusedFunction,The function 'getCurrentFaultState' is never used. -dgfirmware/firmware/App/Modes/ModeFill.c,186,style,unusedFunction,The function 'getCurrentFillState' is never used. -dgfirmware/firmware/App/Modes/ModeFlush.c,94,style,unusedFunction,The function 'getCurrentFlushState' is never used. -dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,93,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,209,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. -dgfirmware/firmware/App/Modes/ModeService.c,92,style,unusedFunction,The function 'getCurrentServiceState' is never used. -dgfirmware/firmware/App/Modes/ModeSolo.c,94,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,95,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeDrain.c,152,style,unusedFunction,The function 'getCurrentDrainState' is never used. +dgfirmware/firmware/App/Modes/ModeFault.c,93,style,unusedFunction,The function 'getCurrentFaultState' is never used. +dgfirmware/firmware/App/Modes/ModeFill.c,192,style,unusedFunction,The function 'getCurrentFillState' is never used. +dgfirmware/firmware/App/Modes/ModeFlush.c,95,style,unusedFunction,The function 'getCurrentFlushState' is never used. +dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,94,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,210,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeService.c,93,style,unusedFunction,The function 'getCurrentServiceState' is never used. +dgfirmware/firmware/App/Modes/ModeSolo.c,95,style,unusedFunction,The function 'getCurrentSoloState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,235,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,584,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/App/Services/FPGA.c,958,style,unusedFunction,The function 'getFPGAId' is never used. -dgfirmware/firmware/App/Services/FPGA.c,973,style,unusedFunction,The function 'getFPGARev' is never used. -dgfirmware/firmware/App/Services/FPGA.c,988,style,unusedFunction,The function 'getFPGAStatus' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1477,style,unusedFunction,The function 'getFPGACPo' is never used. +dgfirmware/firmware/App/Services/FPGA.c,961,style,unusedFunction,The function 'getFPGAId' is never used. +dgfirmware/firmware/App/Services/FPGA.c,976,style,unusedFunction,The function 'getFPGARev' is never used. +dgfirmware/firmware/App/Services/FPGA.c,991,style,unusedFunction,The function 'getFPGAStatus' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,193,style,unusedFunction,The function 'getPIControllerSignals' is never used. dgfirmware/firmware/FWCommon/RTC.c,410,style,unusedFunction,The function 'getRTCTimestamp' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,405,style,unusedFunction,The function 'getServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,502,style,unusedFunction,The function 'getTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,542,style,unusedFunction,The function 'getWaterConsumption' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,269,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,255,style,unusedFunction,The function 'isAlarmActive' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,155,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,169,style,unusedFunction,The function 'isPOSTPassed' is never used. -dgfirmware/firmware/App/Drivers/Comm.c,291,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -dgfirmware/firmware/App/Drivers/SafetyShutdown.c,74,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +dgfirmware/firmware/App/Services/AlarmMgmt.c,254,style,unusedFunction,The function 'isAlarmActive' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,156,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Drivers/Comm.c,292,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +dgfirmware/firmware/App/Drivers/SafetyShutdown.c,75,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,452,style,unusedFunction,The function 'readLogData' is never used. dgfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,691,style,unusedFunction,The function 'setBootloaderFlag' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,131,style,unusedFunction,The function 'setCPLDLampBlue' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,109,style,unusedFunction,The function 'setCPLDLampGreen' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,153,style,unusedFunction,The function 'setCPLDLampRed' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,132,style,unusedFunction,The function 'setCPLDLampBlue' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,110,style,unusedFunction,The function 'setCPLDLampGreen' is never used. +dgfirmware/firmware/App/Drivers/CPLD.c,154,style,unusedFunction,The function 'setCPLDLampRed' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'setCalibrationData' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'setDisinfectionDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,293,style,unusedFunction,The function 'setMfgData' is never used. @@ -73,9 +74,9 @@ dgfirmware/firmware/FWCommon/NVDataMgmt.c,517,style,unusedFunction,The function 'setWaterConsumption' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,244,style,unusedFunction,The function 'stopDrainCmd' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,193,style,unusedFunction,The function 'stopFillCmd' is never used. -dgfirmware/firmware/App/Tasks/TaskGeneral.c,41,style,unusedFunction,The function 'taskGeneral' is never used. -dgfirmware/firmware/App/Tasks/TaskPriority.c,40,style,unusedFunction,The function 'taskPriority' is never used. -dgfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. +dgfirmware/firmware/App/Tasks/TaskGeneral.c,42,style,unusedFunction,The function 'taskGeneral' is never used. +dgfirmware/firmware/App/Tasks/TaskPriority.c,42,style,unusedFunction,The function 'taskPriority' is never used. +dgfirmware/firmware/App/Tasks/TaskTimer.c,33,style,unusedFunction,The function 'taskTimer' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,400,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,494,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,447,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used.