Index: results/Build_Status_Report.csv =================================================================== diff -u -r0a1b366b3512834fe972c5835597e337baf67669 -r60e256a48cac7adbbdf5b51b2c1f2357436db103 --- results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision 0a1b366b3512834fe972c5835597e337baf67669) +++ results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision 60e256a48cac7adbbdf5b51b2c1f2357436db103) @@ -1,88 +1,14 @@ -Running Project, dgfirmware -Date, Thu Dec 10 16:22:41 PST 2020 +Running Project, +Date, Tue Oct 17 22:19:48 PDT 2023 VectorCAST Pass/Fail Status, Passed -Unit Test Coverage, Passed - - -Integration Test Coverage, Passed - -Integration Test Manual Cases -Module, Function Name -comm,isSCI2DMATransmitInProgress -modeservice,getCurrentServiceState -systemcommmessages,broadcastAlarmTriggered -systemcommmessages,broadcastAlarmCleared -systemcommmessages,broadcastAccelData -systemcommmessages,broadcastRTCEpoch -systemcommmessages,broadcastLoadCellData -systemcommmessages,broadcastValvesStates -systemcommmessages,broadcastHeatersData -systemcommmessages,broadcastDrainPumpData -systemcommmessages,broadcastDGOperationMode -systemcommmessages,broadcastROPumpData -systemcommmessages,broadcastPressureSensorsData -systemcommmessages,broadcastReservoirData -systemcommmessages,broadcastTemperatureSensorsData -systemcommmessages,broadcastThermistorsData -systemcommmessages,broadcastFansData -systemcommmessages,broadcastUVReactorsData -accel,getAccelCalibration -reservoirs,stopFillCmd -reservoirs,stopDrainCmd -reservoirs,testSetDGActiveReservoirOverride -reservoirs,testResetDGActiveReservoirOverride -reservoirs,testSetReservoirFillVolumeMlOverride -reservoirs,testResetReservoirFillVolumeMlOverride -reservoirs,testSetReservoirDrainVolumeMlOverride -reservoirs,testResetReservoirDrainVolumeMlOverride -modesolo,getCurrentSoloState -modefault,getCurrentFaultState -utilities,u32DiffWithWrap -utilities,getCriticalData -utilities,isCriticalDataInRange -utilities,setCriticalData -utilities,resetCriticalData -safetyshutdown,isSafetyShutdownActivated -modechemicaldisinfect,getCurrentChemicalDisinfectState -modestandby,getCurrentStandbyState -modeinitpost,isPOSTCompleted -modeinitpost,isPOSTPassed -modeinitpost,getCurrentInitAndPOSTState -interrupts,phantomInterrupt -modeflush,getCurrentFlushState -ropump,execROPumpTest -cpld,setCPLDLampGreen -cpld,setCPLDLampBlue -cpld,setCPLDLampRed -modeheatdisinfect,getCurrentHeatDisinfectState -fans,getMeasuredFanRPM -alarmmgmt,execAlarmMgmt -alarmmgmt,isAlarmActive -picontrollers,getPIControllerSignals -timers,calcTimeBetween -modedrain,getCurrentDrainState -rtc,execRTC -rtc,getRTCTimestamp -rtc,isRTCFunctional -rtc,convertBCD2Decimal -rtc,convertDecimal2BCD -rtc,convertTime2Epoch -rtc,updateReadTimestampStruct -rtc,handleExecWaitForPostState -rtc,handleExecIdleState -rtc,handleExecWriteState -rtc,handleExecPrepRAMState -rtc,handleExecWriteToRAMState -rtc,handleExecReadFromRAMState -rtc,handleExecReadState - List of Untested Modules -NVDataMgmt, Missing Integration Test +ModeROPermeateSample, Missing Unit Test and Integration Test +alarmCheck, Missing Unit Test and Integration Test irqDispatch_c, Missing Unit Test and Integration Test CppCheck, Passed -Cppcheck No. of Warnings, 0 +Cppcheck No. of Warnings, 1 Fisheye: Tag 60e256a48cac7adbbdf5b51b2c1f2357436db103 refers to a dead (removed) revision in file `results/VectorCAST.log'. Fisheye: No comparison available. Pass `N' to diff? Index: results/cppcheck.log =================================================================== diff -u -r88f28230d288947ba84840b967e95b32e3deffaa -r60e256a48cac7adbbdf5b51b2c1f2357436db103 --- results/cppcheck.log (.../cppcheck.log) (revision 88f28230d288947ba84840b967e95b32e3deffaa) +++ results/cppcheck.log (.../cppcheck.log) (revision 60e256a48cac7adbbdf5b51b2c1f2357436db103) @@ -1,120 +1,113 @@ Checking dgfirmware/firmware/App/Controllers/ConcentratePumps.c ... -1/51 files checked 1% done +1/62 files checked 1% done Checking dgfirmware/firmware/App/Controllers/ConductivitySensors.c ... -2/51 files checked 3% done +2/62 files checked 3% done Checking dgfirmware/firmware/App/Controllers/DrainPump.c ... -Checking dgfirmware/firmware/App/Controllers/DrainPump.c: EMC_TEST_BUILD... -3/51 files checked 5% done +3/62 files checked 4% done Checking dgfirmware/firmware/App/Controllers/Fans.c ... -4/51 files checked 7% done +4/62 files checked 6% done +Checking dgfirmware/firmware/App/Controllers/FlowSensors.c ... +5/62 files checked 7% done +Checking dgfirmware/firmware/App/Controllers/FluidLeak.c ... +6/62 files checked 9% done Checking dgfirmware/firmware/App/Controllers/Heaters.c ... -Checking dgfirmware/firmware/App/Controllers/Heaters.c: DEBUG_ENABLED... -Checking dgfirmware/firmware/App/Controllers/Heaters.c: DEBUG_ENABLED;ENABLE_DIP_SWITCHES... -Checking dgfirmware/firmware/App/Controllers/Heaters.c: ENABLE_DIP_SWITCHES... -Checking dgfirmware/firmware/App/Controllers/Heaters.c: _VECTORCAST_... -5/51 files checked 9% done +7/62 files checked 11% done Checking dgfirmware/firmware/App/Controllers/LoadCell.c ... -6/51 files checked 11% done +8/62 files checked 12% done Checking dgfirmware/firmware/App/Controllers/Pressures.c ... -Checking dgfirmware/firmware/App/Controllers/Pressures.c: DEBUG_ENABLED... -Checking dgfirmware/firmware/App/Controllers/Pressures.c: DEBUG_ENABLED;PRESSURES_DEBUG... -7/51 files checked 13% done +9/62 files checked 14% done Checking dgfirmware/firmware/App/Controllers/ROPump.c ... -Checking dgfirmware/firmware/App/Controllers/ROPump.c: EMC_TEST_BUILD... -Checking dgfirmware/firmware/App/Controllers/ROPump.c: ENABLE_DIP_SWITCHES... -8/51 files checked 15% done +10/62 files checked 15% done +Checking dgfirmware/firmware/App/Controllers/Switches.c ... +11/62 files checked 17% done Checking dgfirmware/firmware/App/Controllers/TemperatureSensors.c ... -9/51 files checked 17% done +12/62 files checked 19% done Checking dgfirmware/firmware/App/Controllers/Thermistors.c ... -10/51 files checked 19% done +13/62 files checked 20% done Checking dgfirmware/firmware/App/Controllers/UVReactors.c ... -11/51 files checked 21% done +14/62 files checked 22% done Checking dgfirmware/firmware/App/Controllers/Valves.c ... -12/51 files checked 23% done +15/62 files checked 23% done +Checking dgfirmware/firmware/App/Controllers/Voltages.c ... +16/62 files checked 25% done Checking dgfirmware/firmware/App/Drivers/CPLD.c ... -13/51 files checked 25% done +17/62 files checked 27% done Checking dgfirmware/firmware/App/Drivers/Comm.c ... -Checking dgfirmware/firmware/App/Drivers/Comm.c: DEBUG_ENABLED... -14/51 files checked 27% done +18/62 files checked 28% done Checking dgfirmware/firmware/App/Drivers/InternalADC.c ... -15/51 files checked 29% done +19/62 files checked 30% done Checking dgfirmware/firmware/App/Drivers/SafetyShutdown.c ... -16/51 files checked 30% done +20/62 files checked 31% done Checking dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c ... -17/51 files checked 32% done +21/62 files checked 33% done +Checking dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c ... +22/62 files checked 35% done Checking dgfirmware/firmware/App/Modes/ModeDrain.c ... -18/51 files checked 34% done +23/62 files checked 36% done Checking dgfirmware/firmware/App/Modes/ModeFault.c ... -19/51 files checked 36% done +24/62 files checked 38% done Checking dgfirmware/firmware/App/Modes/ModeFill.c ... -Checking dgfirmware/firmware/App/Modes/ModeFill.c: DISABLE_DIALYSATE_CHECK... -20/51 files checked 38% done +Checking dgfirmware/firmware/App/Modes/ModeFill.c: DEBUG_ENABLED;_RELEASE_;_VECTORCAST_... +25/62 files checked 39% done Checking dgfirmware/firmware/App/Modes/ModeFlush.c ... -21/51 files checked 40% done +26/62 files checked 41% done +Checking dgfirmware/firmware/App/Modes/ModeGenIdle.c ... +27/62 files checked 42% done Checking dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c ... -22/51 files checked 42% done +28/62 files checked 44% done +Checking dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.c ... +29/62 files checked 46% done Checking dgfirmware/firmware/App/Modes/ModeInitPOST.c ... -Checking dgfirmware/firmware/App/Modes/ModeInitPOST.c: DISABLE_ACCELS... -Checking dgfirmware/firmware/App/Modes/ModeInitPOST.c: SKIP_POST... -Checking dgfirmware/firmware/App/Modes/ModeInitPOST.c: _VECTORCAST_... -23/51 files checked 44% done -Checking dgfirmware/firmware/App/Modes/ModeRecirculate.c ... -24/51 files checked 46% done +Checking dgfirmware/firmware/App/Modes/ModeInitPOST.c: BOARD_WITH_NO_HARDWARE... +30/62 files checked 47% done +Checking dgfirmware/firmware/App/Modes/ModeROPermeateSample.c ... +31/62 files checked 49% done Checking dgfirmware/firmware/App/Modes/ModeService.c ... -25/51 files checked 48% done +32/62 files checked 50% done Checking dgfirmware/firmware/App/Modes/ModeSolo.c ... -26/51 files checked 50% done +33/62 files checked 52% done Checking dgfirmware/firmware/App/Modes/ModeStandby.c ... -27/51 files checked 52% done +34/62 files checked 54% done Checking dgfirmware/firmware/App/Modes/OperationModes.c ... -28/51 files checked 54% done +35/62 files checked 55% done Checking dgfirmware/firmware/App/Services/AlarmMgmt.c ... -Checking dgfirmware/firmware/App/Services/AlarmMgmt.c: ALARMS_DEBUG;DEBUG_ENABLED... -Checking dgfirmware/firmware/App/Services/AlarmMgmt.c: DEBUG_ENABLED... -29/51 files checked 56% done +36/62 files checked 57% done Checking dgfirmware/firmware/App/Services/CommBuffers.c ... -Checking dgfirmware/firmware/App/Services/CommBuffers.c: DEBUG_ENABLED... -30/51 files checked 58% done +37/62 files checked 58% done Checking dgfirmware/firmware/App/Services/FPGA.c ... -Checking dgfirmware/firmware/App/Services/FPGA.c: DEBUG_ENABLED... -Checking dgfirmware/firmware/App/Services/FPGA.c: RM46_EVAL_BOARD_TARGET... -31/51 files checked 59% done +38/62 files checked 60% done Checking dgfirmware/firmware/App/Services/Interrupts.c ... -Checking dgfirmware/firmware/App/Services/Interrupts.c: DEBUG_ENABLED... -32/51 files checked 61% done +39/62 files checked 62% done Checking dgfirmware/firmware/App/Services/MsgQueues.c ... -33/51 files checked 63% done +40/62 files checked 63% done Checking dgfirmware/firmware/App/Services/PIControllers.c ... -Checking dgfirmware/firmware/App/Services/PIControllers.c: DEBUG_ENABLED... -34/51 files checked 65% done +41/62 files checked 65% done Checking dgfirmware/firmware/App/Services/Reservoirs.c ... -Checking dgfirmware/firmware/App/Services/Reservoirs.c: DEBUG_ENABLED... -35/51 files checked 67% done +42/62 files checked 66% done Checking dgfirmware/firmware/App/Services/SystemComm.c ... -Checking dgfirmware/firmware/App/Services/SystemComm.c: DEBUG_ENABLED... -36/51 files checked 69% done +43/62 files checked 68% done Checking dgfirmware/firmware/App/Services/SystemCommMessages.c ... -Checking dgfirmware/firmware/App/Services/SystemCommMessages.c: DEBUG_ENABLED... -37/51 files checked 71% done +44/62 files checked 70% done Checking dgfirmware/firmware/App/Services/WatchdogMgmt.c ... -Checking dgfirmware/firmware/App/Services/WatchdogMgmt.c: DEBUG_ENABLED... -38/51 files checked 73% done +45/62 files checked 71% done Checking dgfirmware/firmware/App/Tasks/TaskBG.c ... -39/51 files checked 75% done +46/62 files checked 73% done Checking dgfirmware/firmware/App/Tasks/TaskGeneral.c ... Checking dgfirmware/firmware/App/Tasks/TaskGeneral.c: TASK_TIMING_OUTPUT_ENABLED... -40/51 files checked 77% done +47/62 files checked 74% done Checking dgfirmware/firmware/App/Tasks/TaskPriority.c ... Checking dgfirmware/firmware/App/Tasks/TaskPriority.c: TASK_TIMING_OUTPUT_ENABLED... -41/51 files checked 79% done +48/62 files checked 76% done Checking dgfirmware/firmware/App/Tasks/TaskTimer.c ... Checking dgfirmware/firmware/App/Tasks/TaskTimer.c: TASK_TIMING_OUTPUT_ENABLED... -42/51 files checked 81% done +49/62 files checked 78% done +Checking dgfirmware/firmware/Debug/alarmCheck.c ... +50/62 files checked 79% done Checking dgfirmware/firmware/FWCommon/Accel.c ... Checking dgfirmware/firmware/FWCommon/Accel.c: _DG_... Checking dgfirmware/firmware/FWCommon/Accel.c: _HD_... Checking dgfirmware/firmware/FWCommon/Accel.c: _VECTORCAST_... -43/51 files checked 83% done +51/62 files checked 81% done Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c ... Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: CPU_BYTE_ORDER... Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: F021... @@ -127,34 +120,50 @@ Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: _LITTLE_ENDIAN;__little_endian__... Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: __ARMCC_VERSION... Checking dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: __GNUC__... -44/51 files checked 85% done +52/62 files checked 82% done +Checking dgfirmware/firmware/FWCommon/Integrity.c ... +Checking dgfirmware/firmware/FWCommon/Integrity.c: _DG_... +Checking dgfirmware/firmware/FWCommon/Integrity.c: _HD_... +Checking dgfirmware/firmware/FWCommon/Integrity.c: _VECTORCAST_... +53/62 files checked 84% done +Checking dgfirmware/firmware/FWCommon/MessageSupport.c ... +Checking dgfirmware/firmware/FWCommon/MessageSupport.c: _DG_... +Checking dgfirmware/firmware/FWCommon/MessageSupport.c: _HD_... +54/62 files checked 85% done Checking dgfirmware/firmware/FWCommon/NVDataMgmt.c ... +Checking dgfirmware/firmware/FWCommon/NVDataMgmt.c: ENABLE_LOCAL_LOGGING... Checking dgfirmware/firmware/FWCommon/NVDataMgmt.c: _DG_... Checking dgfirmware/firmware/FWCommon/NVDataMgmt.c: _HD_... Checking dgfirmware/firmware/FWCommon/NVDataMgmt.c: _VECTORCAST_... -45/51 files checked 87% done +55/62 files checked 87% done Checking dgfirmware/firmware/FWCommon/PersistentAlarm.c ... Checking dgfirmware/firmware/FWCommon/PersistentAlarm.c: _DG_... Checking dgfirmware/firmware/FWCommon/PersistentAlarm.c: _HD_... Checking dgfirmware/firmware/FWCommon/PersistentAlarm.c: _VECTORCAST_... -46/51 files checked 88% done +56/62 files checked 89% done Checking dgfirmware/firmware/FWCommon/RTC.c ... Checking dgfirmware/firmware/FWCommon/RTC.c: _DG_... +Checking dgfirmware/firmware/FWCommon/RTC.c: _HD_... Checking dgfirmware/firmware/FWCommon/RTC.c: _VECTORCAST_... -47/51 files checked 90% done +57/62 files checked 90% done +Checking dgfirmware/firmware/FWCommon/TestSupport.c ... +Checking dgfirmware/firmware/FWCommon/TestSupport.c: _DG_... +Checking dgfirmware/firmware/FWCommon/TestSupport.c: _HD_... +Checking dgfirmware/firmware/FWCommon/TestSupport.c: _VECTORCAST_... +58/62 files checked 92% done Checking dgfirmware/firmware/FWCommon/Timers.c ... Checking dgfirmware/firmware/FWCommon/Timers.c: _DG_... Checking dgfirmware/firmware/FWCommon/Timers.c: _VECTORCAST_... -48/51 files checked 92% done +59/62 files checked 93% done Checking dgfirmware/firmware/FWCommon/Utilities.c ... Checking dgfirmware/firmware/FWCommon/Utilities.c: _DG_... Checking dgfirmware/firmware/FWCommon/Utilities.c: _HD_... Checking dgfirmware/firmware/FWCommon/Utilities.c: _VECTORCAST_... -49/51 files checked 94% done +60/62 files checked 95% done Checking dgfirmware/firmware/FWCommon/irqDispatch_c.c ... Checking dgfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_128CH__... Checking dgfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_96CH__... Checking dgfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__... -50/51 files checked 96% done +61/62 files checked 97% done Checking dgfirmware/firmware/source/sys_main.c ... -51/51 files checked 100% done +62/62 files checked 100% done Index: results/cppcheckError.csv =================================================================== diff -u -r00b32a5dad2e136d31cfaf0de16f7767b9920fec -r60e256a48cac7adbbdf5b51b2c1f2357436db103 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 00b32a5dad2e136d31cfaf0de16f7767b9920fec) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 60e256a48cac7adbbdf5b51b2c1f2357436db103) @@ -1,84 +1,110 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/Fans.c,222,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Controllers/Fans.c,318,style,redundantAssignment,Variable 'temperature' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,578,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,270,style,unreadVariable,Variable 'isROPumpFlowRateOutOfRange' is assigned a value that is never used. -dgfirmware/firmware/App/Modes/ModeFill.c,164,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,199,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,231,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,87,style,variableScope,The scope of the variable 'controller' can be reduced. -dgfirmware/firmware/App/Services/Reservoirs.c,269,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/ConcentratePumps.c,360,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/ConcentratePumps.c,273,style,unreadVariable,Variable 'cp1Parked' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ConcentratePumps.c,274,style,unreadVariable,Variable 'cp2ParkFault' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/ConductivitySensors.c,768,style,redundantAssignment,Variable 'conductivity' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/FlowSensors.c,105,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/Thermistors.c,120,style,redundantAssignment,Variable 'status' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFlush.c,344,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,362,warning,selfAssignment,Redundant assignment of 'systemREG1->SYSESR' to itself. +dgfirmware/firmware/App/Services/PIControllers.c,297,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1567,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1570,style,variableScope,The scope of the variable 'i' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -dgfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -dgfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -dgfirmware/firmware/FWCommon/Utilities.c,246,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +dgfirmware/firmware/FWCommon/Integrity.c,137,style,variableScope,The scope of the variable 'err1' can be reduced. +dgfirmware/firmware/FWCommon/Integrity.c,137,style,variableScope,The scope of the variable 'err2' can be reduced. +dgfirmware/firmware/FWCommon/Integrity.c,190,style,variableScope,The scope of the variable 'remainingSize' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2303,style,variableScope,The scope of the variable 'length' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2546,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2547,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2550,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,910,style,unreadVariable,Variable 'scheduleStatus' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1010,style,unusedVariable,Unused variable: i +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1761,style,redundantAssignment,Variable 'haveCalGroupsPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1762,style,redundantAssignment,Variable 'hasSystemRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1763,style,redundantAssignment,Variable 'hasServiceRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1764,style,redundantAssignment,Variable 'hasUsageRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1766,style,redundantAssignment,Variable 'hasSWConfigRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1770,style,redundantAssignment,Variable 'haveCalGroupsPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1771,style,redundantAssignment,Variable 'hasSystemRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1772,style,redundantAssignment,Variable 'hasServiceRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1773,style,redundantAssignment,Variable 'hasUsageRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1775,style,redundantAssignment,Variable 'hasSWConfigRecordPassed' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,4015,style,unreadVariable,Variable 'checkUIStatus' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/RTC.c,358,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +dgfirmware/firmware/FWCommon/RTC.c,898,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,899,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +dgfirmware/firmware/FWCommon/RTC.c,823,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +dgfirmware/firmware/FWCommon/Utilities.c,431,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +dgfirmware/firmware/FWCommon/Utilities.c,607,style,variableScope,The scope of the variable 'ii' can be reduced. +dgfirmware/firmware/FWCommon/Utilities.c,608,style,variableScope,The scope of the variable 'value' can be reduced. +dgfirmware/firmware/FWCommon/Utilities.c,609,style,variableScope,The scope of the variable 'result' can be reduced. dgfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -dgfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. +dgfirmware/firmware/App/Drivers/InternalADC.c,141,style,unusedFunction,The function 'adcNotification' is never used. dgfirmware/firmware/FWCommon/Timers.c,141,style,unusedFunction,The function 'calcTimeBetween' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,169,style,unusedFunction,The function 'canErrorNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,148,style,unusedFunction,The function 'canMessageNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,312,style,unusedFunction,The function 'dmaGroupANotification' is never used. -dgfirmware/firmware/App/Services/AlarmMgmt.c,70,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,776,style,unusedFunction,The function 'execNVDataMgmt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,655,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,397,style,unusedFunction,The function 'execROPumpTest' is never used. -dgfirmware/firmware/FWCommon/RTC.c,364,style,unusedFunction,The function 'execRTC' is never used. -dgfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,285,style,unusedFunction,The function 'getCriticalData' is never used. -dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,94,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeDrain.c,139,style,unusedFunction,The function 'getCurrentDrainState' is never used. -dgfirmware/firmware/App/Modes/ModeFault.c,88,style,unusedFunction,The function 'getCurrentFaultState' is never used. -dgfirmware/firmware/App/Modes/ModeFlush.c,92,style,unusedFunction,The function 'getCurrentFlushState' is never used. -dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,93,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,252,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. -dgfirmware/firmware/App/Modes/ModeService.c,88,style,unusedFunction,The function 'getCurrentServiceState' is never used. -dgfirmware/firmware/App/Modes/ModeSolo.c,118,style,unusedFunction,The function 'getCurrentSoloState' is never used. -dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/App/Controllers/Fans.c,190,style,unusedFunction,The function 'getMeasuredFanRPM' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,209,style,unusedFunction,The function 'getPIControllerSignals' is never used. -dgfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,287,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,202,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,215,style,unusedFunction,The function 'isPOSTPassed' is never used. -dgfirmware/firmware/App/Drivers/Comm.c,259,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -dgfirmware/firmware/App/Drivers/SafetyShutdown.c,71,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,91,style,unusedFunction,The function 'phantomInterrupt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,511,style,unusedFunction,The function 'readLogData' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,400,style,unusedFunction,The function 'resetCriticalData' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,113,style,unusedFunction,The function 'rtiNotification' is never used. -dgfirmware/firmware/App/Services/Interrupts.c,242,style,unusedFunction,The function 'sciNotification' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'setBootloaderFlag' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,122,style,unusedFunction,The function 'setCPLDLampBlue' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,102,style,unusedFunction,The function 'setCPLDLampGreen' is never used. -dgfirmware/firmware/App/Drivers/CPLD.c,142,style,unusedFunction,The function 'setCPLDLampRed' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,360,style,unusedFunction,The function 'setCriticalData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'setDisinfectionDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,323,style,unusedFunction,The function 'setMfgData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,440,style,unusedFunction,The function 'setServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,534,style,unusedFunction,The function 'setTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,572,style,unusedFunction,The function 'setWaterConsumption' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,242,style,unusedFunction,The function 'stopDrainCmd' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,192,style,unusedFunction,The function 'stopFillCmd' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'testResetCalibrationData' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,476,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,566,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,521,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,455,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,544,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. -dgfirmware/firmware/App/Services/Reservoirs.c,499,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. -dgfirmware/firmware/FWCommon/Utilities.c,161,style,unusedFunction,The function 'u32DiffWithWrap' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,487,style,unusedFunction,The function 'writeLogData' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,145,style,unusedFunction,The function 'canErrorNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,124,style,unusedFunction,The function 'canMessageNotification' is never used. +dgfirmware/firmware/FWCommon/PersistentAlarm.c,329,style,unusedFunction,The function 'checkFPGAPersistentErrorCountAlarm' is never used. +dgfirmware/firmware/App/Drivers/Comm.c,133,style,unusedFunction,The function 'clearSCI2CommErrors' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,2608,style,unusedFunction,The function 'dequeue' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,219,style,unusedFunction,The function 'dmaGroupANotification' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1636,style,unusedFunction,The function 'enqueueNVRecordsForRead' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,570,style,unusedFunction,The function 'execROPumpSelfTest' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,470,style,unusedFunction,The function 'getCriticalData' is never used. +dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c,302,style,unusedFunction,The function 'getCurrentChemicalDisinfectFlushState' is never used. +dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,466,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeDrain.c,220,style,unusedFunction,The function 'getCurrentDrainState' is never used. +dgfirmware/firmware/App/Modes/ModeFault.c,148,style,unusedFunction,The function 'getCurrentFaultState' is never used. +dgfirmware/firmware/App/Modes/ModeFlush.c,280,style,unusedFunction,The function 'getCurrentFlushState' is never used. +dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.c,277,style,unusedFunction,The function 'getCurrentHeatDisinfectActiveCoolState' is never used. +dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,488,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,385,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeROPermeateSample.c,256,style,unusedFunction,The function 'getCurrentROPermeateSampleState' is never used. +dgfirmware/firmware/App/Modes/ModeService.c,96,style,unusedFunction,The function 'getCurrentServiceState' is never used. +dgfirmware/firmware/App/Modes/ModeSolo.c,122,style,unusedFunction,The function 'getCurrentSoloState' is never used. +dgfirmware/firmware/App/Modes/ModeStandby.c,879,style,unusedFunction,The function 'getCurrentStandbyState' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2217,style,unusedFunction,The function 'getFPGAADC1ErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2241,style,unusedFunction,The function 'getFPGAADC2ErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2372,style,unusedFunction,The function 'getFPGABaroErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1494,style,unusedFunction,The function 'getFPGADialysateFlowRate' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2009,style,unusedFunction,The function 'getFPGAEmstatCD1CD2RxErrCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2541,style,unusedFunction,The function 'getFPGAEmstatCPiCPoRxErrCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2667,style,unusedFunction,The function 'getFPGAHeaterGateADCErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1682,style,unusedFunction,The function 'getFPGAPrimaryHeaterFlags' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1695,style,unusedFunction,The function 'getFPGAPrimaryHeaterReadCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1569,style,unusedFunction,The function 'getFPGARTDErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1644,style,unusedFunction,The function 'getFPGATDiErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,2591,style,unusedFunction,The function 'getFPGATHdErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1608,style,unusedFunction,The function 'getFPGATRoErrorCount' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1721,style,unusedFunction,The function 'getFPGATrimmerHeaterFlags' is never used. +dgfirmware/firmware/App/Services/FPGA.c,1734,style,unusedFunction,The function 'getFPGATrimmerHeaterReadCount' is never used. +dgfirmware/firmware/App/Controllers/DrainPump.c,645,style,unusedFunction,The function 'getFlushLineVolumeL' is never used. +dgfirmware/firmware/App/Controllers/LoadCell.c,495,style,unusedFunction,The function 'getLoadCellVelocity' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,231,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,793,style,unusedFunction,The function 'getReservoirsCalRecord' is never used. +dgfirmware/firmware/FWCommon/TestSupport.c,94,style,unusedFunction,The function 'getS32OverrideValue' is never used. +dgfirmware/firmware/FWCommon/TestSupport.c,51,style,unusedFunction,The function 'getU08OverrideValue' is never used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,898,style,unusedFunction,The function 'handleDGScheduledRunsRequest' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,677,style,unusedFunction,The function 'isCriticalDataSet' is never used. +dgfirmware/firmware/App/Controllers/Valves.c,501,style,unusedFunction,The function 'isFliterFlushRequired' is never used. +dgfirmware/firmware/App/Drivers/Comm.c,147,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,76,style,unusedFunction,The function 'phantomInterrupt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1404,style,unusedFunction,The function 'readLogData' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,585,style,unusedFunction,The function 'resetCriticalData' is never used. +dgfirmware/firmware/App/Controllers/LoadCell.c,396,style,unusedFunction,The function 'resetLoadCellOffset' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,89,style,unusedFunction,The function 'rtiNotification' is never used. +dgfirmware/firmware/App/Services/Interrupts.c,189,style,unusedFunction,The function 'sciNotification' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,545,style,unusedFunction,The function 'setCriticalData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1593,style,unusedFunction,The function 'setHeatersInfoRecord' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,869,style,unusedFunction,The function 'setROPIFlowProfile' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,288,style,unusedFunction,The function 'setROPumpTargetFlowRateDelayed' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1457,style,unusedFunction,The function 'setTxLastStartTimeEpoch' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1426,style,unusedFunction,The function 'setTxTimeHours' is never used. +dgfirmware/firmware/FWCommon/RTC.c,511,style,unusedFunction,The function 'syncDG2HDDateTime' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1087,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1132,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1066,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. +dgfirmware/firmware/App/Services/Reservoirs.c,1110,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,345,style,unusedFunction,The function 'u16BiDiffWithWrap' is never used. +dgfirmware/firmware/FWCommon/Utilities.c,296,style,unusedFunction,The function 'u32BiDiffWithWrap' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1380,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)