Index: PersistentAlarm.c =================================================================== diff -u -r97f119050f52c01aa9346c80b706dfdbbda3ac9e -r4b13eff164ec468e415fff197ed8af3b85504df0 --- PersistentAlarm.c (.../PersistentAlarm.c) (revision 97f119050f52c01aa9346c80b706dfdbbda3ac9e) +++ PersistentAlarm.c (.../PersistentAlarm.c) (revision 4b13eff164ec468e415fff197ed8af3b85504df0) @@ -7,8 +7,8 @@ * * @file PersistentAlarm.c * -* @author (last) Quang Nguyen -* @date (last) 17-Aug-2020 +* @author (last) Sean Nash +* @date (last) 01-Oct-2020 * * @author (original) Quang Nguyen * @date (original) 17-Aug-2020 @@ -17,6 +17,7 @@ #include "AlarmMgmt.h" #include "PersistentAlarm.h" +#include "Timers.h" /** * @addtogroup PersistentAlarm @@ -31,11 +32,11 @@ ALARM_ID_T alarm; ///< Alarm id BOOL isClearable; ///< Flag if alarm can be cleared - U32 persistentClearCount; ///< Persistent count limit before clear alarm - U32 persistentTriggerCount; ///< Persistent count limit before trigger alarm + U32 persistentClearPeriod; ///< Persistent count limit before clear alarm + U32 persistentTriggerPeriod; ///< Persistent count limit before trigger alarm - U32 inRangeCounter; ///< Data in range persistent counter - U32 outOfRangeCounter; ///< Data out of range persistent counter + U32 inRangeStartTime; ///< Data in range persistent counter + U32 outOfRangeStartTime; ///< Data out of range persistent counter } PERSISTENT_ALARM_DATA_T; // ********** private data ********** @@ -48,27 +49,26 @@ * @brief * The initPersistentAlarm function initializes the PersistentAlarm module * when the alarm count lower than maximum persistent alarm allowed. - * @details - * Inputs : none - * Outputs : PersistentAlarm module initialized + * @details Inputs: none + * @details Outputs: PersistentAlarm module initialized * @param alarmIndex Persistent alarm index * @param alarm Alarm id * @param isClearable Flag to indicate alarm is clearable or not - * @param persistentClearCount Persistent count limit before clear alarm - * @param persistentTriggerCount Persistent count limit before trigger alarm + * @param persistentClearPeriod Persistent period limit before clear alarm + * @param persistentTriggerPeriod Persistent period limit before trigger alarm * @return none *************************************************************************/ void initPersistentAlarm( PERSISTENT_ALARM_T alarmIndex, ALARM_ID_T alarm, BOOL isClearable, - F32 persistentClearCount, F32 persistentTriggerCount ) + U32 persistentClearPeriod, U32 persistentTriggerPeriod ) { if ( alarmIndex < NUM_OF_PERSISTENT_ALARM ) { - persistentAlarms[ alarmIndex ].alarm = alarm; - persistentAlarms[ alarmIndex ].isClearable = isClearable; - persistentAlarms[ alarmIndex ].persistentClearCount = persistentClearCount; - persistentAlarms[ alarmIndex ].persistentTriggerCount = persistentTriggerCount; - persistentAlarms[ alarmIndex ].inRangeCounter = 0U; - persistentAlarms[ alarmIndex ].outOfRangeCounter = 0U; + persistentAlarms[ alarmIndex ].alarm = alarm; + persistentAlarms[ alarmIndex ].isClearable = isClearable; + persistentAlarms[ alarmIndex ].persistentClearPeriod = persistentClearPeriod; + persistentAlarms[ alarmIndex ].persistentTriggerPeriod = persistentTriggerPeriod; + persistentAlarms[ alarmIndex ].inRangeStartTime = 0U; + persistentAlarms[ alarmIndex ].outOfRangeStartTime = 0U; } else { @@ -85,9 +85,8 @@ * The checkPersistentAlarm function check whether data is out of range or * not. Then the function set or clear alarm once the persistent counter * exceeds the limit. - * @details - * Inputs : none - * Outputs : Checks for out of range data and set/clear alarm + * @details Inputs: none + * @details Outputs: Checks for out of range data and set/clear alarm * @param alarmIndex Persistent alarm index * @param isOutOfRange Flag indicates data out of range * @param data Data to be check for out of range @@ -100,18 +99,24 @@ { if ( isOutOfRange ) { - ++persistentAlarms[ alarmIndex ].outOfRangeCounter; - persistentAlarms[ alarmIndex ].inRangeCounter = 0; - if ( persistentAlarms[ alarmIndex ].outOfRangeCounter > persistentAlarms[ alarmIndex ].persistentTriggerCount ) + persistentAlarms[ alarmIndex ].inRangeStartTime = 0; + if ( persistentAlarms[ alarmIndex ].outOfRangeStartTime == 0 ) { + persistentAlarms[ alarmIndex ].outOfRangeStartTime = getMSTimerCount(); + } + if ( didTimeout( persistentAlarms[ alarmIndex ].outOfRangeStartTime, persistentAlarms[ alarmIndex ].persistentTriggerPeriod ) ) + { SET_ALARM_WITH_2_F32_DATA( persistentAlarms[ alarmIndex ].alarm, data, limit ); } } else { - ++persistentAlarms[ alarmIndex ].inRangeCounter; - persistentAlarms[ alarmIndex ].outOfRangeCounter = 0; - BOOL const isInRangePersistent = persistentAlarms[ alarmIndex ].inRangeCounter > persistentAlarms[ alarmIndex ].persistentClearCount; + persistentAlarms[ alarmIndex ].outOfRangeStartTime = 0; + if ( persistentAlarms[ alarmIndex ].inRangeStartTime == 0 ) + { + persistentAlarms[ alarmIndex ].inRangeStartTime = getMSTimerCount(); + } + BOOL const isInRangePersistent = didTimeout( persistentAlarms[ alarmIndex ].inRangeStartTime, persistentAlarms[ alarmIndex ].persistentClearPeriod ); if ( persistentAlarms[ alarmIndex ].isClearable && isInRangePersistent ) { clearAlarm( persistentAlarms[ alarmIndex ].alarm );