Index: firmware/App/Controllers/DialOutFlow.c =================================================================== diff -u -r3d8d8451d10aaf2ea9fc9d83857699ef1ae1a0be -r2593d24ad372b16af13b5e7022a86498a4010ada --- firmware/App/Controllers/DialOutFlow.c (.../DialOutFlow.c) (revision 3d8d8451d10aaf2ea9fc9d83857699ef1ae1a0be) +++ firmware/App/Controllers/DialOutFlow.c (.../DialOutFlow.c) (revision 2593d24ad372b16af13b5e7022a86498a4010ada) @@ -255,58 +255,62 @@ // Direction change while pump is running is not allowed if ( ( FALSE == isDialOutPumpOn ) || ( 0 == flowRate ) || ( dir == dialOutPumpDirectionSet ) ) { + F32 pwmDC = DOP_PWM_FROM_ML_PER_MIN( (F32)flowRate ); + + // Don't interrupt pump control unless rate or mode is changing + if ( ( fabs( pwmDC - dialOutPumpPWMDutyCyclePct ) > NEARLY_ZERO ) || ( mode != dialOutPumpControlMode ) ) + { #ifndef NO_PUMP_FLOW_LIMITS - // Verify flow rate - if ( flowRate <= MAX_DIAL_OUT_FLOW_RATE ) + // Verify flow rate + if ( flowRate <= MAX_DIAL_OUT_FLOW_RATE ) #endif - { - F32 adjFlow = (F32)flowRate; - - resetDialOutFlowMovingAverage(); - dopControlSignal = FALSE; - lastGivenRate = flowRate; - dialOutPumpDirection = dir; - dialOutPumpControlMode = mode; - // Set PWM duty cycle target to an estimated initial target to ramp to based on target flow rate - then we will control to flow when ramp completed - dialOutPumpPWMDutyCyclePct = DOP_PWM_FROM_ML_PER_MIN(adjFlow); - dialOutPumpPWMDutyCyclePct = MIN( dialOutPumpPWMDutyCyclePct, MAX_DIAL_OUT_PUMP_PWM_DUTY_CYCLE ); - - switch ( dialOutPumpState ) { - case DIAL_OUT_PUMP_RAMPING_UP_STATE: // See if we need to reverse direction of ramp - if ( dialOutPumpPWMDutyCyclePct < dialOutPumpPWMDutyCyclePctSet ) - { - dialOutPumpState = DIAL_OUT_PUMP_RAMPING_DOWN_STATE; - } - break; - case DIAL_OUT_PUMP_RAMPING_DOWN_STATE: // See if we need to reverse direction of ramp - if ( dialOutPumpPWMDutyCyclePct > dialOutPumpPWMDutyCyclePctSet ) - { - dialOutPumpState = DIAL_OUT_PUMP_RAMPING_UP_STATE; - } - break; - case DIAL_OUT_PUMP_CONTROL_TO_TARGET_STATE: // Start ramp to new target in appropriate direction - if ( dialOutPumpPWMDutyCyclePctSet > dialOutPumpPWMDutyCyclePct ) - { - dialOutPumpState = DIAL_OUT_PUMP_RAMPING_DOWN_STATE; - } - else - { - dialOutPumpState = DIAL_OUT_PUMP_RAMPING_UP_STATE; - } - break; - default: - // Ok - not all states need to be handled here - break; + resetDialOutFlowMovingAverage(); + dopControlSignal = FALSE; + lastGivenRate = flowRate; + dialOutPumpDirection = dir; + dialOutPumpControlMode = mode; + // Set PWM duty cycle target to an estimated initial target to ramp to based on target flow rate - then we will control to flow when ramp completed + dialOutPumpPWMDutyCyclePct = pwmDC; + dialOutPumpPWMDutyCyclePct = MIN( dialOutPumpPWMDutyCyclePct, MAX_DIAL_OUT_PUMP_PWM_DUTY_CYCLE ); + + switch ( dialOutPumpState ) + { + case DIAL_OUT_PUMP_RAMPING_UP_STATE: // See if we need to reverse direction of ramp + if ( dialOutPumpPWMDutyCyclePct < dialOutPumpPWMDutyCyclePctSet ) + { + dialOutPumpState = DIAL_OUT_PUMP_RAMPING_DOWN_STATE; + } + break; + case DIAL_OUT_PUMP_RAMPING_DOWN_STATE: // See if we need to reverse direction of ramp + if ( dialOutPumpPWMDutyCyclePct > dialOutPumpPWMDutyCyclePctSet ) + { + dialOutPumpState = DIAL_OUT_PUMP_RAMPING_UP_STATE; + } + break; + case DIAL_OUT_PUMP_CONTROL_TO_TARGET_STATE: // Start ramp to new target in appropriate direction + if ( dialOutPumpPWMDutyCyclePctSet > dialOutPumpPWMDutyCyclePct ) + { + dialOutPumpState = DIAL_OUT_PUMP_RAMPING_DOWN_STATE; + } + else + { + dialOutPumpState = DIAL_OUT_PUMP_RAMPING_UP_STATE; + } + break; + default: + // Ok - not all states need to be handled here + break; + } + result = TRUE; } - result = TRUE; - } #ifndef NO_PUMP_FLOW_LIMITS - else // Requested flow rate too high - { - SET_ALARM_WITH_2_U32_DATA( ALARM_ID_HD_SOFTWARE_FAULT, SW_FAULT_ID_DIAL_OUT_FLOW_SET_TOO_HIGH, flowRate ) - } + else // Requested flow rate too high + { + SET_ALARM_WITH_2_U32_DATA( ALARM_ID_HD_SOFTWARE_FAULT, SW_FAULT_ID_DIAL_OUT_FLOW_SET_TOO_HIGH, flowRate ) + } #endif + } } return result;